From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by sourceware.org (Postfix) with ESMTPS id E739B3858428 for ; Mon, 11 Jul 2022 13:53:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E739B3858428 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kd1haBJn1VwDFx0/5DKTYDvVQM8a4M5TI1K2mjPk138OxWI5hXRhZ26sH78kaY9fElxAqimIIMWotYbtvoFbinDGagisOIRckC4PxIZePYQK9Gj89tAI3SktCA61aaqJUDYTcD9eZIEmA6vJw3Vjpv7jQ8CekEDWC1Zm28J7b2L72vkBbmWd/NOhe0wzjfbwv+yaUeaB+UbrX9EimqO4DF0lltzOnhs9h3q0dAS4U2rdfmejELGgGDmIk/XT2kP+P/uRXsMODaeDBixbn2uXR2I5MgUGV8k+4Bo89Xf7V+Dkrzy7gqrb6t0uojgHY0J8MjDvPFXM0WKB2AxVgkkEdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HeF1+y+m8YUm7gmW+NMYwFlxC+UR7nG3ZEvod88/IOI=; b=P2twqec2Erffk8aK/QBYm7F+e0CiP53rtUI+F55Urz0whyBKH5bokkx4J3flZXjKXat/wHbQ08lOK3KCwJa9+s5SkORlOXjeGAGG3b74lOiJD/ipRq8rBaVEK64gwbXrFQ6s7cOWpRCVwWwr/N5a19Le5RV70csnPL7wJ2eoVmjeuC078dqSPkU6AioaeHDQBZJE9II/j2IpBEHYqpp79Q2r5ZewnACPw9PJJ6LtLFcVmS9F1uzQZ53g58TEtHtsB6dvq1N5xUWxRv0fxsRzc2NVVIGeyiN/iqU4efbWMhaU9VuuCMIdvRE8PuIW/0yb7XmM3fSerRiv2lL+l5ljrA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM5PR0602CA0020.eurprd06.prod.outlook.com (2603:10a6:203:a3::30) by VI1PR08MB4416.eurprd08.prod.outlook.com (2603:10a6:803:ff::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Mon, 11 Jul 2022 13:53:04 +0000 Received: from AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::27) by AM5PR0602CA0020.outlook.office365.com (2603:10a6:203:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Mon, 11 Jul 2022 13:53:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT057.mail.protection.outlook.com (10.152.17.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 13:53:04 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Mon, 11 Jul 2022 13:53:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1b8a9992bded50aa X-CR-MTA-TID: 64aa7808 Received: from 45fe8b3424cb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CDF4FBA4-FEDD-4532-948B-260CF1E676DE.1; Mon, 11 Jul 2022 13:52:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45fe8b3424cb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 13:52:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/LX+WBDzb+08edI9DzwnVZz83sXZZ1CyNmJi3gk4PAqwYvLgrmSXKZ2jvdT7/8MmZTQiSg3rWL15xRp5RWsKeVylLA/z3WgA5ngyRti5F5cxxBvhPHDL+s4fNMTwwHGGmQOPIvmcHEmqa8uQLgxik52OIxdsf8V8m78e1WUbx9HjAm5SthdYj7dWzA26g228gXRe+dYHwJjXyXGC6d6byyuVSgAsMx77JU092Fe4eN3mnnpvT02Sy86Axn8GMi3EltAqUM9aeRFzc6IIBeiR55q67sFh4fVdNucP9IbMnP2EDpZoR9Ryn7kT9CfNhcNk5VVFXnDZHBwF5bZLP8qXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HeF1+y+m8YUm7gmW+NMYwFlxC+UR7nG3ZEvod88/IOI=; b=ayVRXAbB02rrlhkojmwVCn/uWUfa1gTzHnLHEz4SfzHBU6+OD2Rtd10bssJyP36M+VfYu0L7TBD+jBXfO3ZIGJazv20Iygd72TtZw9H9Az2l4fYZpSgu7ViulcsqI7QEKnrZT0/bk8ZdPCrRLAKqKz8sp6sF2wH9H43MEZzEmwxOZ1NPb5HrrgUSgtNPyR1mJD3Qctc+yECA0/VloNYGSD3bahC/LMhvOoSL1OCkhx8alIqCaoY7ysZjGPwwmUZg7t3FcEFjGmpT/Wv6SaUYmP2jWZ7ir9zwEZOueDhWaNkqx59ai4eqQiy0q0JRuaFtddBiKtq5h3CVc0uJDPzk3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM0PR08MB4177.eurprd08.prod.outlook.com (2603:10a6:208:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Mon, 11 Jul 2022 13:52:56 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c%4]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 13:52:56 +0000 Message-ID: <77ddf084-b537-58f4-5804-869b44baa81f@arm.com> Date: Mon, 11 Jul 2022 14:52:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdbserver: remove unused variable Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org References: From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0471.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::27) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d526599c-7bf9-4d42-0a9b-08da6344ad62 X-MS-TrafficTypeDiagnostic: AM0PR08MB4177:EE_|AM5EUR03FT057:EE_|VI1PR08MB4416:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pvIGfVcQ2ei1DZQq6xypiaWwA6LUbg5BrH6F8kqMRoPP24Q1wZslhExrIRADcWBg082pWcEXODmC0FVrcpdt16UOt1BsElZKX6TLCSO3HAvm7ee1IkoDP7Gp5YT4Wn9HghqvOVxwStz1+WkqeGxTQpqr7Qjl4rsLbVVgug5WCSLshQDVHNomC1kseE0R5YdjNzDf88EFqpVV4DUTtw414KeQ6NKIrXF7igXDkOBOiGGuAylfaesQLGlm+u6u6AnNaxF7N6AVA0/TqrXzjoy1J3tGy8gv4roZ1//L+Po8GAvXdfHGkoADTc4aJqomNzB0hAQBEtSwEdDyApVXjKzr26o1cWFbV8JSs3QEjuRg6wsgtmiKQCrqCGWCF162gdp1J0jbPSPddChe4gM/TGGOVhyIfG0Gy4L/9n8Ob/bFFN7XXujVkwXVzDVYdqt6L/yuIYf1Dtf6tvo+gAZKtNLzHYIvKWNbg4j6+6h9pd3RveTDEWA1q8T1OnVGxBOcRjwZoNkeFvILj1FXlUvbU1mqYEsHFIrJdJbWfYFqnWLEDDAU7ovzTb7r1x2mmakfcFQ+7HVar4b0h4aKb+IV6EsdxY4A+ubZn9i8U/WGAeym9tzx5o04XvEPBc/mGSLKwt52LWU9agPqN6lMW8q3V89lr46S27UogMDRjUPFs80zNnFAQtr2QVwO48VpOUYWe98g9FzofcfcrQ9HWwDE2XPB1z1xYhbLRVCBhzIuj9jZvPyiiKqkfnN+MwYg42gSw73MxFsbP2fiCr/Pqy/zPyZbES31CK0Ud6W7tRAnYinMnXd18+h+34YHaUR7MKa82BTGnDicjAnqDruMhGStRyp/SpkoIW2Kdhxba9xdHyM2qy4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(44832011)(36756003)(2906002)(5660300002)(8936002)(31686004)(66946007)(86362001)(66476007)(6486002)(316002)(8676002)(478600001)(6506007)(186003)(41300700001)(26005)(66556008)(2616005)(6512007)(38100700002)(83380400001)(53546011)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4177 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d352c706-7398-4910-7846-08da6344a81c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: crJCmhPppaGLfw2KC8BbINm4PsTfFSJJReqSWAMXWxuZ0sIQzUbnFLm6susxl84BWM18r3SiyIK+bXFm0JrFqNh6ynE0OUgcWtrMKHk1sMPWUrM7kf/5rgrPCG2PN7XBxYd3FW0rlhO1M9FgwTKlvoqFZJx6T7KQP5ASADVAg8t+c9Ouw2oeh7v6KVsnRXf8kg5LSMPePfsJ79SNB5OwF2pTZAGGF3BqLoYGw4QOTuTKaIOOq4O9Zl2/a1uMxkJjH+hBABIO3NWPBWd92wOs08VUzbIoqgBNnY8p5AHpPrC1RQURdt/zjgjxevN2oWmmHohyLy6aSMLxR8Bwl+CWnHTA/LX8khAlj9gEKz+Fx4+MXQdOPE9CWxppcnA/BMKvdJTQ/7SEvmyPQ5uiFfmkomwtMkNOCQbWlVAcDmyxeX694nUMn/hpYoZ3Szlj9jMe9u9+VqTMV6ufgeJpkN5LEt+Gl49cPA80l1ZFUYz40Mg0Xp3B7HWKPfygGMKj8cvIUcJg9NGZaW6HWjZaV9yjNE3b8KW40baFLVEnBRG4spyStMkOjyltYsH6DdcssEGIdtb+sNBnQfvI4LXfs++W8TX2fIK50iarCj7osjiUijB3Vz5RcLT8Nzkt6szt6YNITMcbBEYY6llt8tCxLkEIGjiVCtRq5LMMf72V4CqnAd87OrIflZ4gLqkgjnAqGcQW9J4/7VLjbMhLLOMZn6YmPs8daOpnHQnC4iFdZ9VjtqcuKi8oipgmAL2/x/DGWrdcLDCNQSMsM/PACnOoLIrwA+LLjxEBUsNBiQrxfaLkdZsCPdxYmeNuf+YXRJaur3YIEer1g1QRUQBeg8sCdAoHASoQofq5MOup0AIzkIarkEQ= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966006)(36840700001)(40470700004)(2616005)(81166007)(31696002)(6486002)(356005)(82740400003)(83380400001)(36860700001)(8676002)(186003)(70586007)(336012)(47076005)(44832011)(8936002)(5660300002)(70206006)(40460700003)(2906002)(6512007)(82310400005)(41300700001)(40480700001)(478600001)(316002)(86362001)(6506007)(26005)(53546011)(36756003)(31686004)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 13:53:04.3687 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d526599c-7bf9-4d42-0a9b-08da6344ad62 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4416 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 13:53:11 -0000 On 7/11/22 13:53, Enze Li via Gdb-patches wrote: > When building with clang 15, I got this error: > > CXX server.o > server.cc:2985:10: error: variable 'new_argc' set but not used [-Werror,-Wunused-but-set-variable] > int i, new_argc; > ^ > Remove the unused variable to eliminate the error. > > Tested by rebuilding on x86_64-linux with clang 15. > --- > gdbserver/server.cc | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index f9c02a9c6dac..c619206d5d2d 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -2982,14 +2982,10 @@ handle_v_run (char *own_buf) > char *p, *next_p; > std::vector new_argv; > char *new_program_name = NULL; > - int i, new_argc; > + int i; > > - new_argc = 0; > for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';')) > - { > - p++; > - new_argc++; > - } > + p++; > > for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i) > { Looks reasonable to me. Someone else should OK it though.