From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A2B743858C52 for ; Fri, 14 Oct 2022 23:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2B743858C52 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29ENG6PI003046 for ; Fri, 14 Oct 2022 23:20:59 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3k7h9g02jn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 14 Oct 2022 23:20:58 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29ENJamK012720 for ; Fri, 14 Oct 2022 23:20:58 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3k7h9g02jd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 23:20:58 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29EN5DEg018137; Fri, 14 Oct 2022 23:20:57 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma04dal.us.ibm.com with ESMTP id 3k30uax46q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 23:20:57 +0000 Received: from smtpav02.wdc07v.mail.ibm.com ([9.208.128.114]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29ENKuHO8585754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Oct 2022 23:20:56 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C66558058; Fri, 14 Oct 2022 23:20:56 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A825B58059; Fri, 14 Oct 2022 23:20:55 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.71.228]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 14 Oct 2022 23:20:55 +0000 (GMT) Message-ID: <77e2fe42445eccb85e5521c633db5ec2afe89e2e.camel@us.ibm.com> From: Carl Love To: Kevin Buettner , gdb-patches@sourceware.org Cc: Ulrich Weigand , cel@us.ibm.com Date: Fri, 14 Oct 2022 16:20:55 -0700 In-Reply-To: <20221007212032.1944919c@f35-zws-1> References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <5a34aaeab59f0099b915d1780c701284a6cf691e.camel@us.ibm.com> <8aa882863b2f4cef38c22386387c5705bf63c3d5.camel@de.ibm.com> <56392545859f7e949ee1b8fa2198f3928f714bad.camel@us.ibm.com> <20221007212032.1944919c@f35-zws-1> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0LHlM5YoJXaA8_HoREzOIuv-v6XYs78G X-Proofpoint-ORIG-GUID: XU5e2_h0aznmXGUikkJU8F4qeb8kd3v1 Subject: RE: [PATCH 1/2] PowerPC, function ppc64_sysv_abi_return_value add missing return value convention X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_11,2022-10-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 mlxlogscore=707 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210140127 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 23:21:00 -0000 On Fri, 2022-10-07 at 21:20 -0700, Kevin Buettner wrote: > Hi Carl, > > See my comments below... > > On Thu, 06 Oct 2022 09:37:10 -0700 > Carl Love via Gdb-patches wrote: > > > should return RETURN_VALUE_STRUCT_CONVENTION if the valtype->code() > > is > > TYPE_CODE_STRUCT and if the language_pass_by_reference is not > > trivially_copyable. > > > > This patch adds the need code to return the value > > s/need/needed/ fixed > > > RETURN_VALUE_STRUCT_CONVENTION in the case of this case. > > s/the case of // fixed.