From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B529B3858D1E for ; Tue, 13 Sep 2022 13:55:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B529B3858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-PVKKvwHDNzeWhIaVJXbbZg-1; Tue, 13 Sep 2022 09:55:08 -0400 X-MC-Unique: PVKKvwHDNzeWhIaVJXbbZg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E03E0101A54E; Tue, 13 Sep 2022 13:55:07 +0000 (UTC) Received: from [10.2.16.11] (unknown [10.2.16.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8572540C6EC2; Tue, 13 Sep 2022 13:55:07 +0000 (UTC) Message-ID: <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> Date: Tue, 13 Sep 2022 06:55:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile To: Simon Marchi , gdb-patches@sourceware.org References: <20220912224733.2962282-1-keiths@redhat.com> <383112d6-4d64-38e5-9e77-3f46b845e494@simark.ca> From: Keith Seitz In-Reply-To: <383112d6-4d64-38e5-9e77-3f46b845e494@simark.ca> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 13:55:13 -0000 On 9/13/22 06:34, Simon Marchi wrote: > With your patch applied, I tried re-generating everything: > > $ cd features > $ rm *.c */*.c > $ make cfiles GDB="/home/simark/build/binutils-gdb-all-targets/gdb/gdb --data-directory=/home/simark/build/binutils-gdb-all-targets/gdb/data-directory" > > And then git shows these files as missing: > > deleted: aarch64-sve.c > deleted: cskyv2-linux.c > > aarch64-sve.c is not generate, so it's actually fine. cskyv2-linux.c is > generated, but we are missing the XML for it, I sent a reply to the > patch thread that added it to ask the author to upload it. Bah. I caught aarch64-sve.c, but not the other. Thank you for catching that. I will keep my eye out for it and update when cskyv2-linux.xml reappears. > > When typing just "make" in features/, I get this diff: > > diff --git a/gdb/regformats/or1k-linux.dat b/gdb/regformats/or1k-linux.dat > index 7b64646fc65a..9a9f8a640188 100644 > --- a/gdb/regformats/or1k-linux.dat > +++ b/gdb/regformats/or1k-linux.dat > @@ -2,7 +2,7 @@ > # Generated from: or1k-linux.xml > name:or1k_linux > xmltarget:or1k-linux.xml > -expedite:r1,npc > +expedite: > 32:r0 > 32:r1 > 32:r2 > > Probably a separate fix, but I think we need > > or1k-expedite = r1,npc > > in features/Makefile Just typing "make" in features does nothing here. Am I neglecting to do something? >> rs6000/powerpc-32.xml \ >> rs6000/powerpc-32l.xml \ >> rs6000/powerpc-403.xml \ >> diff --git a/gdb/features/arm/arm-secext.c b/gdb/features/arm/arm-secext.c >> index 39ef4afb05f..c71cffd2db6 100644 >> --- a/gdb/features/arm/arm-secext.c >> +++ b/gdb/features/arm/arm-secext.c >> @@ -4,7 +4,7 @@ >> #include "gdbsupport/tdesc.h" >> >> static int >> -create_feature_arm_arm_m_system (struct target_desc *result, long regnum) >> +create_feature_arm_arm_secext (struct target_desc *result, long regnum) > > This change looks good, it was obviously wrong before. But I don't see > any call to create_feature_arm_arm_secext in the code base, so what is > the point of this file? Should the arm tdep code use it? It might be > worth asking in the thread that added this file. Before submitting, I did email the original author, who CC'd Luis. I've added him (Luis) to CC so that he can answer here more definitively than any paraphrase in which I might introduce confusion. Keith