From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81598 invoked by alias); 14 Jun 2018 13:52:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80477 invoked by uid 89); 14 Jun 2018 13:52:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 13:52:29 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA5C3738E0; Thu, 14 Jun 2018 13:52:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EB8C111AF1C; Thu, 14 Jun 2018 13:52:27 +0000 (UTC) Subject: Re: [PATCH, testsuite] Allow function arguments in bp print match in selftest_setup To: Tom de Vries References: <20180612151500.xgw27odexd5fgyww@localhost.localdomain> <8f1dae31-ac6c-74e2-1851-ca885193aa89@redhat.com> <20180614102107.cgh6iixu324pmpvi@localhost.localdomain> <51e2fa52-222b-6ec0-16d3-8c99fcc9a310@redhat.com> <25b1dca5-becc-cef5-1583-6750032064af@suse.de> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <78069162-c9c6-2def-08ba-9d33ed185280@redhat.com> Date: Thu, 14 Jun 2018 13:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <25b1dca5-becc-cef5-1583-6750032064af@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00361.txt.bz2 On 06/14/2018 02:49 PM, Tom de Vries wrote: > On 06/14/2018 12:45 PM, Pedro Alves wrote: >> On 06/14/2018 11:21 AM, Tom de Vries wrote: >> >>>> [1] Funny, it passes for me (with the fix for stopping at captured_main), >>>> because the pattern below the one you're touching matches: >>>> >>>> -re "Starting program.*Breakpoint \[0-9\]+,.* at .*main.c:.*$function.*$gdb_prompt $" { >>>> # $function may be inlined, so the program stops at the line >>>> # calling $function. >>>> pass "$description" >>>> } >>>> >>>> and it only happens to match because captured_main calls >>>> captured_main_1 first thing, which coincidentally >>>> matches "$function.*": >>>> >>>> Breakpoint 1, captured_main (data=) at gdb/binutils-gdb/src/gdb/main.c:1147 >>>> 1147 captured_main_1 (context); >>>> >>>> That would probably be better "$function .*", with a space, >>> Right, I observed that as well, and was thinking of this type of fix. > >> Please don't be shy about stating those things upfront, makes >> review easier. :-) >> > > Ack, yeah, sorry about that. I'm currently visiting the Nuremberg > office, so I'm a bit more distracted than usual. Really no biggie. Thanks for all the fixes. Hope you're having fun. :-) Thanks, Pedro Alves