From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2045.outbound.protection.outlook.com [40.107.6.45]) by sourceware.org (Postfix) with ESMTPS id DE2FC3858429 for ; Mon, 18 Dec 2023 15:11:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE2FC3858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE2FC3858429 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.45 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1702912278; cv=pass; b=TL+jYp3sYfTwjUi/LvFtbTeQEQHZVn2kIY87tdgN+rhFT0dBjZCP8pau55orZCf5d1R7e889nO/ZlFm6a/+0U4GwuQAc2xL9EQief42PkcicvgkwDBadqglxselKb+ZfYqVzbERGbKuR8E+h+E9m79iTS9pFdbUtZCX1fveHwV4= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1702912278; c=relaxed/simple; bh=0G78DsEEy3gjWI/gRJO7ORU0+TJlhk4aIz+67NVpJAU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=Eplr78UBO+QF+4+xa783sEWoKuyL8wJf+EsVMyM3On5Ke/KToI/WPDVQMl4Cjoyi+H7H2cohvXdhSLSFCdjV91yT+ot7p/KZtW9h7KAo7fBLG6h8OQhDzEI7DsDoiuZzjPmLBmmlzD5Ko/nUkcg1pdqdb9q9IGJqnpbbsLDKlsM= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RMXWm+EuenkkAGjD1T/9yJkltKHF/MeGUZXvYLIhPGevZd03qJ/QmaGxHg7nAAa9MZUBmL2sQiiU4g3cL8A+SiJtlChXidLbl+SRDsQOWIEoRZKrNo/iAQbh4Dwfr6C/IOC3O6AqcyRdmHXS+pI300FBxM2av6dqWUZQCQSvDeZCMUkwN4ZrFnMFgdgfXEYTAsMNTdXlnjObYsuomHLg51qoK0n2NvhlGg3SLc9fx3WgRTVuw9Hgscp1GvyI4pNpmqr6mxc7Dc5elGWBkCknpF33Lg5sEIqGALmby4d37GbBgn3lguEPtbpiyVQzQxlwzUUDmmV1WGOe2drrkgl5Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjA7qr/aoP6ffdIVPf0Y5dbBdKScm+2IbSvDmzcY4ho=; b=TMMKHv12d9VYijmIJ0548Hos8tHQm0K6tX5HQD6EZmTIXvt7vCNpOXxYmxZIxag1RO0hVw1WS8UuylilVd/tfUNF0QJ8Acjg+xNPNKHWwkrhH67egeeZuKEr8QLSY9B83XFM7YHE5x3HyyQDK/AAqz3vOJ4xrcYuMYR63+hO9At37hHpJURbJOatYbYFJcc9BIJkM4VeQlIGGV+ofi81U/v0gXIeWAp7s+0QYfxGaOlH2ENC81w0z8eMXNJviv7EWgxlcOB6szPo1mEsvR1cKkbgVgVmGLl8s1aN6b1FRnbSzoCnNxkLsLIOdl5u0zrIXflyLxwEvJ+8FzCvXJpEMw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjA7qr/aoP6ffdIVPf0Y5dbBdKScm+2IbSvDmzcY4ho=; b=ic3lRZEJR1WnCmBCM2+Yk72p9MSf/fqzAjd1pDnqNLN7rW6ewcakSH8O9BDKhYff2h9Q1yJXpJZzTV6g/bfksDey8zVeTExitHb+W8CY4f6RBfo4kf74Z3b2whphB5xQa+RG3nyrdFfDQEHfdjlfb77He4vYd01iftkxrLlKsOo= Received: from AS9PR06CA0483.eurprd06.prod.outlook.com (2603:10a6:20b:49b::8) by AS8PR08MB6424.eurprd08.prod.outlook.com (2603:10a6:20b:33e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:11:04 +0000 Received: from AMS1EPF0000004A.eurprd04.prod.outlook.com (2603:10a6:20b:49b:cafe::35) by AS9PR06CA0483.outlook.office365.com (2603:10a6:20b:49b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 15:11:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS1EPF0000004A.mail.protection.outlook.com (10.167.16.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 15:11:03 +0000 Received: ("Tessian outbound 7671e7ddc218:v228"); Mon, 18 Dec 2023 15:11:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6673cdd3d26b28cc X-CR-MTA-TID: 64aa7808 Received: from c9ffd0db9619.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B948EE44-41A8-4C34-B875-F6A21A71E160.1; Mon, 18 Dec 2023 15:10:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9ffd0db9619.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Dec 2023 15:10:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i73/OHPK6f1Qp/X4AtgQJKS/yI5YBIkUrKgq5ddqBjaha3VblDPVX6NDyJYwnp+8uYgeRwPB+a5FZGeTOAYKLguBPpH67l2JgLIDhlgLA/hkdXapnLMxLHQGxZtO1IT04qX6cVevdRohbaXzDPiTR+0KexHMDlAMQDD4OoLvTXNZ3GDhv2fFgCc1j6KwrbzrLBVoP9v+CIoIcMwUzqCC51vT1WruYGkmKcKVkCJq3wwB0GMNV/gl73nQCprEe1tcvDSaEsvssZJrSSzGojHhI90RWplX4dKuF6+x5yIZsQs0atN2kiyZJhU3Mb9a7l0pHoCzoYTwCU7t86R9zHQgmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjA7qr/aoP6ffdIVPf0Y5dbBdKScm+2IbSvDmzcY4ho=; b=Oc9mwYfsnVukG7+3CV5TfQzDpzLtGLMV4ZLaJp0MwGo3+fwXuC6NsGxwyGwFYLDMSZh+zmpDXkanf4NYQiGGmDMOA/BUhhZnYYWlXTPMGR0zthp5fgFT/khHKiR0z7+wCu/S3hWAeiHMgflx+DFsLxRLwzsjFKVlU6JEKXS5d95QeNT94Z4wxCUtwb1U1JZpnqG7Cr0FaXGldDEN5qFZpZSk8isTkBgeBrGpBdeTTncFOOVCJpp/fk77AqCPNVQguWnZg/iUYdJ9wojxCtnVcQuUJ0F7KiMTTOayoZT/Ks2ancFDLUMcreeqZILHlO/AkpP1FCTpSPJAGlOBDlJ+tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjA7qr/aoP6ffdIVPf0Y5dbBdKScm+2IbSvDmzcY4ho=; b=ic3lRZEJR1WnCmBCM2+Yk72p9MSf/fqzAjd1pDnqNLN7rW6ewcakSH8O9BDKhYff2h9Q1yJXpJZzTV6g/bfksDey8zVeTExitHb+W8CY4f6RBfo4kf74Z3b2whphB5xQa+RG3nyrdFfDQEHfdjlfb77He4vYd01iftkxrLlKsOo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB5729.eurprd08.prod.outlook.com (2603:10a6:20b:1de::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 15:10:54 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e05e:c012:f1f9:eb51]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e05e:c012:f1f9:eb51%4]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 15:10:54 +0000 Message-ID: <784a29ba-62ff-4518-9eca-ec20710a7581@arm.com> Date: Mon, 18 Dec 2023 15:10:48 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Fix "attach" infinite loop Content-Language: en-US To: Tom Tromey Cc: Tom Tromey via Gdb-patches References: <20231003-attach-bug-v1-0-f5de2e583c5d@adacore.com> <87wmtxbz1n.fsf@tromey.com> <87plzkjvpf.fsf@tromey.com> <875y0z6z1j.fsf@tromey.com> <4f321ae7-f625-499d-9061-30c8d779c5d5@arm.com> <4645db1f-0101-4880-acf7-7fea744889fe@arm.com> <87msu74m7z.fsf@tromey.com> From: Luis Machado In-Reply-To: <87msu74m7z.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0280.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37a::17) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM8PR08MB5729:EE_|AMS1EPF0000004A:EE_|AS8PR08MB6424:EE_ X-MS-Office365-Filtering-Correlation-Id: be06604b-165b-4f7a-a448-08dbffdb8d71 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tFsbTQ1skKhk39zhzGvuSpjq5dvNily32HEiCypzoTS59vLegfUlNlQgECCT8bO7sAiWAHS//gDHufQ/hWdqV6qCYWWgBixOXFSyHUu1yjgaa3DVv+RsreQmN4G+eJ0dwLO9jZRSjUoDDqYL9EsAyCx293WwqyxSjF/SBBcj8TWxWwuNVmGJ64wmCg9af3oxaUuxb4LntiFePrMp0MYtSRX99S6CkU757k/UyroDU7rOf3bssUqYNbLBGSdFr+poxDV73D6e8fGNeF71cBJ8x+M+0A1quh46pp33EdyipwpDg2olsMRycveQwpGBengF3aWl9P54JDcj+6BKsgOvqqMIAEEFugGCFrhmmEAVIF9BKdAhpBtXrdHUkcr27HuIIjCEJS6bWorUXRlg/PJ7pFkLYTY/AMwM8nFW8KxBLA+Lsz4quAZJlWeRzuz0cFZHGPdWlYMqotbB7Pi6iLDwFp+Iewmpx/lS7S+Vllp89TD7df0QwgFN54GxpCp174HwWGMVZ3td0r3YW3NcdS7/hS/FfJOVMIWtrV5VfDZPYJK0KCFH1pBouFdjQPFJITYHqeOPmyx7ppQ4hpyGDZFeysIYXx5ciX5QldA1ki57dw6F7Jh6r66f994xl5voeSylNy4B3qdflRrcUy8eeXwU6CEj+n64CgYh2DbdW4RWaZJMvus2g/QU4oiX5l4cUogG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(346002)(136003)(376002)(39860400002)(230922051799003)(230273577357003)(230173577357003)(1800799012)(451199024)(186009)(64100799003)(2616005)(26005)(6512007)(53546011)(6506007)(83380400001)(5660300002)(44832011)(2906002)(41300700001)(6666004)(478600001)(6486002)(8676002)(8936002)(66946007)(66556008)(6916009)(66476007)(316002)(4326008)(31696002)(86362001)(38100700002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5729 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004A.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 985ec3b9-326a-417f-0a5e-08dbffdb861d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BOlJxrVnSN/ZAOG8vzS4uXhtlfZROxLcaXEz028imgWsKmt5/x75C2HxrYAbdTNYe2Amgm8K6dwT07kTdX1Vmurkk6tJgR92dDqZmG96pmFv3zG+beEbAxm4EDekvJ46vEmh676W1/KD8RZOUl26WXJhXuO43ildHUz1OOH8W5VGX2kK2Hkck8jUEisGf8UfyXW7tL+7UVtoaIqfNBifEB4+kuvbXal6qgaVvVPbVz2f9QDd/ItlVCjk8/ymRcPdsP5TauuaYwo7DJQ/NTK5qFH9CkIcxqCYW1usUsEX5ef6DQ6ZWXnZw03AjdZnVEGcHJZtTK+EJ5HrNQPxJo/mAh5YETdrikAefYr0dmTcP+pJg05/FtB5NMQMzyrk+lE5wTYQzKJc3KdVzk3i5IQXQzvFlWe1gVlLGcp3MMBnlR4zy/+35qbjMXARKX+mirn7whnz4L9sLAwRoQoSs2XB+oLazfjMNXDFgpkRkCYf8AMZxx1VBMoBCj2cIcMgeG70EdqD+Svppgvm+drnpZc8DSeCa6tVnTzbim4h9Eh2i7I30rYCvMIudO96raktYn6q2dxOhcidyYbklPCu//+W1Lui1vah5j5qIFFvEvJFmq9CPCVReEqz5f6OwKNy79yFLqH/MDlmwhLM8MNzWYbLZyXLc7fnPOTBF/b2T9/FPzsm5zAnSv7ZfMt5v6BhEtTNQnwQ1Wv1hkC51itKEfZgpMM3Nm74BYC9oMC67gJvrSrG1owYpqxaLNRtj1OwqAF3zIkQ26HC0Mcmha2hz4ZwsqWuYZ5rxFZk8TYPZ4hNP90CbXF6FDhKAODi0K05gewO X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(346002)(136003)(376002)(396003)(39860400002)(230922051799003)(230273577357003)(230173577357003)(186009)(64100799003)(82310400011)(451199024)(1800799012)(36840700001)(40470700004)(46966006)(40480700001)(31686004)(40460700003)(6862004)(86362001)(70586007)(31696002)(356005)(81166007)(82740400003)(36756003)(36860700001)(47076005)(83380400001)(336012)(53546011)(26005)(2616005)(478600001)(6486002)(70206006)(2906002)(6666004)(6512007)(6506007)(8936002)(8676002)(316002)(44832011)(5660300002)(41300700001)(4326008)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 15:11:03.8544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be06604b-165b-4f7a-a448-08dbffdb8d71 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6424 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/18/23 14:30, Tom Tromey wrote: > Luis> Attaching to program: /binutils-gdb-arm64-focal/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads, process 1545611 > Luis> Cannot attach to lwp 1609323: Operation not permitted (1) > > Luis> Are we missing XFAIL-ing the test when we see the ptrace attach failure? > > I see this in the test case: > > -re "warning: Cannot attach to lwp $decimal: Operation not permitted" { > # On Linux, PTRACE_ATTACH sometimes fails with > # EPERM, even though /proc/PID/status indicates > # the thread is running. > set eperm 1 > exp_continue > } > > However, this changed from a warning to an error. Ah, I failed to spot that. > > Could you try removing the 'warning: ' text and see if that helps? It > seems like it should issue an xfail instead. I played with it for a bit, and it seems the testcase is somewhat broken. It seems to assume everything is OK if it sees the message "Attaching to program: .*", which explains the PASS we get from the above test. If we ever see the EPERM error, we will set the eperm variable, but it will not matter, because the matching for the attachment message will gobble things all the way to the gdb prompt, and will issue a PASS, resuming the test (assuming there are live threads) and failing. I think the testcase needs a bit of a rework to bail out if we fail to attach to the process. I'll give it a go since it reproduces easily for me.