From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 5F8383858D32;
 Mon, 19 Sep 2022 10:54:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F8383858D32
Received: from [192.168.43.48] (unknown [204.48.95.62])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id C50DE1E0D5;
 Mon, 19 Sep 2022 06:54:37 -0400 (EDT)
Message-ID: <78681d27-e5bd-c983-b521-e46af546537e@simark.ca>
Date: Mon, 19 Sep 2022 06:54:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] binutils, gdb: support zstd compressed debug sections
To: Fangrui Song <maskray@google.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
References: <20220919040115.31326-1-maskray@google.com>
 <15fe4352-79e1-acd5-5a71-fc40e19047a8@simark.ca>
 <20220919085126.5m2keelsz3hzx7xf@google.com>
Content-Language: fr
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20220919085126.5m2keelsz3hzx7xf@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2022 10:54:41 -0000

> I am unfamilir with autotools, but I agree that pkg-config is better.  Changed to PKG_CHECK_MODULES
> and pushed the change to
> https://gitlab.com/MaskRay/binutils-gdb/-/commits/zstd

Thanks, I'll take a proper look when you post a v2.

> However, now `make all-gdb` fails to link because gdb/Makefile does not have `ZSTD_LIBS = -lzstd` ...

For GDB, you can copy what we do for debuginfod in gdb/Makefile.in,
which would mean:

ZSTD_CFLAGS = @ZSTD_CFLAGS@
ZSTD_LIBS = @ZSTD_LIBS@

And use $(ZSTD_CFLAGS) and $(ZSTD_LIBS) where appropriate.

Simon