From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 3/3] gdb: New maintenance command to print XML target description
Date: Tue, 23 Jun 2020 14:48:45 +0100 [thread overview]
Message-ID: <78756a60-786f-a782-c43f-02a9f8bde1ec@redhat.com> (raw)
In-Reply-To: <48ba8273e6994fe630074eb3a34b2d31ae610714.1591917513.git.andrew.burgess@embecosm.com>
On 6/12/20 12:22 AM, Andrew Burgess wrote:
> I think that these changes should be fine, the print_xml_feature class
> is used:
>
> 1. In gdbserver to generate an XML document to send as the target
> description to GDB.
>
> 2. In GDB as part of a self-check function, a target_desc is
> converted to XML then parsed back into a target_desc. We then check
> the before and after target_desc objects are the same.
>
> 3. In the new 'maint print xml-tdesc' command.
>
> In non of these use cases adding the extra white space should be fine.
s/non/none ? But it doesn't seem like the sentence would make sense then.
Did you mean
"In all of these use cases",
or
".... white space should be a problem?"
instead?
LGTM otherwise.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-06-23 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 23:22 [PATCHv2 0/3] Additional maintenance command for dumping target descriptions Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 1/3] gdb: Allow target description to be dumped even when it is remote Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 2/3] gdb: Print compatible information within print_xml_feature Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 3/3] gdb: New maintenance command to print XML target description Andrew Burgess
2020-06-23 13:48 ` Pedro Alves [this message]
2020-06-22 18:13 ` [PATCHv2 0/3] Additional maintenance command for dumping target descriptions Andrew Burgess
2020-06-23 13:58 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78756a60-786f-a782-c43f-02a9f8bde1ec@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).