From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 6F635383E82B for ; Tue, 23 Jun 2020 13:48:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F635383E82B Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-cwSP18PNOLGI0OJ2y7OgJw-1; Tue, 23 Jun 2020 09:48:48 -0400 X-MC-Unique: cwSP18PNOLGI0OJ2y7OgJw-1 Received: by mail-wm1-f72.google.com with SMTP id s134so4500790wme.6 for ; Tue, 23 Jun 2020 06:48:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K0CnfnBCLbyTyZjfHSzauNx8g4PVZhP2G5HJv0TpnGw=; b=khO8KI3obGBlBfkhH5UYQ6F578y9TgsLebLp97hPThbNs/jQUgqJBOAHQKRXd2yI92 KDIVJi7+nRXBkgIF0mG25HgGYGGcLVgKU48JCML6x+2/1xK440QDEUMzKIu4tQv5JsAV CtIU6Hg7kuPI/A+7zVky+4J8nYg4eU3wn8w/oEh9AJy26ETW/EPEWPzb/1PlEPcOpuKk iSRNOMA7UfLwcC29qwljHsiGcoNfRwt9jun46smfWr53KI4vz1QdM5iTPEi3yNejJZnl Cfs6tWftRZh4Cq6cvnuDvHdYB0uf2GF5gvh8O93gxmQqpbqBLbhec6zk9HeaIxLpH28R NNHA== X-Gm-Message-State: AOAM533Xv/U871LKaFKfpg4RtWwdxYg77F4su8N0+ytiV12PxLTWpTdV SMQuA37Sz8YaW/sJ8nr7a+3j4MKbKl614wGsMFWqE5kCANcN8B8FLiPQN3DeO0nLDm3YgHLws1B eyGejs9v0gHRe5hsvUYbIrA== X-Received: by 2002:a1c:b409:: with SMTP id d9mr6215961wmf.99.1592920126791; Tue, 23 Jun 2020 06:48:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2z2eGuJU9ZGnXxYj0pxFQz34N6UJVQ9X4W6llt1u/hkmwPZ53aplD8zOJwS2AIxSQ5L4YmQ== X-Received: by 2002:a1c:b409:: with SMTP id d9mr6215947wmf.99.1592920126590; Tue, 23 Jun 2020 06:48:46 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id y17sm23558116wrd.58.2020.06.23.06.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 06:48:45 -0700 (PDT) Subject: Re: [PATCHv2 3/3] gdb: New maintenance command to print XML target description To: Andrew Burgess , gdb-patches@sourceware.org References: <48ba8273e6994fe630074eb3a34b2d31ae610714.1591917513.git.andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: <78756a60-786f-a782-c43f-02a9f8bde1ec@redhat.com> Date: Tue, 23 Jun 2020 14:48:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <48ba8273e6994fe630074eb3a34b2d31ae610714.1591917513.git.andrew.burgess@embecosm.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 13:48:53 -0000 On 6/12/20 12:22 AM, Andrew Burgess wrote: > I think that these changes should be fine, the print_xml_feature class > is used: > > 1. In gdbserver to generate an XML document to send as the target > description to GDB. > > 2. In GDB as part of a self-check function, a target_desc is > converted to XML then parsed back into a target_desc. We then check > the before and after target_desc objects are the same. > > 3. In the new 'maint print xml-tdesc' command. > > In non of these use cases adding the extra white space should be fine. s/non/none ? But it doesn't seem like the sentence would make sense then. Did you mean "In all of these use cases", or ".... white space should be a problem?" instead? LGTM otherwise. Thanks, Pedro Alves