From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4FA093858CDB for ; Wed, 5 Oct 2022 19:34:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FA093858CDB Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-166-s9WLgMO2N3euHa4gJREJew-1; Wed, 05 Oct 2022 15:34:00 -0400 X-MC-Unique: s9WLgMO2N3euHa4gJREJew-1 Received: by mail-wm1-f69.google.com with SMTP id o18-20020a05600c339200b003bf24961658so1227509wmp.6 for ; Wed, 05 Oct 2022 12:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gpYt2NbYw6DKt29AZ/GJGryGv82oUYjY3G5zBh00UVA=; b=zIaWYxVPI9S4S+SM2A3IGI1sRLC/0+ZrKJGCM/qdS8hwFXEou4J4mucyQpbXTBNwAs 3hpgATIRTHo0hCa4UZ3peKnDHzoynW64vWbdULA6E9+ozH0bHJJuRv1TAIPn2IrIHYiJ Os6el1BnbK9T327qDFkmlMqDGaqDTgXnb3wCLHusbJwiEhL/UUZYso0dcx3ljGMdHXPt hqu8W1G/XPyO4XuFC/oWxU364NI37fbMhGTt5bHRPzZ9+WpcPN5mdkIFtDdBFC3rDJ2B brErbKrpoZi/at0W+dVSVyG6CqewAQPw2WBBJ8wFBykBUdnGGifeNHhd4tChIkRl5/cB CPsw== X-Gm-Message-State: ACrzQf36DlL0QQxZVAc9LuW27Ad1B2YUlwGOvL3NqIpIphgkkIkeKFX6 1NVfW0O46E4MKN5Q+ch4kV6gHrcg3kuAi/P21NpzNsnI0zUv+wEbbtYLp/PRkPFjQXg6WfzIkQf ZtJT2dYW6qnplF1+PZ6AEagv3v4e05972XUpndEDR9/uXXdMytGfkV/TMkQu1duCRCeftiEgrQg == X-Received: by 2002:a5d:648b:0:b0:22a:d169:6fba with SMTP id o11-20020a5d648b000000b0022ad1696fbamr729793wri.447.1664998437423; Wed, 05 Oct 2022 12:33:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5grGPillJfKRXTNeAHllclK3a4PnfRys4/arvZEHLrMPzW5LW834baktvOp+7h61PvhqCK+A== X-Received: by 2002:a5d:648b:0:b0:22a:d169:6fba with SMTP id o11-20020a5d648b000000b0022ad1696fbamr729779wri.447.1664998437135; Wed, 05 Oct 2022 12:33:57 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id k2-20020a7bc402000000b003b31c560a0csm2852068wmi.12.2022.10.05.12.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 12:33:56 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 1/2] gdb: remove filename arg from gdb_bfd_open_from_target_memory Date: Wed, 5 Oct 2022 20:33:52 +0100 Message-Id: <789cee1fccf9da67728a7342d1bbe6caa07f1185.1664998256.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2022 19:34:05 -0000 The filename argument to gdb_bfd_open_from_target_memory was never used; this argument had a default value of nullptr, and the only call to this function, in jit.c, relied on the default value. In the next commit I'm going to make some changes to the gdb_bfd_open_from_target_memory function, and, though I could take account of a filename parameter, it seems pointless to maintain an unused argument. This commit removes the filename argument. There should be no user visible changes after this commit. --- gdb/gdb_bfd.c | 5 ++--- gdb/gdb_bfd.h | 7 ++++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c index 7e743891aed..36ef5e1cc5a 100644 --- a/gdb/gdb_bfd.c +++ b/gdb/gdb_bfd.c @@ -288,14 +288,13 @@ mem_bfd_iovec_stat (struct bfd *abfd, void *stream, struct stat *sb) gdb_bfd_ref_ptr gdb_bfd_open_from_target_memory (CORE_ADDR addr, ULONGEST size, - const char *target, - const char *filename) + const char *target) { struct target_buffer *buffer = XNEW (struct target_buffer); buffer->base = addr; buffer->size = size; - return gdb_bfd_openr_iovec (filename ? filename : "", target, + return gdb_bfd_openr_iovec ("", target, mem_bfd_iovec_open, buffer, mem_bfd_iovec_pread, diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h index 86f7be85f20..6ea16ddc735 100644 --- a/gdb/gdb_bfd.h +++ b/gdb/gdb_bfd.h @@ -201,11 +201,12 @@ int gdb_bfd_requires_relocations (bfd *abfd); bool gdb_bfd_get_full_section_contents (bfd *abfd, asection *section, gdb::byte_vector *contents); -/* Create and initialize a BFD handle from a target in-memory range. */ +/* Create and initialize a BFD handle from a target in-memory range. The + BFD starts at ADDR and is SIZE bytes long. TARGET is the BFD target + name as used in bfd_find_target. */ gdb_bfd_ref_ptr gdb_bfd_open_from_target_memory (CORE_ADDR addr, ULONGEST size, - const char *target, - const char *filename = nullptr); + const char *target); /* Range adapter for a BFD's sections. -- 2.25.4