From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] Support 'info proc files' on live FreeBSD processes.
Date: Mon, 10 Sep 2018 18:30:00 -0000 [thread overview]
Message-ID: <78a76b21-779f-b44d-29ec-5494b1a5476d@FreeBSD.org> (raw)
In-Reply-To: <5889a8bc-3941-677c-ff54-135b1bb9f2d6@ericsson.com>
On 9/8/18 4:00 PM, Simon Marchi wrote:
> On 2018-09-08 01:36 AM, John Baldwin wrote:
>> This walks the list of struct kinfo_file objects returned by a call to
>> kinfo_getfile outputting a description of each open file descriptor.
>
> LGTM.
>
> It would be nice to share the printing of the information between core
> and live process, so that we can't forget to change one if we change the
> other. But if there are some subtle differences between both loops that
> would make sharing more annoying than anything, I don't mind.
I've followed the same approach I used for 'info proc mappings' which is
to use shared helper routines as much as possible.
What I could perhaps do to share code is add new TARGET_FREEBSD_<foo>
target objects, but this would entail reworking the code quite a bit I
think. It would mean that I would need a way to let a gdbarch hook into
the core target's xfer_partial method more generically (right now there is
a hook just for siginfo, but I think we'd want a hook for arbitrary
objects). I would then rewrite the info proc bits in fbsd-tdep.c in terms
of fetching target objects and always parsing them in the core dump
format. I think there were a few things in some of the other 'info proc'
methods that weren't quite as straightforward as for the 'files' and
'mappings' case though.
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2018-09-10 18:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 0:38 [PATCH 0/5] Add a new 'info proc files' command John Baldwin
2018-09-08 0:38 ` [PATCH 1/5] Use KF_PATH to verify the size of a struct kinfo_file John Baldwin
2018-09-08 22:25 ` Simon Marchi
2018-09-08 0:38 ` [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps John Baldwin
2018-09-08 22:54 ` Simon Marchi
2018-09-10 19:37 ` John Baldwin
2018-09-13 15:08 ` Tom Tromey
2018-09-13 18:42 ` John Baldwin
2018-09-08 0:38 ` [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc' John Baldwin
2018-09-08 6:49 ` Eli Zaretskii
2018-09-08 22:31 ` Simon Marchi
2018-09-09 5:23 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:11 ` Eli Zaretskii
2018-09-08 22:32 ` Simon Marchi
2018-09-08 0:46 ` [PATCH 5/5] Document the 'info proc files' command John Baldwin
2018-09-08 7:01 ` Eli Zaretskii
2018-09-10 18:43 ` John Baldwin
2018-09-10 19:13 ` Eli Zaretskii
2018-09-10 18:52 ` John Baldwin
2018-09-08 0:46 ` [PATCH 4/5] Support 'info proc files' on live FreeBSD processes John Baldwin
2018-09-08 23:01 ` Simon Marchi
2018-09-10 18:30 ` John Baldwin [this message]
2018-09-10 19:03 ` Simon Marchi
2018-09-12 22:38 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a76b21-779f-b44d-29ec-5494b1a5476d@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).