From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id C81BB3858C56 for ; Tue, 27 Feb 2024 09:18:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C81BB3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C81BB3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709025516; cv=none; b=eJAqSYmESkWGgplWMIpKtGwLYqfs4nrcMGu26LnjNsdMPDyo/1xoafKscgfpb5cdxX+hhm4n/lwRsMlAmtky7PLwukZoPHPBunnTQNiquKEmmKr5YGq8wPsg5nWUchT9R+n8riLGeeJDQyg8leHqsDdWC6lj4YlfJDXUKsncJH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709025516; c=relaxed/simple; bh=nVYU6YiFHFkLhL9I7f4yjjyuWobn/Bf7mU2kOF69s8A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ITYn4+jOrjHerAlGjEOc8/qSRGAhiCzibvIPNVuDkJUqtOLZZnOecE6cceCyB1R9N1VQZQ4v1wpejZdBSd5hK7mkxkrNNKEWNEwFkjUN9GPP2GnC+F6IS6dx1ME6YSDOLEj+vkRTq9UM22ShJZhejkfyh574LAPFUyQ6bfc4eHM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 025BD1F44B; Tue, 27 Feb 2024 09:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709025512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUKIdqGyd38iiMlwsrN6YzBINmavcbhuMWNwR2y679s=; b=KUDSNqDzN2kljlBCrZP4gtZsQAiSMWklEZmCmU84g7YY3cZKccUgdfwovXsD1vma50uMlY GlTGIm3wxqjN0YJ3VmjLmpAZW63b28G5zGXUzFSlW0ZqD17illh5DruigWQynOjPgjpNjM x5bdshOIdZvC1nor9TqVqpLsmELvYqg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709025512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUKIdqGyd38iiMlwsrN6YzBINmavcbhuMWNwR2y679s=; b=lLt/A/ufRyoqd3gkTnCSNyAtFlwdWzJBIa+HjOrsrqCANl2baH3Tg28q9qa9xe97ZjcV4W AQgE5itRfm7PraCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709025511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUKIdqGyd38iiMlwsrN6YzBINmavcbhuMWNwR2y679s=; b=RY0IkOe0J4Ng9IiQzJ5o4seVIML9hANFx1ylPyqzjppVbfLJo9hobumlyqq9Y9Kr0YTiXW dE4r91frtf4zYOR2TM76mvW6J3hJLc7MEnX9A7pT7b69DKfMSPGEpaTk+zIu0bFo5VqGir kkAl52xq4iuAirjdSzObtM9+XVlW9SI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709025511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUKIdqGyd38iiMlwsrN6YzBINmavcbhuMWNwR2y679s=; b=+6s1W9uvtmZEv3NLMjjJwtMZEjPEjA8A99P7ehPY1VSxl5LZhP/K6Fs3KIZG0LlXaIpzMr 8y3qASmm68dKT2Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DF57613A58; Tue, 27 Feb 2024 09:18:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CxUgNeao3WXSbwAAD6G6ig (envelope-from ); Tue, 27 Feb 2024 09:18:30 +0000 Message-ID: <78d0a939-d8c4-4de0-b722-120f7c4bad0d@suse.de> Date: Tue, 27 Feb 2024 10:18:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] kfail a FinishBreakpoint test Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240220-py-simple-exc-v3-0-a2825caa4b74@adacore.com> <20240220-py-simple-exc-v3-3-a2825caa4b74@adacore.com> From: Tom de Vries In-Reply-To: <20240220-py-simple-exc-v3-3-a2825caa4b74@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RY0IkOe0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+6s1W9uv X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-7.05 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.05)[95.32%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_HI(-3.50)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,sourceware.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -7.05 X-Rspamd-Queue-Id: 025BD1F44B X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 20:46, Tom Tromey wrote: > I noticed that one particular FinishBreakpoint test is only passing by > accident -- the regexp is too broad and matches an error message. > > This patch changes the test to actually check what it claims to check; > and then kfails the test because it doesn't work. I've taken this > approach because this failure is only incidental to this series. > Meanwhile I've filed a bug that I will leave open after this lands. > I don't think there's a problem with gdb, so there's no need for the kfail. I've proposed a patch here ( https://sourceware.org/pipermail/gdb-patches/2024-February/206853.html ) that fixes the test-case. Thanks, - Tom > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391 > --- > gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp > index 45e2630337f..6b72ddb2186 100644 > --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp > +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp > @@ -73,7 +73,11 @@ with_test_prefix "normal conditions" { > "check MyFinishBreakpoint hit" > gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value" > > - gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit" > + # This test does not work and the result being checked for here > + # used to match by accident. See PR python/31391. > + setup_kfail "python/31391" *-*-* > + gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \ > + "check finishBP on default frame has been hit" > gdb_test "python print (finishbp.is_valid())" "False.*"\ > "ensure that finish bp is invalid afer normal hit" > >