From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 22B733858D3C for ; Sat, 20 Nov 2021 04:26:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22B733858D3C Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C1FFE3ADC07; Fri, 19 Nov 2021 23:26:25 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YqoTyZaYPR43; Fri, 19 Nov 2021 23:26:25 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 4AA073AD8E2; Fri, 19 Nov 2021 23:26:25 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 4AA073AD8E2 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DIO9jaFnEG9o; Fri, 19 Nov 2021 23:26:25 -0500 (EST) Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by mail.efficios.com (Postfix) with ESMTPSA id 2664A3AD8DF; Fri, 19 Nov 2021 23:26:25 -0500 (EST) Message-ID: <79088ac6-2460-843e-85cd-15f437203dbc@efficios.com> Date: Fri, 19 Nov 2021 23:26:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gdbsupport: fix array-view compilation with c++11 && _GLIBCXX_DEBUG Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20211118204145.2425971-1-simon.marchi@efficios.com> <87h7c7any2.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87h7c7any2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Nov 2021 04:26:27 -0000 On 2021-11-19 15:29, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This is because constexpr functions in C++ can only consist of a single > Simon> return statement, so we can't have the gdb_assert in there. Make the > Simon> gdb_assert presence conditional to the __cplusplus version, to enable it > Simon> only for c++14 and later. > > Seems fine to me. Thanks. > > Tom > Thanks, pushed. Simon