From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DAF773858D35 for ; Wed, 1 Feb 2023 16:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAF773858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2FF2A1E112; Wed, 1 Feb 2023 11:21:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675268462; bh=C0gZKFQb3JOhImuHzB35UkgB3ftAbkTWVeQedKa+GSc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tX8Q9jrSS9s10O2SbxIEBqzjlXSIMZvwRJA5HX94jyK33GkBUzslzCA8SwQn9AX7A qSEqWnsYmNVhRqAEu9fHpb6satgWTChWk9if26Ta1tAfVkxMbtp7lhnT9YyvZD5QcC BCLJKGTsD8DwBc3oMLFNMqinS/dmLJgq47BHiDzo= Message-ID: <7970ac03-1123-d5f6-7b17-808832d43be6@simark.ca> Date: Wed, 1 Feb 2023 11:21:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 4/8] gdbserver/linux-aarch64: When thread stops, update its target description Content-Language: en-US To: Andrew Burgess , Thiago Jung Bauermann via Gdb-patches Cc: Thiago Jung Bauermann , Luis Machado References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-5-thiago.bauermann@linaro.org> <87pmattzjw.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87pmattzjw.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> diff --git a/gdbserver/linux-low.h b/gdbserver/linux-low.h >> index 221de85aa2ee..b52eb23cc444 100644 >> --- a/gdbserver/linux-low.h >> +++ b/gdbserver/linux-low.h >> @@ -604,6 +604,12 @@ class linux_process_target : public process_stratum_target >> /* Architecture-specific setup for the current thread. */ >> virtual void low_arch_setup () = 0; >> >> + /* Allows arch-specific code to set the thread's target description when the >> + inferior stops. Returns nullptr if no thread-specific target description >> + is necessary. */ >> + virtual const struct target_desc * >> + get_thread_tdesc (const thread_info *thread); > > I think the comment for this function is not correct. The function does > not SET the thread's target description, but just GETS a target > description suitable for `thread`. It's the caller's job to do the > setting. This comment also gave me pause. How does a getter set something. I then understood that it allowed the arch-specific code to provide a thread-specific tdesc. I would suggest just: /* Return a target description for THREAD. Return nullptr if no thread-specific description is necessary. */ The other thought I had while re-reading the patch is why do we need to return and store nullptr if the thread target description is the same as the main one for the process. get_thread_tdesc could just return process_info->tdesc if we don't need a separate tdesc, and we would store that same pointer in thread_info->tdesc. And get_thread_tdesc would just return that (in fact, get_thread_tdesc might not be necessary then). Perhaps it makes some things more complicated down the road, but I can't think of anything. Simon