From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 978EE3858D1E for ; Thu, 13 Jul 2023 17:41:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 978EE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689270118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UYcxWBAmLKeblg4PrCJfEt7ig+paCIh1DXQjqIMxULQ=; b=WizPGVHJ4h3pFbgPR/sVCklzdUyLMIUT/Jh4vpt9iGZQ1x8+g3IUN010zmCnMlkP5f99kL BNlfB55QoqS//1FobCJTOYkAekG875OhKtG4CeS81/xPngggK6Fiac6dj1NqJyzhjMxtTb pf5VAIyi3pxfrKesUEK9qEmge3NzUac= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-540-HH5lkkgCMQOG84z2FPio_w-1; Thu, 13 Jul 2023 13:41:57 -0400 X-MC-Unique: HH5lkkgCMQOG84z2FPio_w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3862B8D168C for ; Thu, 13 Jul 2023 17:41:57 +0000 (UTC) Received: from [10.22.32.34] (unknown [10.22.32.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF37440C2063; Thu, 13 Jul 2023 17:41:56 +0000 (UTC) Message-ID: <797554d4-2054-b8fa-9cae-5d2e964b3110@redhat.com> Date: Thu, 13 Jul 2023 10:41:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 3/4] gdb/cli: Improve UX when using list with no args To: Bruno Larsen References: <20230713102411.2279542-1-blarsen@redhat.com> <20230713102411.2279542-4-blarsen@redhat.com> Cc: gdb-patches@sourceware.org From: Keith Seitz In-Reply-To: <20230713102411.2279542-4-blarsen@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Just wanted to point out some trivial typos: On 7/13/23 03:24, Bruno Larsen via Gdb-patches wrote: > When using "list" with no arguments, GDB will first print the lines > around where the inferior is stopped, then print the next N lines until > reaching the end of file, at which point it wanrs the user "Line X out ^^^^^ "warns" > of range, file Y only has X-1 lines.". This is usually desireable, but "desirable" ^^^^^^^^^^ > if the user can no longer see the original line, they may have forgotten > the current line or that a list command was used at all, making GDB's > error message look cryptic. It was reported in bugzilla as PR cli/30497. > > This commit improves the user experince by changing the behavior of ^^^^^^^^^ "experience" > "list" slightly when a user passes no arguments. It now prints that the > end of the file has been reached and recommends that the user use the > command "list ." instead. Apologies for the nitpicking after the patch has been approved. Keith