From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2065.outbound.protection.outlook.com [40.107.115.65]) by sourceware.org (Postfix) with ESMTPS id CA73B3858407 for ; Wed, 21 Sep 2022 15:38:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA73B3858407 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3CWLGZHA25Px1w3uib+7NX3nxemjjdlSbTxqQxzXPX/YLmfL3WBwOEqJkj8j0pHNptZ8r4imQxZtezbe71n8HqDUCA6R+ahWZPaDlBKCNhBIAmesUdYkBypGuGgIhO9I77EjZK4nNK4/i/oKll1e48BygvQW1XLvNT/hJUv6CzZd7vbsu3oOixKNAv69hduCQxBNi+z6Oh/TTE59N74V7MMrBzLrlzd6RayLa3jUMSsnno9hObsU6M45eG4f+WzAQzfkoLlJp1w08tQdHw+D/E9dEtNj7UNs+CURIejShmrk9l8kzrEC+5yb2+hXa1rTHbYwtHhHujI/4zP33vPeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5pPbsRJNxI3eXz1yic0Rg/iT4g9VqG1hoGEMicHjQio=; b=PnrU7gfaTNRcImt9zU2VrYAU8FCDtOZOxvY+OzHJYfcUx02xRNownMkr1/UH+Fq89Du/af+8ZODsS91v2fdcKHtgI8ehvldUnz3V4Xb7nxRhIYmvb4H0rQO3tFW68UdYXQMd0e3r9JWnRCu2X6FZkaVBDZqc6y/Xiv0NTv/svSqe3YWxc0+ddB7dxNvE4CFWwcsOyAH8yx2fvrITMLmlkokdjXY+pTIgesB5sN8xwf0qZfJT+8n8KIkNj/l5DxXoymosKtvu4qkSNVGHjR/42/h6ZHthQIR2MW09nM0NKlc2M3fDHLcqaRwEv1I7p8paFfciSo2D0SyFV6+QsZsH2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB6324.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:39::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 15:38:03 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::3d6b:f9bb:9d0c:d744]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::3d6b:f9bb:9d0c:d744%4]) with mapi id 15.20.5654.017; Wed, 21 Sep 2022 15:38:03 +0000 Message-ID: <798e60b7-de41-b394-05cf-d5c79d7e22d6@efficios.com> Date: Wed, 21 Sep 2022 11:38:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdbsupport: change path_join parameter to std::vector Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20220719142741.3307396-1-simon.marchi@polymtl.ca> <877d1w4udl.fsf@tromey.com> From: Simon Marchi In-Reply-To: <877d1w4udl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR08CA0008.namprd08.prod.outlook.com (2603:10b6:208:239::13) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB6324:EE_ X-MS-Office365-Filtering-Correlation-Id: b1031890-2a4d-491b-87b4-08da9be74570 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zkvzF9prE/10lpF/s3r4yu6S8ARllwC+AaeJi4VOE6TN5FBIiJ6SOUiCjXH4+MDfm/pXjSlLEkTfTCnrXsJw3r+PguY6UfuW0Kf0i3Vl66ZpXBxPxb/9GH/Bdpo6i9UsqTaK78JikJZzik+l4Pmpe/bkLRABuRa0E+8BrUpxtaYG0bX2ehrHyFTv6roWZHu7TXxapeDiNtNGDiD12KwQchDEVl63HBDum/5flHHKtWBxOb6LrSJVAANHWALg3akmQe5HJ8BaII0L/d/ut9GND/rzRrhw6CuCst2c/ftaah7+oVp3o5bJwMRprYTGh+e3leYRJ3L7iSlVgcsRtXNkj8b33fHwBU2kUO0SuzXMMEoWFI8Neob+T+UF6DC4rUaByZQb1Rx7sXm1vYBWvGiTslhgVmFKMPL0ga/xPDz+OPpuRQGGtu9/aS4FCIW7grLZecSeveZS4BVaRcFW0+8XjM8DB2HGq4yqbmCfaLglSCN67v5l3LESsRXUszyT1Tn9XzZacojyCtnlTrh5LLOGx8WTlG/jYymCC7YZRJVqNHJSxckSHl9SuUdWb8Fhxg4BFqlUxKUY2joaadJOlVAZntpXE09uL/SYOkERA4U9W+L2INkgfFnI2LzXJMBhKNQGJ3LtnHpE/2Udo3M5JFImAgrPfM12BJKLHIf3scO9ZRCVXIRPGdVId/nJ9894bbdHG8Bd7aoVzsMP1fRb58Csyx4WbnTgFFSRWxT4bbBIgU80Bn4dQs3HWBZQqASoq4BbspuIAe1gioTDc/NzjGvs35GZw725S5hf1McsGwZMJts= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(376002)(366004)(34036004)(346002)(39830400003)(136003)(396003)(34096005)(451199015)(83380400001)(4326008)(8676002)(44832011)(36756003)(66476007)(66556008)(66946007)(2906002)(31696002)(586005)(38100700002)(41320700001)(498600001)(6486002)(38610400001)(31686004)(53546011)(6512007)(26005)(186003)(2616005)(5660300002)(110136005)(41300700001)(8936002)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG1lRHFLbGZ1K2E3RGNOR05lVkgzYks1TDh1dlEwL3VuZ2ZCdTFjMXU2cnl5?= =?utf-8?B?RmhGMTV0ei81aEd3WGJCWCtGUnFLOG13cXBpcnpXbnBSRDRDL3pmUXQxUEVl?= =?utf-8?B?cXBNRXcrR2NZRmVQd1NWVmx0THN2TzRockl3TVFoYWdQVXlKWWc5NzJRSnUr?= =?utf-8?B?OFkzb0wwUEM2NDF1NTN6TEpIQ0RocUxud3g3ZjhOUnRENmdoWUtWNDlkYnVy?= =?utf-8?B?bUloRzErUWRid2J3M04raUREK1Uza3MyYlBGR1FGTkdsTXF2eWVDUUNCUTB2?= =?utf-8?B?c1VJWVpCUmpGeVNiQ0gzbnMySDV2eXJzTWF5QVdMa3RMY2FWYkJMQk1BSDZY?= =?utf-8?B?LzhhUWdoVkE5MVlUZEpTWmc5VENCN0UvOUdwa1lvYU1BVVAvbG1pRnh6dXlZ?= =?utf-8?B?THhpbDZXTHNmUDd6aEUxMkp5UmZhdk1YTDJPM3dINm15TzBHVGpFNUxOWWZF?= =?utf-8?B?aVhHNmlxVDZrN1pKZ21xOCtENWFubEc4TzRnZmJONThrQi8rWHZqMFdhNk9U?= =?utf-8?B?blRFbGFlK1dPUFpiVGt0VEVuOTRSb1ZWeHRUZmFrSE1FZWJXNFR1U2Fsc09F?= =?utf-8?B?RzgzUElDSjhseDFqY2llMS9ZNEVLRnc0NnRnSTc2d0dtYkRTQ3BzTU9tL092?= =?utf-8?B?WmxQcmZnbjNsMlFiZXVWWjlsMUNSaHlWVTFRRlFCU0VhaVVnSS9aTWFRaklO?= =?utf-8?B?YytJeXZONGxiWklRRDNxT0pGaXFabE5KVWcrSks5ZmtlblpOUkVyZnhtLzcy?= =?utf-8?B?bHFoRTM3QjNRWWtQMExCbUlqQjIrOG1XNi9IelNvLy8xUktXK0RYeDkrSFVQ?= =?utf-8?B?dzl3YVJOdHUyczE2ekpBbnJ3dCtkaFBuVDlDQUZIdFFNQUxRV0hocEliOXRl?= =?utf-8?B?bGViT0xjTXRuUHdXY0VZSGJZSGExQ1c5eCtkbWE2dnRFdFJIR0hyRzJJYkRE?= =?utf-8?B?T3BEREwvVVFIQzJYNCt0ejVTVW5EVmxlVEs3dHhNajBpRE15dTd6MUNkVWpG?= =?utf-8?B?TUR0TDJDSHhWVmI1Q3dHM04wMEI0WDJLQzBKWDdaYnFORWFmMEU5eWxqZHdy?= =?utf-8?B?ZXNJUHNJQkJyZUlTZzRhdytXckFQdlpyTGZlcmxtTFUzb1JrK0tPdFZGdmNB?= =?utf-8?B?L05wQStpQ1U2bEl3RnptNm51Z2EycFlwU0tReUJ1YStkcFQzKzFMOWxwL3FZ?= =?utf-8?B?ZDVBMEZpaTgxN0RxTVVIWnRkR05ocXBTY0YrQm54WEhGeFBmZ1BGM24xenUx?= =?utf-8?B?U2dXUURUNXczS0cyUkRueUdXQVhkTW4vMGx0QnI0cUZmelIxY2hkSGNYZGlG?= =?utf-8?B?SDJmL3VpbldRVTcvcnY3NGFjMG9tTVg2S2tHWjVjUU5HdlgyR21kcHh4Tlc0?= =?utf-8?B?SzVKTjh3Q2dEYnUzM0c2dWZQMjdObWErZFBKSzJxRE91S2hKVWt2MmZxVVBZ?= =?utf-8?B?ajdDdUh1SDJZblVaNU12aFNsUDZWN1dVZzBnaGZaUkRrN2I0d1BFcjFDSnB3?= =?utf-8?B?QXM5VGdGRlRNYnN5Vk53L3ZETmtLS3FSbktMeWpseUs2NGR5dkVNSHpoWFdQ?= =?utf-8?B?NGdHOGkwVGgrSnpIQk9mckRINmMrYmlBTGJOWUhucEhraWdnMHNjQlEycFBG?= =?utf-8?B?WWNvVko5bXZCbHpDWTB1bElDNXo2NlNZbWhtQ2FzL1BZamdTdlFvdUtEU0lI?= =?utf-8?B?L1pqZ2thNTdVMGNNQjRGSUk1bmFuUWtHWHZmYmVHSVJhU1A4NmtCQzVQd1RF?= =?utf-8?B?Z0xDSDdVTnRBUnlVQWs5TUp6aGlIdm5pYUliRlZDcUNtditNZE1ueHNwSmJJ?= =?utf-8?B?VStoa2RaVDQ4ZW94VXdZUjVNR0NiK3hRY1ZuM3V2bW91cFd4TXVzRm44Mk5D?= =?utf-8?B?VDRrdDJIc3g1MTBBdDZad2lDa3JVQXVhZ0xzK2FOc1BuWXFvblFGZmY3SFJw?= =?utf-8?B?NFpFL1RnMUJ6UkRzam1OMy9MYnlEbTVQZlg1d01QTHlkMklDeFkxK2N3ZWJH?= =?utf-8?B?N1Z6RzFkTTdodHJkbkc4WmZUQmFIdjZRMHg1UXhadjNPZGxCSTFWeXkyTEgw?= =?utf-8?B?c0R1ZkhOcGlISkJDSEFjdC90OU14bzE0eDZUd3AxQk1tV3piazcrVnpCSndW?= =?utf-8?Q?uR0naIhIkGBuHpST8oDU/VI5X?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1031890-2a4d-491b-87b4-08da9be74570 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 15:38:03.2818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UGWDRatjvaLbuhd97VGQL+10xVj5WAdFVVUkjP2GgLqthekLaaxLhodK/As0zJ+XJgAZNAeeTqXDl9iN7vC/eA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB6324 X-Spam-Status: No, score=-3035.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 15:38:36 -0000 On 2022-09-21 11:31, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> When a GDB built with -D_GLIBCXX_DEBUG=1 reads a binary with a single > Simon> character name, we hit this assertion failure: > [...] > > Simon> This patch makes the easy fix, that is to change the path_join parameter > Simon> from a vector of to a vector of `const char *`. Another solution would > Simon> be to introduce a non-standard gdb::cstring_view class, which would be a > Simon> view over a null-terminated string. With that class, it would be > Simon> correct to access index 1, it would yield the NUL character. If there > Simon> is interest in having this class (it has been mentioned a few times in > Simon> the past) I can do it and use it here. > > I think it's fine to just do this for the time being. > Thank you. I had forgotten about that patch, thanks. I also realized the subject is wrong, it should be array_view instead of vector. Will push with that fixed. Simon