From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2084.outbound.protection.outlook.com [40.107.247.84]) by sourceware.org (Postfix) with ESMTPS id CD63E3858D35 for ; Tue, 16 Apr 2024 16:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD63E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD63E3858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.247.84 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713285077; cv=pass; b=jIXw2osvEoVNe3MCAQnpI7rxzV/cusnHKRqrJjki1aJMW/Umi/udmal44F8LhQ5o/VilVUeYyXPhMT79Qtl08i7Iq7NGQlvqOUAvctN9AKO6Zm6F9UYBM985tzusi4Qak/xdIWPSnB+axny66WZuDNzV7Zm7u7ab1vdPNnN5WfA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713285077; c=relaxed/simple; bh=yVJuWe1unBsiwmMFNNhurlLrCPWEjluuV+2cYkAQET4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=MBDLarl5tni1mBXEQkHIZn1d04S0q0CcQmYcLCM3hpzRPkuJkJXbEKuP5y+1JgTJ90qALCAHy1CzFy4mc8Ek2DCpA1mdkcYeurkj3PkqS9BCQHufwNMeyaPbamrulljov6EtUOA/h6WKMeBp+f+hJmXXtW3VVAgaRns87CTm37M= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RHbKp3qH+EKx46T4+AWYlcG7JPLlCdrL6FTX1sGyyoGKImbTpONVUDqNoBpJcomWBSff4N+mei6xhm0Js3bt5aRS+6wE+/uvLdT3I3uYcKalK75+Mjc+3L/ImR1iGaoqaiBMMjeQuXJ3KeR9vi1xXgBMXzeRJHnRZcfb45fs6CZAXwiASinKgMHXYw1rSW19WISzeWJlUIpd/bu/LKlX9duM8UmfqhZF8U1L1DLS6geuOpnDvPrnBKnyQeJWNEkpSHYMolNvTQcO1n4ulISxyIx7FJZq/rrmbtcrKrwbrYb28Zj2DmRP4ZmuUlJvFLv+UBVHd/SnSwgwLQGhuZPJ6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baYjdNx0sNVdVXispJP4LcPnc2wK4QnNmbzh2KjM86E=; b=N7RP8lfhbEgmMsYAM06XgK9fcUq3e+xpzNqdkaxKAzDtiHD7kGLaKWnCib3NrO+0l88MJBt6YYrJkv1TR3xS4HEK4upKqTUItQ9XQgUbv5aALmQJAZLSYt6ZLpEE0Whmg9q7MZqnLfyUv6e6kko/3tLnISY/Hc7xCIst4E0OGKoyU2oKOpYA+eTM/BpXEaZF/hd1ltsbVNmzFYhgPeFWiryasWly8fG15TVUnOaykZbhd1lC9XRzETUJc8d9z1Jn9e6vJgjr2HlrVm4rCH6nUkutP6ieKoPmPeP21OWDtRC1WoYrt2wMFJbbajEqm0fxWu/V8RQAySVqznqZkR5/Xw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=baYjdNx0sNVdVXispJP4LcPnc2wK4QnNmbzh2KjM86E=; b=b2xoZzYysbcGXAWBt7LrMoPC3yd1TRPOPtUNcK4sWpsPkE1EUvEBFxDcgbfmcgV+1d8sm+vDi/SJ5T1kPPlcZMKyGCtm9OP8DElrYrBC8cPKOdAT8+LovkVdI3HzY8P5dWgfjHrHquRoz0CtgyYLhFPe4xc6jpR/0sZd8OVUXjg= Received: from AM6P192CA0085.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::26) by PR3PR08MB5593.eurprd08.prod.outlook.com (2603:10a6:102:84::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr 2024 16:31:09 +0000 Received: from AM3PEPF00009B9E.eurprd04.prod.outlook.com (2603:10a6:209:8d:cafe::13) by AM6P192CA0085.outlook.office365.com (2603:10a6:209:8d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.34 via Frontend Transport; Tue, 16 Apr 2024 16:31:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF00009B9E.mail.protection.outlook.com (10.167.16.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Tue, 16 Apr 2024 16:31:09 +0000 Received: ("Tessian outbound 93e51b94fd50:v313"); Tue, 16 Apr 2024 16:31:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 81e032648fb057f8 X-CR-MTA-TID: 64aa7808 Received: from 4b00f932a2f9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4956FDAC-B658-4024-8474-54FDBB990631.1; Tue, 16 Apr 2024 16:31:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4b00f932a2f9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 16 Apr 2024 16:31:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=civh1G5N3k/OB6gKaAIwSRwMAsQeSG8arwtEjsC3x1WBr/RRomxeRIu0UFzXVCNniTKDIuVUb0Td9FzkBj9PTlCEMsPSsRsNC3s7sb52Jjwgb2sAw6UMZ3Lj92/cAsjX/BOlJuZhwfaSVrHZO8ykIDOuOPEDbBSLQ6eXAtqwPWF62cCyyF0C+HDtfBUs6rPM9rfexe8kqcdlxUuIgiNGmOQKRRDxIwHGg6UfYhD7rimbSjkR3Apl/j+0De8kE/KSxCEONYsw7yOiT0HOGxzzN2E1Wyxd8wm6LwmWos4QwZPH+g2zsd+3OkLfWq9zKZfO+sgz01505QzjIgXqgqtygw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baYjdNx0sNVdVXispJP4LcPnc2wK4QnNmbzh2KjM86E=; b=FDlP22Meoks+PSycTA3vVGU3R51yvm+oiuSBNJF+6ff1tq1ZRAktrfTTyNPBWUKCCj74eaQ18L8wEvVjObnjwkNnRqtmaJ4lUdmdelwgIbNmvRXLUrYWFw8THuLOjE11Caw3i2py/GWe/8WUj2ejprQj7UOoozXhx6lF1mjl7mBQt6gY5Ypv1MzKujic5E/uUaNzglEWVrBsNq7738TgoaQWYOBGfFD6q6Fw59dr9RQQ3/oKG50PJ+sBlfcg+m7vmCiUF9Of45Wj+moseAKkfr/oJQWALQLbYLx5Lc5B7/2bPMyWfbUO1JgENoBMoqzkXWN2z73HUt0g5q4+f2sCbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=baYjdNx0sNVdVXispJP4LcPnc2wK4QnNmbzh2KjM86E=; b=b2xoZzYysbcGXAWBt7LrMoPC3yd1TRPOPtUNcK4sWpsPkE1EUvEBFxDcgbfmcgV+1d8sm+vDi/SJ5T1kPPlcZMKyGCtm9OP8DElrYrBC8cPKOdAT8+LovkVdI3HzY8P5dWgfjHrHquRoz0CtgyYLhFPe4xc6jpR/0sZd8OVUXjg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAWPR08MB9592.eurprd08.prod.outlook.com (2603:10a6:102:2ec::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.56; Tue, 16 Apr 2024 16:31:01 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472%4]) with mapi id 15.20.7452.049; Tue, 16 Apr 2024 16:31:01 +0000 Message-ID: <79ba204e-edca-49f6-895e-76b6806197ba@arm.com> Date: Tue, 16 Apr 2024 17:30:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/8] gdb: aarch64: Move MTE address check out of set_memtag Content-Language: en-US To: Gustavo Romero , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, eliz@gnu.org, tom@tromey.com References: <20240416140728.198163-1-gustavo.romero@linaro.org> <20240416140728.198163-3-gustavo.romero@linaro.org> From: Luis Machado In-Reply-To: <20240416140728.198163-3-gustavo.romero@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0250.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAWPR08MB9592:EE_|AM3PEPF00009B9E:EE_|PR3PR08MB5593:EE_ X-MS-Office365-Filtering-Correlation-Id: 46adf475-9d0f-4536-02db-08dc5e329f94 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vMnayKQg2hpATIeLMwM6kRW5Z6FsNb406smDzyfdagw0yZj1X8nqwJrMk0UsjagZM6wIBETRbi0OMNGPOUmRlWIAL6CuqFYafxnuMJRVnUefexkK7l9n31pW2F3c3DtALiXhqcTcKv3UWtRGhUFQule1yGY50rfZC4J/aIPlUvsmVaPknZTVTulm46AJb4vB6/MiRlOxbzrJF2Pi9L/Ia7CSiOiTKrgi9DCJVdHASd+y1doMCcAij3S0zkrXsjq55mq7tmN+cXAhCeoU6/H5x+pbd90JmlYuOiooHKiH3caX6uJyNQ3cdzYvweb6EnqcYLYLSAlAp8YDGwNEx3RF7H+acYeWof7sm0fc9NnqlqTYx05ZXWyVPycqM/dQ5xv76p0UC3Bxuxk9AdZ/dXbZ/MPlCHJArLYBpczePs/nSllRlkkg7OsbYBZ8WuMIGvwkk8NwZ8NDx2iEHiZ9NPx4XxRoaQOZRronTD90CigyXA7hgh7pLRENU3tPcF+rC+PFxUUba8v3vZJTbZTrekBm0dsSEC693pdUABdPUJgkQCcDeAGNBRJnSQIUGEQbw5+ydiCopRGOoUS123ofczDRx7XzbQljpLBEtKuWyuSoAKexEvwt7Y019+pVHWv6hszKPO/NkzKFoOnnNT0h0zVRdQ3d4lzQE5EyPjqFgt8Oh6A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9592 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF00009B9E.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 349c8d95-3e77-46e0-bf85-08dc5e329a31 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vSbiudgeBtCZj020gtRxON0QYTnF8WJ+If6aVxHWN1jyk2MOHrmbUITL51swiG37Bc/BXkZG2Qa7TpRZyt1uRh23061xo3mGkXU22StwTUN2ItmJ2GZv+HsUrjEBzkKg7Va/dYP35clAP6JmfduUXLa0DaEoFpbZ/20QYRc2DFhDkjiNGYlVVOkARE8/Umt68X4tCMibePoCrssB8X5icIsj/NYPIDh3i5fVaRhUbmXnB18Qofg5AmEDMrwHT+a9wv0SKhIHkKIsMxRQvW256+aFXQVYzUO9DB6NmGsU4O3XQNbC8qO4Ht54HqGDlMfuqyo+FGTHevfpM8C3Xk5lxwPVwij1Iygd80MAkVY49y+PYvRAp5U4ctO4kyB/8mtGfitMYHUfCNo3KGoSQW8YMWd/AtHs8shEabe1TBpdFocEVk3ECAujYA/vCPvKRp59kKKrBSkDTmlTrihqMRx27n0v+nqps0IKFuy7mvQ9eF8noGYNC+Sxv9SQ7ZY/TJh5Zy5sLceEFH8WnsDaM9HlnUcgJxVebAHSgBxs1f3jBqythe88U2Gq2Y9m76quQbtZj3wNJqWnKbzgItp8fE/ss01ayDbXdw+vE1Yg7Tz13qEQpx6Ym29HjtD+mctJc4NCZwtBNIczsqJBk+2t+XSYwoje5tnkYWiDou5NAoZoZvFsNLTVPncZJBi6jNvS1K4DFhzRE8o5Z6pfReGB8NQm/AJgMMFel7NM09Z57v1wNz6i2CHM2urfaxbkza7MYDXf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(1800799015)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 16:31:09.7952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46adf475-9d0f-4536-02db-08dc5e329f94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF00009B9E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5593 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/16/24 15:07, Gustavo Romero wrote: > Remove check in parse_set_allocation_tag_input as it is redundant: > currently the check happens at the end of parse_set_allocation_tag_input > and also in set_memtag (called after parse_set_allocation_tag_input). > > After it, move MTE address check out of set_memtag and add this check to > the upper layer, before set_memtag is called. > > This is a preparation for using a target hook instead of a gdbarch hook > on MTE address checks. > > Signed-off-by: Gustavo Romero > --- > gdb/aarch64-linux-tdep.c | 4 ---- > gdb/printcmd.c | 10 +++++----- > 2 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index 50055ac3f48..8e6e63d4dcb 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -2525,10 +2525,6 @@ aarch64_linux_set_memtags (struct gdbarch *gdbarch, struct value *address, > /* Remove the top byte. */ > addr = gdbarch_remove_non_address_bits (gdbarch, addr); > > - /* Make sure we are dealing with a tagged address to begin with. */ > - if (!aarch64_linux_tagged_address_p (gdbarch, address)) > - return false; > - > /* With G being the number of tag granules and N the number of tags > passed in, we can have the following cases: > > diff --git a/gdb/printcmd.c b/gdb/printcmd.c > index cb0d32aa4bc..5635f605314 100644 > --- a/gdb/printcmd.c > +++ b/gdb/printcmd.c > @@ -3101,11 +3101,6 @@ parse_set_allocation_tag_input (const char *args, struct value **val, > error (_("Error parsing tags argument. Tags should be 2 digits per byte.")); > > tags = hex2bin (tags_string.c_str ()); > - > - /* If the address is not in a region memory mapped with a memory tagging > - flag, it is no use trying to access/manipulate its allocation tag. */ > - if (!gdbarch_tagged_address_p (current_inferior ()->arch (), *val)) > - show_addr_not_tagged (value_as_address (*val)); > } > > /* Implement the "memory-tag set-allocation-tag" command. > @@ -3127,6 +3122,11 @@ memory_tag_set_allocation_tag_command (const char *args, int from_tty) > /* Parse the input. */ > parse_set_allocation_tag_input (args, &val, &length, tags); > > + /* If the address is not in a region memory-mapped with a memory tagging > + flag, it is no use trying to manipulate its allocation tag. */ > + if (!gdbarch_tagged_address_p (current_inferior ()->arch (), val)) > + show_addr_not_tagged (value_as_address (val)); > + > if (!gdbarch_set_memtags (current_inferior ()->arch (), val, length, tags, > memtag_type::allocation)) > gdb_printf (_("Could not update the allocation tag(s).\n")); Thanks. Approved-By: Luis Machado