From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] GDBserver: Don't assume thread's a current process in D;PID implementation (PR gdb/23377)
Date: Wed, 11 Jul 2018 00:39:00 -0000 [thread overview]
Message-ID: <79d5e0fc-c3df-b276-855f-e463c7a19d8a@simark.ca> (raw)
In-Reply-To: <20180710190623.13540-2-palves@redhat.com>
On 2018-07-10 03:06 PM, Pedro Alves wrote:
> diff --git a/gdb/gdbserver/mem-break.h b/gdb/gdbserver/mem-break.h
> index 019a87da09..7d764fbd0d 100644
> --- a/gdb/gdbserver/mem-break.h
> +++ b/gdb/gdbserver/mem-break.h
> @@ -125,7 +125,8 @@ int add_breakpoint_condition (struct gdb_breakpoint *bp,
> int add_breakpoint_commands (struct gdb_breakpoint *bp, const char **commands,
> int persist);
>
> -int any_persistent_commands (void);
> +/* Return true of PROC has any persistent command. */
of -> if
Otherwise, LGTM.
Simon
prev parent reply other threads:[~2018-07-11 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 19:06 [PATCH 0/2] Fix gdb.base/multi-forks.exp regression with gdbserver " Pedro Alves
2018-07-10 19:06 ` [PATCH 2/2] GDB: Workaround D;PID handling bug in older GDBservers " Pedro Alves
2018-07-11 0:57 ` Simon Marchi
2018-07-11 19:50 ` Sergio Durigan Junior
2018-07-11 22:23 ` Pedro Alves
2018-07-10 19:06 ` [PATCH 1/2] GDBserver: Don't assume thread's a current process in D;PID implementation " Pedro Alves
2018-07-11 0:39 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d5e0fc-c3df-b276-855f-e463c7a19d8a@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).