From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2071.outbound.protection.outlook.com [40.107.115.71]) by sourceware.org (Postfix) with ESMTPS id 156F33858D28 for ; Fri, 17 Nov 2023 02:26:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 156F33858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 156F33858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.71 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700188002; cv=pass; b=jutBebbWTGqv/f7WfxEt9KeUXq7EQCXaEZks4Jt4mmY4SE+IbPEwUlSRK5UCRCcZ6T1OajWWGtJR3EJd0sDEWuU1UN3PwW+Y9YC+2ysNwheBAieP3JI2Chf8tmrSHl2uWfiJpSIEdOUOw6lbKzuKI2NOKhP53Pudy3lZUbJzlpg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700188002; c=relaxed/simple; bh=5G1REEMIwFMBAkFsMnFk1YiKN++vQFIRtT47gS7SKK8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=QIsDvbtlA8l6nivRD3rde5hv6KbUBQXbqR9MP719516sg3qFb4bJ7cOWoNyfD6P2GLH5olblfXlDdvHsO7ozGDZp0ru7SaUt6YOY2xZxl7C9BEuGmCZTHfTaLz4RMX3J5Tfloar48Pkjb2XnWdIO+q1iU2CiniU6nPoiTMSIFsE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjupRLg3tSllysTtha+1FI7IQDXm6gsbH3XIgyS/WWasxMygBzuY7ePIOozMZ/PhQ7nLNDGwVkikVZOVmT/kS9hJAuX2LAtuoQzonZ2oWHB3NHbXPqeySMNjMEQAZFtT/DcjSjTgLHP51yTj13QMYkSWbxbo80W9x6RIUE97LhcMALrLstg4PYk5GbvOhZYq2VPCjPKIJGQ1cKW1D6Cfo0sYdhWrThUkhWFNLTGrLIooowEJPv7zIgSrNcHtgIJShauB3W5jPpzLV1ZagLeO5OYXn2Fe4saHHwodts2k2RXhGvgrbARQ9ZLc4rWR46iOfiiy48OFVd71I0o7FTuU9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oWMVmdb87eEx8RWdk4/Ob8jiNQGIKTd3FpmFeWYBAJE=; b=LBCDx+DWj8StcQVPXa1YEw1GJ9fWsB/CP8agIoTtvoEY8i055lIvQ/adh8itL6m1Bem02gmmnJQbo3CjU9gDnQvAMgWf0uRmWokpJs98mco0Y05mo4+ryeunWySptI2MbUlW8IBRpxzVkBONRHGMDFH0thvnllW0e1fIsZHnyczVyyY6T+KLPRmGSZ5MhN/sE7sh2fEXZnaCJTyTByE2N9mEV1Jil9nQRMumNhzRwf/IDKjZvlZ0uuhQa/6gQ5SLB56IOww8TqK/i/P7ci9DiXwWRPhezMuRK1+uYHbjcaMdcZjlBavtN3IQO3NDFZPXfaqpdWQ3keS6aNjfu0bOZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWMVmdb87eEx8RWdk4/Ob8jiNQGIKTd3FpmFeWYBAJE=; b=dgAHdwhv5Q1cj9FGW/IVxa+KXDW79uB06XlqMPph0xnSwUW+68nMt9RRThYYyXaeA6gHRT99Zy5j01dzS+dE+ppwFp8jxlGbGW09UWiqv1X1EbqZZGuMeVOnBjifpc5nD6oVI8KgJyqic8HlbbikU0kfkacUEu34sAxlKtszFcLxgVi+s+JMS93Y8vrQhFfCuTuFEYylYzyVM/ER+mcISsU1zVHdbDK1CilRhxiVezsa9gmhBKQM8e/5nYYWBnuug1MS5zhrvL4JjR/+w9S2TZjCB4BYyZsMzxYFfNIg0u2rqrTt3kcQ3Cw7kOv/tOk0zD7kGLuJ4L5Q/Mzg2Cg9GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB6257.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 02:26:37 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7%3]) with mapi id 15.20.6977.019; Fri, 17 Nov 2023 02:26:37 +0000 Message-ID: <79de2690-8cdf-42be-ac60-db55d98c6be6@efficios.com> Date: Thu, 16 Nov 2023 21:26:31 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: remove two uses of obstack Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20230412202701.349105-1-simon.marchi@efficios.com> <87zfzgpbzf.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87zfzgpbzf.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0034.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00::47) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB6257:EE_ X-MS-Office365-Filtering-Correlation-Id: 51201465-7766-43ad-1536-08dbe7149fbe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gqxxcckteNibCZZQPo3LDBZi4p0yfZrYiW79iLRn9wRi9HmvDH2GurzfhrDUGBn6LBE6xGDeEbckC8joCDXIlZsycFrxhSSnO33kZgfnnag5DA6CvSm5Pw0Xqp83kSwRwH4mFfOuFmKH9T8ZUByoWB7rSgiaPkzeZ7PZbm9EgU5okdzTcYDLuEAmV3X9bfghMVT4GWP6+UinTasiD3LWK6O9oDiYO3//lTdjZ4sG15Aeh3/pTPRGeeBDSzDCZ2Cdv05uOxNTl6031sCvSq+eGMSuph4gw69ePEEB9PvB4zj0nX6quaOw81uFRZPKs9h5z1bFREk7e9236yoW73Kf9T0dn0cw5e3SPw6s+TrasI9K+t1vi41eNfJI5Xv2vs1YQFkRQsh0lUTRRVMxKbuJFUYwWfZlmdiYh/nEAypV2/G7Tgx8cTohagIq7kZfG7zplx1qtdC12tKK+pJSwhCLPXqfuTEktleVhdSLx2fzGrZgaq2GtT6GbMZ7hzQErQqxp2LefVDAN3ZFe74e53C0tHe7/p9KVq40XjR5eKApU+iONMusGJoydypklQJ0uhG+AfQxKZms5h4yyEp8a/IyRAol2UfrYQQh+tqA42MmEEb1eXBsCkOkd7i3qpz6RlHXl6W92G0sFPfwSQ1KBDCJAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(39830400003)(376002)(396003)(366004)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(4744005)(2906002)(41300700001)(316002)(66476007)(66556008)(8936002)(36756003)(8676002)(110136005)(66946007)(38100700002)(478600001)(31696002)(5660300002)(44832011)(31686004)(6486002)(26005)(6512007)(2616005)(6666004)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0ovc1VMemdFNnJkVzV2YjJoM2dUeDJKa0hkclVSMWNiUVB4VHhVeTdRU3RJ?= =?utf-8?B?alJ1eTRzVmc2cFluN2hTRGZuNWN6bTVOVjQzam0yakcrOUllSkJrRjlGc29r?= =?utf-8?B?ZE5qN214R1laZXUxUUdybkI4bHJnVzFlSCtMNzFqazZuVXM5dFBlRW9lcUk3?= =?utf-8?B?NTM0SkQ5L1FBNWlVWjlUK2hpYUdCVUtqdmxnV3JxOFYyWjVFajZJSG5RRXFW?= =?utf-8?B?UjFqdkcwZSs2dGxIZDduaEUxUHhmVUxEMG9UR2tOR3YzNzdKR24vMUcyTm5s?= =?utf-8?B?cXFQdGFhM1VGNXVQWEh5NE45dkVsemZpMlF5Z3E3VXZ1T0Nwd3QyaVhmWElM?= =?utf-8?B?YXgzMEpaekZMQWJOSTQ5clZod1ZaWjBRQm4wc3JweWpuMVNITUFpdER4Zzh6?= =?utf-8?B?TUd1SVFHSGlRRUUvNDRxUUo5S2V3dTE2WjBJNHhkWGl4d3BleTcrelpsMmxi?= =?utf-8?B?UzJrL01DWE91RFh2c20vZlBLeWVQN1p2RXBQbE42WUlwVllSa0tFczlSTUFZ?= =?utf-8?B?cE0rSWRuNFRCb0VicTJlL1pjSjlucWtpeXhOTzVSb2sySXpNSWdmS3ErVHU0?= =?utf-8?B?WmZJNm1IVTMwV0NqQzFvVktoVTFCY3d4NjVYeDNGTzBvcUticXNRU1ZheW04?= =?utf-8?B?YVhzNW9oSUMrQXhZODZSNWxRME5XQVNUc1I2UXJOK1l3UkhKVkdZZFNTNnpO?= =?utf-8?B?OHNaM290MVFYeE15T1ZCc1huZllkWGJ4bXUzMFlSam1jWmZXM0RINHh0L3pz?= =?utf-8?B?eE84OVUwS2JEZGpoMzVQd0x4VXpjY2JFaVJsaGJ0U1pvVFdtR0Z6SHVTS083?= =?utf-8?B?eSsyemlsNkdQRUZDUVV6ZFVwR0hvaVhDMnlRUW0zQ1BJenJ6c0gvemFpTDNj?= =?utf-8?B?U1hUa2pRMG9ISU5DdUxPSUg3eUx6bHVuVGtDZXlRcWxDNURyOFhlU0N0Rm9S?= =?utf-8?B?SzRJTFNiczFqdmFUeGJ0SUlpVW9id1pSWmNzaDNHdi9LMFZqSU9PWDBaT2t2?= =?utf-8?B?b29WSkdMYXRocEtNUEdleC84eTdnei9tc2hTb09qWk10UUt5Zng1MXc5MlhP?= =?utf-8?B?Z1ltR3FPSG9uZXJGaUdoQUNPYjBWU3VaSEU0TnFtM0FEeHZWcW9RdE1FYXV6?= =?utf-8?B?RTBCdWg3aXI4R3ZYbXBPd25HSHRKZWU0blZrRmlaZUhGVS82dzdEY0dTeWJ6?= =?utf-8?B?Z1V4emZFaGR0aldNS05EcDArS1dweFMyRXdZRDhsMzUwZjFRblRJZnlLTTNz?= =?utf-8?B?RDZYSlRBMHN4K0V4MXRmZVNKRzRvWU5wK0JBNEZ3REkzelpKVlg2RzlmcVZ2?= =?utf-8?B?VmVyZGd4SHdLeWZGS3RTUlRTa0cyMnd2UUVmQUw2ZzhQYm4zeHJSMnV2Ull1?= =?utf-8?B?emtCS0svbGh5Z2VtSTEyMndPbDc0c21ra21VSnNMdGp6RXhQUGhldm9iZWZS?= =?utf-8?B?NUY0TmxKWGgvbVlQb2k0ekJQM3l5enpVZ21wdnAxckd2eWFRcVJSbVdKTzVB?= =?utf-8?B?WWw3Qmdvc2gzeWFsd3ZocC9hUDA1VWwrdnErV0tvS1p2OHRRdGpnUTZtTEFC?= =?utf-8?B?L0QreGk1ZU1KQVA3elNtNHNONE9yZnFoT2lFYllYaWRhODR2R1k3aGRNbElI?= =?utf-8?B?TVRSQmtEWWRSN3dEN2x5Y0ZZZTNldkhOSUhkcWxJKytyOUtTaVIzQ0dWS2J3?= =?utf-8?B?Qm9QV1ROK2ZYS1V1ZlBtVXBsYkRCSmZ2ZzBUYysxK241ZzJRQlBKTjFXYVBX?= =?utf-8?B?SnJEZUUwM2drcGQ5L2pWMGgzSEVzWWNIdDJibXZ2NXlIMmlPc2tiZ2d5bnFY?= =?utf-8?B?bWZyTUlqUHBHRWlTZ3h3UEFpRi9Kemk4VnRPV0ZJeXZwbFQxOTJMSklJVFg1?= =?utf-8?B?N1dzZ2F4aS9EMzFoa0NYemsvL015L1BhaW9HNVVzMnF2dVNGOCt6QXZFLzVi?= =?utf-8?B?RnVwY1pCdFlsTGNKOWE0SDhKSTluSVJxTVpOVjRJZ0xqSG56WVpvVjVDVlJW?= =?utf-8?B?UmhsV24wdVp1eXhhNFZSZXBFU2tVZXR1cEFKQk9sRHkxUnpzR1hCNjdvc1kr?= =?utf-8?B?d2VrS1NXUWpVTXFxYzQ2amZnRGFzV2RETkdSZy9GWDVnZWk2WVlXZ3l2WUVP?= =?utf-8?Q?XRSkGBeOjZRfC+xu8pvTxHR+f?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51201465-7766-43ad-1536-08dbe7149fbe X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 02:26:37.5692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ewV4lRAFsXZPBWj2IOZ0MHYDrj7F8aJG/r4SHRvhlJ4Bdhwbq9wQ24X87v6sjvUDPCmO56WyiUgQF0cZV8WAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6257 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/23 10:53, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> Remove uses of obstack in the code generating the libraries XML for > Simon> Windows and AIX. Use std::string instead. I'm not able to test this > Simon> change, unfortunately. > > Came across this unreviewed patch. > > I think it is ok. Also, it's early after the branchpoint, so this is a > good time to put it in if you are unsure. > > At least the Windows code will be tested here at AdaCore sometime after > merging. > > Tom Ok, thanks, will push. Simon