From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by sourceware.org (Postfix) with ESMTPS id A69C43857C43 for ; Mon, 24 Aug 2020 13:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A69C43857C43 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f65.google.com with SMTP id b66so5933597wmb.1 for ; Mon, 24 Aug 2020 06:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KCToCcXw6AZfdhYJyyuI58XZKpR7tofrIgRYrex4NF4=; b=FkfheY9omaFqUG5hWKeqwOfcg7YjkjVKzvPDC58DktvAInlv1v697Zcxt8mC/201iH FcVuXekzgUt13MH9suHMW88VDWBYCxlLLP02dnMXKbwmH+H74ggr+4MpCQtAIQ+ikTec DXLxUIby/7nduxf6GkTLBgAZH9erKXGsqgvRdUId4PUksPS8T2m5dameHqmTz8tDhMII yvN9Q3oTFQmAKcUIB68r6EM03k+rgiAHw3gNlHnY4GB4Y6jyjiBWUc66pn7Ny2SmPUgY Mz6U91xePNMn0v5qxcnS+gW+22pE18cfcgS3H3BEa2XTTS6gCLOrjLWnVC/mZ36LNWSq JX0A== X-Gm-Message-State: AOAM531HptDAmfjlzpg3OXJQRhMBdZuw2N+nm/261IY5akbZZxP8WNRG /DurznM2FCumtT252Z0dVwLuejyf/aOSPQ== X-Google-Smtp-Source: ABdhPJwEWtCNJlE8CwJrNpXn2mrHkglcXyU/FcXVwqAb5199o1urehUuWFbc/U5xzwrthlMxkgF5mg== X-Received: by 2002:a7b:c106:: with SMTP id w6mr5702843wmi.27.1598276765894; Mon, 24 Aug 2020 06:46:05 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:56ee:75ff:fe8d:232b? ([2001:8a0:f905:5600:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l7sm23304111wmh.15.2020.08.24.06.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 06:46:04 -0700 (PDT) Subject: Re: [PATCH] Update gnulib to current trunk To: Joel Brobecker References: <20200630184349.4009048-1-cbiesinger@google.com> <83h7upwxjl.fsf@gnu.org> <2d285f8f-57be-2d4f-ce7f-57afe65c6898@palves.net> <791b00ea-60f3-3e3f-8d67-dd017b46ad57@palves.net> <20200823213725.GA12645@adacore.com> Cc: Christian Biesinger , gdb-patches From: Pedro Alves Message-ID: <79e08407-9a87-f057-edb2-ca9621ae2b3a@palves.net> Date: Mon, 24 Aug 2020 14:46:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200823213725.GA12645@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 13:46:10 -0000 On 8/23/20 10:37 PM, Joel Brobecker wrote: > Hi Pedro, > > Christian seems to be busy these days, so I thought I could try to > help get this one in. > > I'm going to quote the whole discussion below hoping this helps make it > easier for you to remember the details of this thread. which is about > updating gnulib to a newer version in order to bring in a change that > Eli wants for support of mingw.org's version of MinGW. If we wanted > a quick summary, my understanding is that following: After a closer > inspection of the delta in terms of modules this update causes, > we found that: > > - btowc gets added, for which you say that we should keep an eye > on it wrt the logic in gdb/gdb_wchar.h, but I understand > we should be OK for now; > > - We lose gettimeofday, and decided to add it. > > - We lose sys_time, and you suggested that the easiest is probably > to accept that for now. > > I have taken Christian's patch, and rebased it (there was one conflict > in gnulib/configure, which I resolved by regenerating it), and then > modified it to add gettimeofday. > > As it happens, when doing that, we get sys_time back, as well as > localtime-buffer too. So, even though we said we could wait and > do nothing about it, the question becomes moot. > > Attached is the diff between Christian's patch (once rebased). > I am attaching those even though this is not the patch I am proposing > because it should allow everyone to see the actual effect of adding > gettimeofday back, and see that the new version does bring what we want > and only what we want. It's only a few files, but still rather large > because of the files being added (back). So I made two versions: > One with the new files being elided, and the second containing the full > diff, but gziped. Hopefully that'll fit within the mailinglist's > maximum email size. > > I will send the actuall full patch, which consists of Christian > and my changes combined, with the ChangeLog updated accordingly, > in a separate email, also in an effort to stay under the maximum > email size limit. > > Does this look OK to you now? I'm not very interested in looking at the full diff -- I trust that it's OK. The overall set of modules that is added / removed was my main interest, and what you say above sounds good. Patch is OK with me. Thanks, Pedro Alves