From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B088F3858D28 for ; Thu, 19 Jan 2023 08:04:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B088F3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674115492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEFwqU/t8VQVreycE6y/hgtQB7Ngts25DgoBJJB5KTk=; b=gwdtEklU7qh5oW1RN9YTbBTTBOjEdTSi80wCYzJc6KwAMRpAfeQvMoRnYb7FWMmGlX8X/t 9FHMK/ep6X/JrfBjBhyFFxn73XOIabLqq078Y1cjVi7YvSru8Zrx9o6L+M8b+U8VPc4g89 lxenIxskUciYqo8uKz0ydKTjYUqSPb4= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-47-LsK4Ab82OFSMoU8ZpIWsVQ-1; Thu, 19 Jan 2023 03:04:50 -0500 X-MC-Unique: LsK4Ab82OFSMoU8ZpIWsVQ-1 Received: by mail-qt1-f199.google.com with SMTP id v15-20020ac873cf000000b003b6428b16deso594490qtp.3 for ; Thu, 19 Jan 2023 00:04:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aEFwqU/t8VQVreycE6y/hgtQB7Ngts25DgoBJJB5KTk=; b=CiuHNenalF9KGmvSCXA2iYPIpZrxz3Zq8uFNDm9q2dpxq7s/4Xecs8M7ELh5wo+4qO uhnyAg5uD/uISWjIzYYT1gE3C+g6iy/lItISbjgQxWmzzOK1znxk1zXHX5ILkUZ1FbWG /QLefH2BemfZI6azvT9HxtYwgTH+DeuH0sDroyrU5jqR+yheVbhGGnM0G+gQOga6IEmh osvq36HBgH5Rvcgwc/1/Wjxru5d/+h7PtU7Q1VV+moKtanvkpD+FmHOriV9mQg7aqBUY ukv08LdewVjuGkMyIEFOJHFqADFeKA/PyQoX7Wg/J/RlUL6jsNdK6q5WuxryWfLC6S7C MPYA== X-Gm-Message-State: AFqh2krdT7h3t2v8bB80xdF8LfIR/cV6kui9k0bf64GB/QMB0Xd/OhjY cOM5HxcXeNI2PvH0HeeKFfv+CPhVsz7vwRXvp+tvWN9RVk+MgzCnh6J8K+gcP8humEhIwFFUUNp zlJmsEWARPAxcY+TixW1uIA== X-Received: by 2002:a05:6214:246a:b0:534:807e:410d with SMTP id im10-20020a056214246a00b00534807e410dmr20588148qvb.6.1674115489742; Thu, 19 Jan 2023 00:04:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXvHQCcvi4p9cB0W8orvy6qZth5uIvujwdEFoVTDRuKNEqyU8Mn0rGKJBfdd/TRlLcTLEnCxdw== X-Received: by 2002:a05:6214:246a:b0:534:807e:410d with SMTP id im10-20020a056214246a00b00534807e410dmr20588113qvb.6.1674115489513; Thu, 19 Jan 2023 00:04:49 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id bj3-20020a05620a190300b00705975d0054sm23853738qkb.19.2023.01.19.00.04.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 00:04:38 -0800 (PST) Message-ID: <7a494157-494f-6adf-d533-bf373b0f054f@redhat.com> Date: Thu, 19 Jan 2023 09:04:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2 version 2] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp To: Carl Love , Tom de Vries , Ulrich Weigand , gdb-patches@sourceware.org References: <071f24ecf9b3a2bbbe8fee7db77492eb55c5f3ff.camel@us.ibm.com> <1d9b21914354bef6a290ac30673741e722e11757.camel@de.ibm.com> <3e3c9c40f07ab01c79fe10915e76ffa187c42ad9.camel@us.ibm.com> <122f5d2d3db9ef1979b0f8da927d005f32bba82c.camel@us.ibm.com> <011768e8-2b76-f8ed-1174-fbaa020b15e7@redhat.com> <78b464a1-e32e-c3da-85e4-7bfc322cc29f@redhat.com> <7848e9858b54e33e399b871774ffc0b5058c1736.camel@us.ibm.com> <65d44121-65f7-a212-79ec-07ce53c15ecb@suse.de> <9fe94c0979cb40979b0dea7693a901c2d9f66164.camel@us.ibm.com> <59417813-eb4a-baf8-4e5d-e225d6732f71@suse.de> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/01/2023 23:26, Carl Love wrote: > Not sure what more I can do at this point. If you have some time, can > you take a look at the failures on your machine and let me know what > you are seeing. Maybe we can figure out what is going on. > > Perhaps Bruno can also check to see if the two tests were ran on his > machine. If not, hopefully the info above will help Bruno to get the > tests to run on his machine and we can see if they fail there as well. I just tried running the gdb.btrace/rn-dl-bind.exp and also got 9 passes, so I cant help there, but I did miss the 2 failures in tailcall.exp; here's the relevant log: Breakpoint 1, main () at tailcall.c:37 38        answer += 1; (gdb) PASS: gdb.btrace/tailcall.exp: next.1 reverse-next foo () at tailcall.c:29 29        return bar (); (gdb) FAIL: gdb.btrace/tailcall.exp: reverse-next.1 step bar () at tailcall.c:24 24      } (gdb) FAIL: gdb.btrace/tailcall.exp: step.1 finish Some extra context, line 37 (the line that is being "undone" by reverse-next) has a call to foo, which calls bar. Whats going on here is that we're hitting the step-resume breakpoint when exiting the bar call, instead of when exiting the foo call.Has a very similar smell to the type of bug I fixed in commit 1f3e37e057e876b37db49dbd8ed5ca22c33f6772, but that fix itself might not work because of tailcall optimizations. If you have the test compiled, you can trigger the bug using regular record, no need to use btrace specifically. -- Cheers, Bruno