From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id A6EA43857024
 for <gdb-patches@sourceware.org>; Wed,  7 Oct 2020 03:02:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A6EA43857024
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 3C55D1E58D;
 Tue,  6 Oct 2020 23:02:35 -0400 (EDT)
Subject: Re: [PATCH 09/10] Include the functions of qxfer_libraries_svr4 in
 netbsd_process_target
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
References: <20201002021804.2814-1-n54@gmx.com>
 <20201002021804.2814-10-n54@gmx.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <7a736977-6ef4-6843-33bd-926179273e0b@simark.ca>
Date: Tue, 6 Oct 2020 23:02:35 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002021804.2814-10-n54@gmx.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2020 03:02:36 -0000

On 2020-10-01 10:18 p.m., Kamil Rytarowski wrote:
> @@ -848,11 +850,11 @@ int get_phdr_phnum_from_proc_auxv (const pid_t pid,
>    return 0;
>  }
>
> -/* Return &_DYNAMIC (via PT_DYNAMIC) in the inferior, or 0 if not present.  */
> +/* See netbsd-low.h.  */
>
>  template <typename T>
> -static CORE_ADDR
> -get_dynamic (netbsd_process_target *target, const pid_t pid)
> +CORE_ADDR
> +netbsd_process_target::get_dynamic (const pid_t pid)

I think this change here makes sense.  Instead of passing the target as
a parameter, it makes sense to have this as a method.

For the other functions that don't care about the target object, same
comment as before.

Simon