From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2A8CC3858D20 for ; Mon, 20 Feb 2023 17:08:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A8CC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 708F51E128; Mon, 20 Feb 2023 12:08:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676912908; bh=v28v4zSEY+5CImJVkl67x6Ujaz7mtOJD6Mu8tknAaIU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=MnmpbMv2ktwrJscNGkSuU6z/pB8zVv5CG7O89m+Zlsm21yCIcmcyYsUl6vVcqvxrH BNdbHlDuoegpbikCARNjqdIdBUcddYHek3ILG/twH5K03DI8LiMURYm6TDXB/RR0fp pOQZxy4Z0JxXYKybL2dtikrhdzeuQdq3CXuCHAYQ= Message-ID: <7a7dbf0d-c6d6-22bc-5bb1-c671b7720424@simark.ca> Date: Mon, 20 Feb 2023 12:08:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] gdb: add --with-curses to --configuration output Content-Language: fr To: Philippe Blain , gdb-patches@sourceware.org References: <20230211-configuration-show-curses-v2-1-a28c6ea6f00a@gmail.com> From: Simon Marchi In-Reply-To: <20230211-configuration-show-curses-v2-1-a28c6ea6f00a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 7c7bf88b3fb..6ad0f9d8815 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -563,11 +563,11 @@ if test x"$prefer_curses" = xyes; then > # search /usr/local/include, if ncurses is installed in /usr/local. A > # default installation of ncurses on alpha*-dec-osf* will lead to such > # a situation. > - AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses]) > - > - if test "$ac_cv_search_waddstr" != no; then > - curses_found=yes > - fi > + AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses], > + [curses_found=yes && > + AC_DEFINE([HAVE_LIBCURSES], [1], > + [Define to 1 if curses is enabled.]) > + ]) I don't think the `&&` is needed, you can just put each action on its own line. It becomes regular shell script in the end. I tried removing it on my side, it seems to work fine. If that work for you too, I can push the patch with that little change. Simon