From: Simon Marchi <simark@simark.ca>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile
Date: Tue, 13 Sep 2022 09:57:55 -0400 [thread overview]
Message-ID: <7a9ffb88-ac04-f299-93ad-0901ea6aae12@simark.ca> (raw)
In-Reply-To: <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com>
>> When typing just "make" in features/, I get this diff:
>>
>> diff --git a/gdb/regformats/or1k-linux.dat b/gdb/regformats/or1k-linux.dat
>> index 7b64646fc65a..9a9f8a640188 100644
>> --- a/gdb/regformats/or1k-linux.dat
>> +++ b/gdb/regformats/or1k-linux.dat
>> @@ -2,7 +2,7 @@
>> # Generated from: or1k-linux.xml
>> name:or1k_linux
>> xmltarget:or1k-linux.xml
>> -expedite:r1,npc
>> +expedite:
>> 32:r0
>> 32:r1
>> 32:r2
>>
>> Probably a separate fix, but I think we need
>>
>> or1k-expedite = r1,npc
>>
>> in features/Makefile
>
> Just typing "make" in features does nothing here. Am I neglecting to do
> something?
Oh, probably because the date of the .dat files is >= the date of the
.xml files. If you do
$ touch *.xml */*.xml
in features and then "make", it will re-generate them.
Simon
next prev parent reply other threads:[~2022-09-13 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 22:47 Keith Seitz
2022-09-12 22:47 ` [PATCH 2/2] Constify target_desc declarations Keith Seitz
2022-09-13 13:38 ` Simon Marchi
2022-09-13 13:34 ` [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Simon Marchi
2022-09-13 13:55 ` Keith Seitz
2022-09-13 13:57 ` Simon Marchi [this message]
2022-09-13 14:44 ` Keith Seitz
2022-09-13 14:10 ` Luis Machado
2022-09-13 15:11 ` Simon Marchi
2022-09-13 15:19 ` Luis Machado
[not found] ` <2e6adda3-3cdf-7520-eee9-d58f179537ab@redhat.com>
[not found] ` <3b7b0389-3cfe-ea44-7a22-9cb496debd4c@simark.ca>
2022-09-29 17:08 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9ffb88-ac04-f299-93ad-0901ea6aae12@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).