From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DAEC03858D1E for ; Tue, 13 Sep 2022 13:57:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DAEC03858D1E Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7739A1E0D5; Tue, 13 Sep 2022 09:57:55 -0400 (EDT) Message-ID: <7a9ffb88-ac04-f299-93ad-0901ea6aae12@simark.ca> Date: Tue, 13 Sep 2022 09:57:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Content-Language: en-US To: Keith Seitz , gdb-patches@sourceware.org References: <20220912224733.2962282-1-keiths@redhat.com> <383112d6-4d64-38e5-9e77-3f46b845e494@simark.ca> <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> From: Simon Marchi In-Reply-To: <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 13:57:56 -0000 >> When typing just "make" in features/, I get this diff: >> >> diff --git a/gdb/regformats/or1k-linux.dat b/gdb/regformats/or1k-linux.dat >> index 7b64646fc65a..9a9f8a640188 100644 >> --- a/gdb/regformats/or1k-linux.dat >> +++ b/gdb/regformats/or1k-linux.dat >> @@ -2,7 +2,7 @@ >>   # Generated from: or1k-linux.xml >>   name:or1k_linux >>   xmltarget:or1k-linux.xml >> -expedite:r1,npc >> +expedite: >>   32:r0 >>   32:r1 >>   32:r2 >> >> Probably a separate fix, but I think we need >> >>    or1k-expedite = r1,npc >> >> in features/Makefile > > Just typing "make" in features does nothing here. Am I neglecting to do > something? Oh, probably because the date of the .dat files is >= the date of the .xml files. If you do $ touch *.xml */*.xml in features and then "make", it will re-generate them. Simon