From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 38DEF3858D20 for ; Sat, 11 Nov 2023 19:42:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38DEF3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38DEF3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699731763; cv=pass; b=dz49NGY4DX8aMgfoUnI+UFQ9DOtAfpwA0oxRbBUygrcOTK4JBkpEMMYnjN2y8DkJnszSIycZ7OR29Xj7Ze/levQY9M5r5MDR/6ri2qnzHr3rt5XFE3iqgwXO7l7EJD2IAXDLZ55irCE8CxUoCh7wmJhtJR0pmiocgutuzOXqP98= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699731763; c=relaxed/simple; bh=CtEthFMACQF+otCyRLOV/G7yPZ19yM91xxX00rlKIV8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vl70/O8boEjNQMPX+pLExHWV5vwcP0pdPcWd4I0BwjA1jgFxjAr8ZBIsulqyTd+WqBK3B2yjVR+Uf6VX1lGplmTFIa3D3CCga5mpvuiB03mjW3Bs3hUqT3BC7Vll6BvCbyX3nDsKXs8Q+HdBu3AKUaOUubQA7t49UqG5Tlh4XiA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4SSR1D2BbWz4Wk6; Sat, 11 Nov 2023 19:42:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SSR1D1Rmnz3K6K; Sat, 11 Nov 2023 19:42:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699731760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kwUMIMKc2vAWS8sK+6TtXxt44rCf1smg9L9/ha6PgP4=; b=vBlj/4nsNBRxAz/Hb1XIF9qzpezVaDzRS9DabCVo2XhdZZAVqbb6hZvr2TSaV/F7z/gkmY w9gk6fyQnZwlQehHlAZUveW1qnoShi4XL8OqU7WwGGlcJQqMW0W4WvHhALrzFR4A7RPJoA rNYLJdRMNRV91tUEX8uVLWTO4PqZU9POkNQmNVfrz0o5fvKEeDjqUYn25ekBju1I00GkKn G/2z9i2+tKQ6aCDwZnscQf5wTm5qeKaIE/89PtnZ1A/ZivHSIhQ8aSJWdFAeLFBVLRzjaj VKhEBog+4Iu2R4wCAMde1kUVV+NirtvS92QRofVgBGZCe06QQVOXypxMzh9gGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699731760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kwUMIMKc2vAWS8sK+6TtXxt44rCf1smg9L9/ha6PgP4=; b=KQ4ZHo6q+yVA1i3ZU5ddLMQgBVW4TtM4/QafvNwd3Z6rgTGGLyvpiLAVmJ5z5tJLnCkNet rGK61pm+xQBFVVp6aaBPR6q0zolupaYOpIZEiLCurHottDYp2ddy7P3hgqQq+CI/fTGfnU dEX0mkB2Rjhj2h+JDLcN8JkgUlZ2RuYZ+3z4RgXmgTufAbQ79rXsVyKrEGYSb886AmLqR8 I0Tv9kQcDH+jjqXQKhuEIQ4xVBrCn8uolp/hWKG0atckXPahX9xfHcD8EOR6Nn7O8BqSp5 ZYFb1Uo8pr9JW+pv3kYY0puQHGNXEWpfmucCJnTEvL0YCYzDW7BnwlQgsA12MQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699731760; a=rsa-sha256; cv=none; b=Lu0YH4IU5tgprnqDqzeRIeGyF8soI6isJg1zVbUQkD0EIslQIS9ZdfCd2FWdb9YiViNCiv xUGZL6sXZPwJhNpW9REE5NdFHHC2jX2e03kymw8vauuBuUWaMcYj5fvyLHykOm97nMH0Xg 96nxTcUXjesJzHwyKARB/t9CSGnfTUHOIy+n1Phe9VeANzSoacSuxA3MJTP13dlSjWYY4w jsaVAcjEOq/39kNUlBsiogjWabO+1JmCKogUgZpP7aLXopsLhY5JvlntSocgoIllACUsiI umwUBQRddFPUyB6bo2z2gBpUQtAb7H52spGPlTzZa0v45Mk7aN6aHlY4Dhrvug== Received: from [IPV6:2601:648:8384:fd00:8dc8:68:d931:e24b] (unknown [IPv6:2601:648:8384:fd00:8dc8:68:d931:e24b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SSR1C5R2nzCs2; Sat, 11 Nov 2023 19:42:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <7ab24b87-520f-4499-beaa-ad48739d9207@FreeBSD.org> Date: Sat, 11 Nov 2023 11:42:38 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi References: <20231108051222.1275306-1-simon.marchi@polymtl.ca> <20231108051222.1275306-3-simon.marchi@polymtl.ca> From: John Baldwin In-Reply-To: <20231108051222.1275306-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/7/23 9:00 PM, Simon Marchi wrote: > From: Simon Marchi > > Right now, gdbsupport/common-regcache.h contains two abstractons for a > regcache. An opaque type `regcache` (gdb and gdbserver both have their > own regcache that is the concrete version of this) and an abstract base > class `reg_buffer_common`, that is the base of regcaches on both sides. > These abstractions allow code to be written for both gdb and gdbserver, > for instance in the gdb/arch sub-directory. > > However, having two > different abstractions is impractical. If some common code has a regcache, > and wants to use an operation defined on reg_buffer_common, it can't. > It would be better to have just one. Change all instances of `regcache > *` in gdbsupport/common-regcache.h to be `reg_buffer_common *`, then fix > fallouts. > > Implementations in gdb and gdbserver now need to down-cast (using > gdb::checked_static_cast) from reg_buffer_common to their concrete > regcache type. Some of them could be avoided by changing free functions > (like regcache_register_size) to be virtual methods on > reg_buffer_common. I tried it, it seems to work, but I did not include > it in this series to avoid adding unnecessary changes. I agree that just using reg_buffer_common in shared code is cleaner. Adding more virtual methods to remove static_casts in a followup seems sensible, but definitely fine to defer that to a separate followup. Reviewed-by: John Baldwin -- John Baldwin