From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15999 invoked by alias); 27 May 2016 10:18:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15990 invoked by uid 89); 27 May 2016 10:18:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=gplv3, H*M:55f7, GPLv3, RESEND X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 May 2016 10:18:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B943147072; Fri, 27 May 2016 10:18:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4RAHx2X020814; Fri, 27 May 2016 06:17:59 -0400 Subject: Re: [RESEND PATCH v6 4/5] Include group information to xml syscall files. To: Gabriel Krisman Bertazi , gdb-patches@sourceware.org References: <87shxd1mx2.fsf@oberon.home> <1463713807-11250-1-git-send-email-gabriel@krisman.be> Cc: sergiodj@redhat.com, dje@google.com From: Pedro Alves Message-ID: <7adaf517-55f7-8773-749c-767fe0a37406@redhat.com> Date: Fri, 27 May 2016 10:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463713807-11250-1-git-send-email-gabriel@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00480.txt.bz2 On 05/20/2016 04:10 AM, Gabriel Krisman Bertazi wrote: > Patch 4/5 bounced due to size. Resending with -M to detect renames... Thanks, that's the right thing to do, even without bounces. Best is to adjust the git config to make that the default. On 05/20/2016 04:10 AM, Gabriel Krisman Bertazi wrote: > --- /dev/null > +++ b/gdb/syscalls/apply-defaults.xsl > @@ -0,0 +1,31 @@ > + > + Shouldn't this file be GPLv3+ like all other build or source files? > We maintain linux-defaults.xml.in, a template file to hold generic group > information. It is used by the XSL script that parses the architecture > specific files to generate the final xml files, which are actually > installed and loaded by GDB. The script is not run during the normal > build process, only when building in maintainer mode. > +@MAINTAINER_MODE_TRUE@%.xml: %.xml.in apply-defaults.xsl linux-defaults.xml.in > +@MAINTAINER_MODE_TRUE@ $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_SRCDIR)/apply-defaults.xsl $<;\ > + Please always define the rules in the Makefile.in even without maintainer mode. What you want is force the _dependencies_ when maintainer mode is active, but leave them out otherwise. That would make it possible to force-regenerate the files even when not using maintainer mode. See e.g.,: gdb/Makefile.in: $(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps) ... So that'd be something like: %.xml: @MAINTAINER_MODE_TRUE@ %.xml.in apply-defaults.xsl linux-defaults.xml.in $(XSLTPROC) -o $(SYSCALLS_SRCDIR)/$@ $(SYSCALLS_SRCDIR)/apply-defaults.xsl $<;\ It'd be convenient to add a rule to regenerate all xml files, something like: .PHONY syscall-xml syscall-xml: $(SYSCALLS_FILES) .PHONY clean-syscall-xml clean-syscall-xml: $(SYSCALLS_FILES) rm -f $(SYSCALLS_FILES) Thanks, Pedro Alves