From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 746D63858016 for ; Wed, 28 Sep 2022 19:27:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 746D63858016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id 130-20020a1c0288000000b003b494ffc00bso1378466wmc.0 for ; Wed, 28 Sep 2022 12:27:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date; bh=yopOwkJTYAQ5xBIx5qQw0fM9HxKqEopX6KfGO5Zg03M=; b=cCzQHIQ3tK3HO8km0UbssoXjmhl1ytyV+GAXVFcEvwNJ3F0JkZocCi3Yr3/QYfdHxE yPipf6lacNDHTpWIllg42zixcURUHCBPgc4N6DtEzQIWPF+twBSbLlDVlK99KIRnZxT1 FpptIbwFPAe3WQvbEw6na6wG3pGvefKAu5AIXtKqV3SSRB+eYfq1zfmGY7bLldKMB+Dh XFCUX9c8KP0OMa9VmbZChSz3eveUYI5LZAk6osKjlQvfIQ87CzmHXaeS1Q1zC4upBN0N ubc+w3h9wXRb6AFXnlGeWHsS9jlD+owlAqgX0ZTvxeD25z9fyZlaLfQ1/mm+glH9GP1S TeZA== X-Gm-Message-State: ACrzQf0u9gDzlovWgEOjl8qhol+DZvoLsSbxoXcqESQhiZ4uEPHBwpOf iZFfZdhhh9qyYL8x2irH2ijxe7MktY0= X-Google-Smtp-Source: AMsMyM7WkBJKm99iO2hP3JDTCnaaPf4g5zsymKBXsVebZGrcUi+sqmTqFHx8/Ef2sO+ywdppcYWACw== X-Received: by 2002:a05:600c:154e:b0:3b4:bf17:32fc with SMTP id f14-20020a05600c154e00b003b4bf1732fcmr8210119wmg.70.1664393266723; Wed, 28 Sep 2022 12:27:46 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id r7-20020adfda47000000b0021e51c039c5sm4841610wrl.80.2022.09.28.12.27.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 12:27:45 -0700 (PDT) Subject: Re: [PATCH] Fix GDB build: ELF support check & -lzstd (was: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections) To: Simon Marchi , Fangrui Song , Tom Tromey Cc: Fangrui Song via Gdb-patches References: <20220923040837.550160-1-maskray@google.com> <87o7v0zo4b.fsf@tromey.com> From: Pedro Alves Message-ID: <7af42dd5-71fe-5591-3f8c-22aef0ea9d08@palves.net> Date: Wed, 28 Sep 2022 20:27:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2022 19:27:50 -0000 On 2022-09-28 8:00 p.m., Simon Marchi wrote: > On 9/28/22 07:52, Pedro Alves wrote: >> Note how above, in the gcc command line, "-lzstd" appears before >> "-lbfd". That explain the link failure. It should appear after, like >> -lz does. >> >> This commit fixes it, by moving ZSTD_LIBS from LDFLAGS to LIBS, next >> to -lz, in GDB_AC_CHECK_BFD, and regenerating gdb/configure. >> >> Change-Id: I1f4128dde634e8ea04c9002904f1005a8b3a6863 >> --- >> gdb/acinclude.m4 | 4 ++-- >> gdb/configure | 8 ++++---- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 >> index 28846119dcb..62fa66c7af3 100644 >> --- a/gdb/acinclude.m4 >> +++ b/gdb/acinclude.m4 >> @@ -234,9 +234,9 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ >> # always want our bfd. >> CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS" >> ZLIBDIR=`echo $zlibdir | sed 's,\$(top_builddir)/,,g'` >> - LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $ZSTD_LIBS $LDFLAGS" >> + LDFLAGS="-L../bfd -L../libiberty $ZLIBDIR $LDFLAGS" >> intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` >> - LIBS="-lbfd -liberty -lz $intl $LIBS" >> + LIBS="-lbfd -liberty -lz $ZSTD_LIBS $intl $LIBS" >> AC_CACHE_CHECK( >> [$1], >> [$2], > > LGTM. Someone opened a bug about this: > > https://sourceware.org/bugzilla/show_bug.cgi?id=29630 Thanks. I added a Bug: tag and pushed it.