From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74301 invoked by alias); 19 Sep 2017 14:35:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74292 invoked by uid 89); 19 Sep 2017 14:35:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Sep 2017 14:35:34 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF6B77EA91; Tue, 19 Sep 2017 14:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DF6B77EA91 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3046760E3B; Tue, 19 Sep 2017 14:35:31 +0000 (UTC) Subject: Re: [PATCH v3] Add a 'starti' command. To: John Baldwin , gdb-patches@sourceware.org References: <20170911220803.73819-1-jhb@FreeBSD.org> From: Pedro Alves Message-ID: <7b165874-88ec-0ef2-50c5-9eb7b19eeb53@redhat.com> Date: Tue, 19 Sep 2017 14:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170911220803.73819-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00466.txt.bz2 Hi John, This looks good to me, with a couple minor nits below. On 09/11/2017 11:08 PM, John Baldwin wrote: > > -/* Implement the "run" command. If TBREAK_AT_MAIN is set, then insert > - a temporary breakpoint at the begining of the main program before > - running the program. */ > +/* Determine how the new inferior will behave. */ > + > +enum run_how { { goes on next line. > + /* Do not create any breakpoint. */ I wonder about tweaking this comment to avoid talking about breakpoints, since this enum is not really strictly about breakpoints anymore. > + RUN_NORMAL, > + > + /* Stop at the beginning of the program's main function. */ > + RUN_STOP_AT_MAIN, > + > + /* Stop at the first instruction of the program. */ > + RUN_STOP_AT_FIRST_INSN > +}; > + > +/* This help string is used for the run, start, and starti commands. > + It is defined as a macro to prevent duplication. */ > + > +#define RUN_ARGS_HELP \ > +"You may specify arguments to give it.\n\ > +Args may include \"*\", or \"[...]\"; they are expanded using the\n\ > +shell that will start the program (specified by the \"$SHELL\"\ > +environment\nvariable). Input and output redirection with \">\",\ > +\"<\", or \">>\"\nare also allowed.\n\n\ You have a "\n" in the middle of some lines above. Was that intended? I'd expect to see instead lines broken at \n, ending with \n\ . > +With no arguments, uses arguments last specified (with \"run\" \ > +or \"set args\").\n\ > +To cancel previous arguments and run with no arguments,\n\ > +use \"set args\" without arguments.\n\ > +To start the inferior without using a shell, use \"set \ > +startup-with-shell off\"." > + > diff --git a/gdb/testsuite/gdb.base/starti.c b/gdb/testsuite/gdb.base/starti.c > new file mode 100644 > index 0000000000..dc098fe8aa > --- /dev/null > +++ b/gdb/testsuite/gdb.base/starti.c > @@ -0,0 +1,30 @@ > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include This isn't necessary, AFAICS. > + > +int x; > + > +__attribute__((constructor)) void ctor() > +{ > + x = 1; > +} > + > +int main() > +{ > + return 0; > +} Space before parens, line break after return type. We follow GNU convention in tests too, unless different syntax is relevant for the test. Thanks, Pedro Alves