From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 93EDF384E7A7 for ; Mon, 12 Dec 2022 20:19:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93EDF384E7A7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 206-20020a1c02d7000000b003d1e906ca23so204506wmc.3 for ; Mon, 12 Dec 2022 12:19:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:subject:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5IFVdAB4BIqSY/CpCF2KDlbrrJwzlxuHzIzSYKbJVB4=; b=mbh/SgeVeXyAaqq0kgtBiabhEzDDrB1pjI848kR7/3j0gxwpoJJjnFDNBDx3caJD2N rcEtUXB2ya7YFsZ1D3OOZFxm+n0LggjRwpkXPNfixRVgjT0Y7GeRhwbpV2AJ2UJig6PT R5GqO4Nfw5WxvHSR0lqijMfMRfNng7xWAbb1WS3pNFoxmiCfkJQ86s6T2bDJ+2jipKML fVTosuk9uYkYK4O8DwT2EbZ/C8puxWz3pgUW4nZmBlEewvSyr2hcby46YNV3jqhpuW0h KQxPv+pLSYnCOLqqt7O+MA31R8g0bn/nFJ/Dsxy4fdnQhM6VaIcERLV4m53IJj7hwma6 SUGg== X-Gm-Message-State: ANoB5pl/LQTdZYBRfAYRs5MzY/MUyMQ6DQSwn16gjrpb3VG3AM4THwvA 21zi2+SNiFZ8aZIlUiL5n5Fdxj15o/IphA== X-Google-Smtp-Source: AA0mqf6pwteIQ/2zwZJC89mcqLKLduJQy/DfIkfhYaQ21c3XORHf4dJwIHhx2I7CDcQwjBm1CPCZqg== X-Received: by 2002:a05:600c:4e07:b0:3c6:e63e:23b with SMTP id b7-20020a05600c4e0700b003c6e63e023bmr13453834wmq.18.1670876391409; Mon, 12 Dec 2022 12:19:51 -0800 (PST) Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id n22-20020a05600c3b9600b003cfd0bd8c0asm11437407wms.30.2022.12.12.12.19.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:19:51 -0800 (PST) From: Pedro Alves Subject: Re: [PATCH v2 00/29] Step over thread clone and thread exit To: Tom de Vries , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> Message-ID: <7b222a88-3e78-7618-515b-fde0c16070cd@palves.net> Date: Mon, 12 Dec 2022 20:19:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-03 2:46 p.m., Tom de Vries wrote: > On 7/14/22 00:24, Pedro Alves wrote: >> Tested on x86-64 Ubuntu 20.04, native and gdbserver. >> > > FYI, I applied on the base commit, and tried to build (with --enable-targets=all), and ran into: > ... > /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:1097:64: error: no matching function for call to ‘displaced_step_buffers::finish(gdbarch*&, thread_info*&, gdb_signal&)’ >    return per_inferior->disp_step_buf->finish (arch, thread, sig); >                                                                 ^ > ... > and: > ... > /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:8353:72: error: invalid conversion from ‘displaced_step_finish_status (*)(gdbarch*, thread_info*, gdb_signal)’ to ‘displaced_step_finish_status (*)(gdbarch*, thread_info*, const target_waitstatus&)’ [-fpermissive] >    set_gdbarch_displaced_step_finish (gdbarch, ppc_displaced_step_finish); >                                                                         ^ > ... Thanks, Tom. Classical mistake to miss --enable-targets=all. I've fixed this.