From: Simon Marchi <simon.marchi@polymtl.ca>
To: John Darrington <john@darrington.wattle.id.au>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb: Added builtin types for 24 bit integers.
Date: Thu, 23 Aug 2018 19:41:00 -0000 [thread overview]
Message-ID: <7b7853c6462d8806bc4a2a743330a382@polymtl.ca> (raw)
In-Reply-To: <20180823173526.26144-1-john@darrington.wattle.id.au>
On 2018-08-23 13:35, John Darrington wrote:
> * gdb/gdbtypes.h (struct builtin_type): New members builtin_int24
> and builtin_uint24;
> * gdb/gdbtypes.c: Initialize them.
> * gdb/doc/gdb.texinfo: Add them.
> ---
> gdb/doc/gdb.texinfo | 2 ++
> gdb/gdbtypes.c | 4 ++++
> gdb/gdbtypes.h | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 5068c0ac81..e4ecd57a9e 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -42379,6 +42379,7 @@ Boolean type, occupying a single bit.
>
> @item int8
> @itemx int16
> +@itemx int24
> @itemx int32
> @itemx int64
> @itemx int128
> @@ -42386,6 +42387,7 @@ Signed integer types holding the specified
> number of bits.
>
> @item uint8
> @itemx uint16
> +@itemx uint24
> @itemx uint32
> @itemx uint64
> @itemx uint128
> diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
> index 65b1211ec4..05bf7b1134 100644
> --- a/gdb/gdbtypes.c
> +++ b/gdb/gdbtypes.c
> @@ -5402,6 +5402,10 @@ gdbtypes_post_init (struct gdbarch *gdbarch)
> = arch_integer_type (gdbarch, 16, 0, "int16_t");
> builtin_type->builtin_uint16
> = arch_integer_type (gdbarch, 16, 1, "uint16_t");
> + builtin_type->builtin_int24
> + = arch_integer_type (gdbarch, 24, 0, "int24_t");
> + builtin_type->builtin_uint24
> + = arch_integer_type (gdbarch, 24, 1, "uint24_t");
> builtin_type->builtin_int32
> = arch_integer_type (gdbarch, 32, 0, "int32_t");
> builtin_type->builtin_uint32
> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index 14059ab3dc..eb7c365b71 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -1611,6 +1611,8 @@ struct builtin_type
> struct type *builtin_uint8;
> struct type *builtin_int16;
> struct type *builtin_uint16;
> + struct type *builtin_int24;
> + struct type *builtin_uint24;
> struct type *builtin_int32;
> struct type *builtin_uint32;
> struct type *builtin_int64;
Hi John,
It's always useful to have a little commit message along with the patch
to explain why this is needed. What's your problem and how does it help
you solve it. Could you expand a bit on your patches?
Thanks,
Simon
next prev parent reply other threads:[~2018-08-23 19:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 17:35 John Darrington
2018-08-23 17:35 ` [PATCH 3/3] GDB: New target s12z John Darrington
2018-08-23 17:56 ` Eli Zaretskii
2018-08-26 17:19 ` Simon Marchi
2018-08-26 17:41 ` John Darrington
2018-08-26 18:16 ` Simon Marchi
2018-08-26 22:55 ` Simon Marchi
2018-08-27 6:30 ` John Darrington
2018-08-27 12:54 ` Simon Marchi
2018-08-28 15:35 ` Tom Tromey
2018-08-23 17:35 ` [PATCH 2/3] GDB: Add support for 24 bit addresses John Darrington
2018-08-24 20:34 ` Simon Marchi
2018-08-25 4:56 ` John Darrington
2018-08-23 17:55 ` [PATCH 1/3] gdb: Added builtin types for 24 bit integers Eli Zaretskii
2018-08-23 19:41 ` Simon Marchi [this message]
2018-08-23 20:04 ` John Darrington
2018-08-23 20:35 ` Simon Marchi
2018-08-24 6:11 ` John Darrington
2018-08-24 15:09 ` Simon Marchi
2018-08-24 15:29 ` John Darrington
2018-08-24 20:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7853c6462d8806bc4a2a743330a382@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).