From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82657 invoked by alias); 23 Aug 2018 19:41:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82215 invoked by uid 89); 23 Aug 2018 19:41:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Aug 2018 19:41:19 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7NJfDOg003559 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Aug 2018 15:41:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 366911EB3B; Thu, 23 Aug 2018 15:41:13 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8577A1E52D; Thu, 23 Aug 2018 15:41:11 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Aug 2018 19:41:00 -0000 From: Simon Marchi To: John Darrington Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb: Added builtin types for 24 bit integers. In-Reply-To: <20180823173526.26144-1-john@darrington.wattle.id.au> References: <20180823173526.26144-1-john@darrington.wattle.id.au> Message-ID: <7b7853c6462d8806bc4a2a743330a382@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00579.txt.bz2 On 2018-08-23 13:35, John Darrington wrote: > * gdb/gdbtypes.h (struct builtin_type): New members builtin_int24 > and builtin_uint24; > * gdb/gdbtypes.c: Initialize them. > * gdb/doc/gdb.texinfo: Add them. > --- > gdb/doc/gdb.texinfo | 2 ++ > gdb/gdbtypes.c | 4 ++++ > gdb/gdbtypes.h | 2 ++ > 3 files changed, 8 insertions(+) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 5068c0ac81..e4ecd57a9e 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -42379,6 +42379,7 @@ Boolean type, occupying a single bit. > > @item int8 > @itemx int16 > +@itemx int24 > @itemx int32 > @itemx int64 > @itemx int128 > @@ -42386,6 +42387,7 @@ Signed integer types holding the specified > number of bits. > > @item uint8 > @itemx uint16 > +@itemx uint24 > @itemx uint32 > @itemx uint64 > @itemx uint128 > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index 65b1211ec4..05bf7b1134 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -5402,6 +5402,10 @@ gdbtypes_post_init (struct gdbarch *gdbarch) > = arch_integer_type (gdbarch, 16, 0, "int16_t"); > builtin_type->builtin_uint16 > = arch_integer_type (gdbarch, 16, 1, "uint16_t"); > + builtin_type->builtin_int24 > + = arch_integer_type (gdbarch, 24, 0, "int24_t"); > + builtin_type->builtin_uint24 > + = arch_integer_type (gdbarch, 24, 1, "uint24_t"); > builtin_type->builtin_int32 > = arch_integer_type (gdbarch, 32, 0, "int32_t"); > builtin_type->builtin_uint32 > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index 14059ab3dc..eb7c365b71 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -1611,6 +1611,8 @@ struct builtin_type > struct type *builtin_uint8; > struct type *builtin_int16; > struct type *builtin_uint16; > + struct type *builtin_int24; > + struct type *builtin_uint24; > struct type *builtin_int32; > struct type *builtin_uint32; > struct type *builtin_int64; Hi John, It's always useful to have a little commit message along with the patch to explain why this is needed. What's your problem and how does it help you solve it. Could you expand a bit on your patches? Thanks, Simon