From: Peter Bergner <bergner@vnet.ibm.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Disallow 3-operand cmp[l][i] for ppc64
Date: Thu, 29 Sep 2016 21:21:00 -0000 [thread overview]
Message-ID: <7b7f12a0-4317-3968-25d5-0704cfc40632@vnet.ibm.com> (raw)
In-Reply-To: <20160929060240.GD4877@bubble.grove.modra.org>
On 9/29/16 1:02 AM, Alan Modra wrote:
> cmp[l][o] get an optional L field only when generating 32-bit code.
> dcbf, tlbie and tlbiel keep their optional L field, ditto for R field
> of tbegin. cmprb, tsr., wlcr[all] and mtsle all change to a
> compulsory L field.
FYI, I just committed the following as obvious to clean up the gdb
testsuite fallout from this change.
Peter
* gdb.arch/powerpc-power.exp <cmprb>: Update tests to account for
the compulsory L operand changes.
* gdb.arch/powerpc-power.s: Likewise.
diff --git a/gdb/testsuite/gdb.arch/powerpc-power.exp b/gdb/testsuite/gdb.arch/powerpc-power.exp
index 3bdfc15..8594ad5 100644
--- a/gdb/testsuite/gdb.arch/powerpc-power.exp
+++ b/gdb/testsuite/gdb.arch/powerpc-power.exp
@@ -1117,8 +1117,8 @@ func_check +4168 "xvxsigdp vs59,vs60"
func_check +4172 "xvxsigsp vs60,vs61"
func_check +4176 "cmpeqb cr0,r6,r7"
func_check +4180 "cmpeqb cr7,r6,r7"
-func_check +4184 "cmprb cr0,r8,r9"
-func_check +4188 "cmprb cr7,r8,r9"
+func_check +4184 "cmprb cr0,0,r8,r9"
+func_check +4188 "cmprb cr7,0,r8,r9"
func_check +4192 "cmprb cr0,1,r8,r9"
func_check +4196 "cmprb cr7,1,r8,r9"
func_check +4200 "setb r15,cr0"
diff --git a/gdb/testsuite/gdb.arch/powerpc-power.s b/gdb/testsuite/gdb.arch/powerpc-power.s
index 507b61e..6fe2520 100644
--- a/gdb/testsuite/gdb.arch/powerpc-power.s
+++ b/gdb/testsuite/gdb.arch/powerpc-power.s
@@ -1078,8 +1078,8 @@ func:
.long 0xf389ef6f /* <+4172>: xvxsigsp vs60,vs61 */
.long 0x7c0639c0 /* <+4176>: cmpeqb cr0,r6,r7 */
.long 0x7f8639c0 /* <+4180>: cmpeqb cr7,r6,r7 */
- .long 0x7c084980 /* <+4184>: cmprb cr0,r8,r9 */
- .long 0x7f884980 /* <+4188>: cmprb cr7,r8,r9 */
+ .long 0x7c084980 /* <+4184>: cmprb cr0,0,r8,r9 */
+ .long 0x7f884980 /* <+4188>: cmprb cr7,0,r8,r9 */
.long 0x7c284980 /* <+4192>: cmprb cr0,1,r8,r9 */
.long 0x7fa84980 /* <+4196>: cmprb cr7,1,r8,r9 */
.long 0x7de00100 /* <+4200>: setb r15,cr0 */
next parent reply other threads:[~2016-09-29 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160929060240.GD4877@bubble.grove.modra.org>
2016-09-29 21:21 ` Peter Bergner [this message]
2016-09-30 1:17 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7f12a0-4317-3968-25d5-0704cfc40632@vnet.ibm.com \
--to=bergner@vnet.ibm.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).