From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by sourceware.org (Postfix) with ESMTPS id BDFFE38582B5 for ; Tue, 26 Jul 2022 13:00:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDFFE38582B5 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=esgOWKanO5jCb3FtCT9IRcpysmiU0TaTaTgZg7NDXzUyQ4/BqT+sF8/nqaNgcBtZgS/uaWAvQkwTDYB4UpSkl2H0gJvlU30qp8YdL2D4YeDdeVm1Ru6h9JISml672Ne1g0iH3LNnMkJntGKq7Dsn7ulQLJMLeafaHGgiCfUCyw8fQFzua7Lxns4WxzBeN/Iic3HhCO/5oIh1gW431LC2/Axno0XoIoJZR65Nv14OT+gP5Uid4Ge37CMGUYdib6kGMTIYsWFbZt96BECmuEqU+3B0+f6GjX9dpVctjCSQznxizpq3EhRTSQnFOXYfbd3UIX1t2JZZhndxnjEqYV6DFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1hq6/U75Aih2J6KZk9q4/aZlXnIkLc7JlCkAcdQeYw=; b=LgK8wZcb0ZJetArPVg6BNINzaORQ5Om9O2ZoU4mOVHqN3hnJwkOYriQ1jnIb7FgzTfnZ2LfrnaX2X/Y7Na8Gqim7A04a3s0+91E7cWcp9/HWrMujXB21IqvFmozeK/k6dFm4gA4D/XcGGREajWIO5juUSKa635aZitUzmvbAYorf1Z93D+RfW3bakv9S3DRuTJ0sX0Iedzp0tork8uLtOlq2QX2/TOvEcNk4Yy9MwR9i0rU4aZNSEdDcyaZqb7fbdFF+OKd2YtB8XHcfSGHmnIEYOwCIqchDS0pZqIa0YHHoSHOOOC+RB+u/mS4A9+OvYscQIrZf0Ui+u2jCLmbk0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB3PR08CA0019.eurprd08.prod.outlook.com (2603:10a6:8::32) by DB4PR08MB8176.eurprd08.prod.outlook.com (2603:10a6:10:380::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 12:59:58 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::16) by DB3PR08CA0019.outlook.office365.com (2603:10a6:8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Tue, 26 Jul 2022 12:59:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 12:59:58 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Tue, 26 Jul 2022 12:59:58 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c71f9865b72d5797 X-CR-MTA-TID: 64aa7808 Received: from 5618006048a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 492A0665-1B8A-44E4-B297-E76BC2E1463A.1; Tue, 26 Jul 2022 12:59:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5618006048a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 12:59:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jdRQe3KLBLLT5ApM+yg8So5MVhwYhOo/ncIArlGPyKYM0FLI3FKkWdCoaO+JBSICIBHi44+5nv0ptudE1MhezoPpQCW42NZW5X1xsKvl0BfttrFJQUMNdVuwlZbuRH/kBckYoniBrfMTXIhrE3SFoDOsOO56oKxryf15cSu0dsxl2UCEkLcGIMhU464rcQ1mHkOKIjsJ2xMYjY8+3hMtr7AOoFsEKZbRvkpz9o+icr8H4e2OvOSSOsGot/lducAI0wK/yX45hvYc3ju/jpudr3EH5eU2FookHKB+ApCcd+DksOEKqaUL0sQhcfRzQCOcmzCUr+skGWbYfY2gtfpXqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1hq6/U75Aih2J6KZk9q4/aZlXnIkLc7JlCkAcdQeYw=; b=VlXOE+++y5cyEtBsimO0pT/xGK+az2cNPwFHHc1RAhI4+cg48fqvVU8BZfRP9fFDWhOMLHBhaR40SG1jK1hmT/UVar25TjayqB3OOoUm1XVu8cuiHCMHy8I5q1+32n+V1+FUOSCVcTIiGR2+8zKX6CrL6qwDSeeijVU/Jln84SV6vcMEXIyZSU4gHOJlEnS+sU1Z1akOIhnDwkSTB0clA3qlSq2hIL5Nubocufn0lC53355U4YycC4djNnji3DqSXFN4Jr4x431Vt4I8eWS31nH78PYQg5VKOCrWmHPQafgLnP2HaMBOL7Dk4g/XtDWG48cXnZeg/o1TEjMrtwb5Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM9PR08MB6967.eurprd08.prod.outlook.com (2603:10a6:20b:416::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 12:59:50 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 12:59:50 +0000 Message-ID: <7b9c0be4-bbe7-2ff9-b3cf-69003789c872@arm.com> Date: Tue, 26 Jul 2022 13:59:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org Cc: Andrew Burgess References: <20220726113024.GA17827@delia.home> From: Luis Machado In-Reply-To: <20220726113024.GA17827@delia.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::11) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 12f968f7-415d-462b-f4c2-08da6f06bec0 X-MS-TrafficTypeDiagnostic: AM9PR08MB6967:EE_|DBAEUR03FT033:EE_|DB4PR08MB8176:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1m7B7GRUeFJucRsyOHVridAFT3Vj4l8JePnMD3rdZn72LrBE8h73ZiH2b2xsnX6irEuajSkSY32Ib21zkwwoPSWtL+uWpYATBF6yrhS0wbiOdJplYFaK4nC8QT9kvPDuY94O0izY79yZPJI5wwqXe1sAT2Z68OpBOInvVQnF9Q9m2dPlxuZLBpaek0QU34aNufmXx9s6u9sKNpEu95PVR8dnP8JlWVopgSOybxjYir+OhTsPQnKnZNKmYh3Gr/PNiBfun+3wQPaaP/3L48N4vhtT6rVoHzsixy9M0vfttlNhkeXAYKE+rNWhChx6i52RnBtgnhvYpdRO1EgWMPrW0qVZ1+LfgtTxLVAHC6t3yDSJ3UZL00yM6303bZ/ZVwGyMLM18UJni+lU6Vt4Hs/cbXj2VvV9jV5zXFjTV017vKTKM0fBpIFa7lMTTLwNAb0rFEuNS77GnUTIkra/UXt565kScE9XwpdKEwJ4yYAUvG9HpxUVnw1fgpxyV6gtP3vs5VEhDhsv1Q80k1jDxJTy2/lMbs+t6VTsk0iRurAUVc3++XyFhNQp1yw2P2moEltH/3hpnlJ18PpxBVpBML7MjX/iCJ+4kbB5UYoZASiZ0C9yGgBeTX3kAi7NQKoC6TL04XSJSUsNFRUsZle1xtB1+Wuv4P9s9DcJRP9s7YeAVCYBTtQIblOZjZzTChJuDkTBppAbMcU6jJP1pBMC44trsLM1N9mPkLK8QUNNCvcBO/uyc0iOs4Hvoy8htKRY/SMo4uUJd44yfsOalvrUeKw+QsVj/yLQOFq8uu8sbm2HvyzTAFZnEmd+o1mAP07pXaG5G6EOitewyTRKDiXdEmX0Vh7+xVRIVjFJhE/4MThXDxo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(39860400002)(366004)(346002)(2616005)(6486002)(6512007)(26005)(478600001)(8936002)(31696002)(84970400001)(86362001)(44832011)(41300700001)(83380400001)(2906002)(53546011)(5660300002)(186003)(31686004)(6506007)(316002)(38100700002)(36756003)(8676002)(4326008)(66946007)(66556008)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6967 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6833571c-62cd-457c-12aa-08da6f06b970 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ameMRbe0lPTDODIURjNY8EsmTI8jQ4PZ8qofqjKhg5IpKIvgzc+jd0TRsPhRiEbxxGDSzqHNzR15rK4OuvHv54/Udz/4FDwTmN+adKtHw1GxBvSW/LyIqjcnnEpMq4GgqG2r9jlfLQSAy1q535N8pwX/VUBRkTSLljqi+/ishPPxx5Bl8AFub3J2+6EbC8ajtOKZ4FOVgwXnuByxifZY10SvlmWdQKNJoWAQDYKlGfo1T9ssOCtbq2rGlfZH312tJO2kMhosuFj3WfFJhkVRQOksufPsyTfMq7xhMvjIBs9hUWH+pQA2K16/Fwkv6JMvLlxC760rONxTJ6YqhLNJLoEIx5q103YWaKuXR9txsU4xK5jkuCWOo8VoPrdyydHKY2iVMzX6mkxBdX/ld6X4Jor93L841FFJacKmG9f0h8EFyux1GeANGfz3YSbMyAwSbt2sq/cLMfPFrGiEFMbg7Upd58nhBucMtewNHzNtTRgypPvfCgzEZTGGQw8AmJnLQfm02cfqPNuA4134X4NHIgM9fpFaBZGYIz2E3ddu9LcOUJqTgS8/tQtVU1kxE1yTiAeCOl8GQOQbPkvbPBknb392+6ZFF3zfC2dYoSEXNxZ2IlhE5FVhDo/sXZHDZ3M5m6LS31hNvxKgzIAscDYGfmBRMoFVJGLEzvLrIsmZA+K2uXI2o2ov1wczKngw+AEJbZDjEA6UoMCu0v+7EkL7GeLck+/FZg/dtJZ3DEIVk3CJFsRytOEQ6iPBr9LTSvFKXihPqL8BQGwWIZv+s4mkc1oDdPLcMPCx74au8BznBiZGDtrikaiPJDfizUigwXIsMmpmckAsRQEum/GU6NqyYEDCAJkKRhdxodA+TM4Xx8eGGZ+gjEJuzUDE5FmNooQm X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(396003)(39860400002)(376002)(40470700004)(46966006)(36840700001)(356005)(6486002)(5660300002)(81166007)(336012)(83380400001)(82310400005)(8936002)(6512007)(82740400003)(84970400001)(478600001)(31686004)(47076005)(36756003)(186003)(86362001)(31696002)(316002)(2906002)(107886003)(8676002)(2616005)(44832011)(4326008)(70586007)(40480700001)(6506007)(36860700001)(53546011)(26005)(70206006)(41300700001)(40460700003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 12:59:58.6993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12f968f7-415d-462b-f4c2-08da6f06bec0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8176 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 13:00:04 -0000 On 7/26/22 12:30, Tom de Vries via Gdb-patches wrote: > Hi, > > When running test-case gdb.opt/inline-small-func.exp with clang 12.0.1, I run > into: > ... > gdb compile failed, /usr/bin/ld: inline-small-func0.o: in function `main': > inline-small-func.c:21: undefined reference to `callee' > clang-12.0: error: linker command failed with exit code 1 \ > (use -v to see invocation) > UNTESTED: gdb.opt/inline-small-func.exp: failed to prepare > ... > > Fix this by using __attribute__((always_inline)). > > Tested on x86_64-linux. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Fix gdb.opt/inline-small-func.exp with clang > > --- > gdb/testsuite/gdb.opt/inline-small-func.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.opt/inline-small-func.h b/gdb/testsuite/gdb.opt/inline-small-func.h > index 66323952cf4..44b6e86fc15 100644 > --- a/gdb/testsuite/gdb.opt/inline-small-func.h > +++ b/gdb/testsuite/gdb.opt/inline-small-func.h > @@ -13,9 +13,15 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > +#ifdef __GNUC__ > +#define ATTR __attribute__((always_inline)) > +#else > +#define ATTR > +#endif > + > int counter = 42; > > -inline void > +inline ATTR void > callee () { > counter = 0; /* callee: body. */ > } The above looks good to me.