public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Gerrit status update
Date: Fri, 06 Dec 2019 00:14:00 -0000	[thread overview]
Message-ID: <7bacce91-fcb6-a096-dda4-1b77be539320@linaro.org> (raw)
In-Reply-To: <93b1726e-d5d9-f264-4efc-79b0cdb034aa@polymtl.ca>

On 11/22/19 6:58 PM, Simon Marchi wrote:
> Hi all,
> 
> We had a discussion on IRC yesterday about the shortcomings of Gerrit
> for our workflow.  I'd like to share what was discussed, but also give
> a chance to those who are not on IRC to have a voice.

Thanks.

> 
> The two main problems of Gerrit, when applied to our current workflow,
> are related to patch series.  While it is possible to upload a sequence
> of changes, it is not possible to treat a sequence of changes as a
> logical patch series.  And therefore:
> 
> - It is not possible to attach a cover letter to a series.
> - The email notifications are not threaded like a series would.  It's
>    basically impossible to follow a series by email, as each patch will
>    have its own little thread.
> 
I went through yours and Tom's e-mail, but also found glibc's take on it 
(https://sourceware.org/ml/libc-alpha/2019-11/msg00774.html).

Carlos pointed out a possible way to have a cover letter, and apparently 
that is more or less the recommended way of doing it.

It seems to me the biggest issue is having gerrit translated properly to 
e-mail format, both in terms of interaction and organization of replies 
(threaded series etc).

On the positive side i think gerrit provides quite a few useful features 
to speed up the process of submission and reviewing of patches, which 
people have already pointed out. So i won't list those here.

Considering the drawbacks of gerrit seem to be mostly concentrated 
around series of patches, maybe bigger series in particular, should we 
try and do those through e-mail instead. Maybe as a recommendation?

For other smaller contributions, gerrit still seems to be fairly useful.

As for patchwork, my experience using it in the past wasn't that great. 
It may have improved since then, but i remember it simply being 
forgotten over time, and patches piling up anyway.

  parent reply	other threads:[~2019-12-06  0:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 21:58 Simon Marchi
2019-11-23  0:25 ` Tom Tromey
2019-12-06 16:44   ` Simon Marchi
2019-12-06  0:14 ` Luis Machado [this message]
2019-12-06 16:19   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bacce91-fcb6-a096-dda4-1b77be539320@linaro.org \
    --to=luis.machado@linaro.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).