From: Simon Marchi <simark@simark.ca>
To: Mihails Strasuns <mihails.strasuns@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v5 4/5] [gdb/testsuite] define jit function name via macro
Date: Mon, 11 May 2020 20:31:54 -0400 [thread overview]
Message-ID: <7c0993c7-659d-f0a4-1288-25bca2952566@simark.ca> (raw)
In-Reply-To: <20200511102855.4987-4-mihails.strasuns@intel.com>
On 2020-05-11 6:28 a.m., Mihails Strasuns via Gdb-patches wrote:
> Replaces previous approach with patching resulting ELF binary after
> loading - now that each test iteration works on a separately compiled
> binary it is not necessary anymore.
>
> Tests are still being ran without debug info to preserve original test
> functionality but this change opens up the possibility to enable debug
> info if needed too.
This LGTM as is. It really removes a layer of hackiness, many thanks!
Simon
next prev parent reply other threads:[~2020-05-12 0:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167782>
2020-05-11 10:28 ` [PATCH v5 1/5] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-05-11 10:28 ` [PATCH v5 2/5] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-05-12 0:23 ` Simon Marchi
2020-05-11 10:28 ` [PATCH v5 3/5] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-05-12 0:28 ` Simon Marchi
2020-05-11 10:28 ` [PATCH v5 4/5] [gdb/testsuite] define jit function name via macro Mihails Strasuns
2020-05-12 0:31 ` Simon Marchi [this message]
2020-05-11 10:28 ` [PATCH v5 5/5] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-05-12 0:37 ` Simon Marchi
2020-05-12 0:17 ` [PATCH v5 1/5] [gdb/testsuite] use args as lib list for jit-elf tests Simon Marchi
2020-05-12 7:51 ` Strasuns, Mihails
2020-05-12 14:13 ` Simon Marchi
2020-05-12 14:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c0993c7-659d-f0a4-1288-25bca2952566@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).