From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id 42FD13858C53 for ; Wed, 20 Apr 2022 11:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42FD13858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id 123-20020a1c1981000000b0038b3616a71aso1021479wmz.4 for ; Wed, 20 Apr 2022 04:31:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=Okh21IWHbjMuOXhenMbFsSx8/R7CxJUMiJZiaLEGatk=; b=5MyobvUeChRNEs/FaHbTt+0/KCa5knSsB7Rj4xhjbXpSHdKlpHmNPv1qMYzSeA2E7n GYoVKf/IfXj4dUb5rskc1uIgamU3gWCeKMN/DzdhuWXg3UZvoJkYlQs11tM25QpZX7HK fIiPhpXh4qnKmn3R020ojPwNKdc7WkEowWEdpzzsbnC6592u2cxh767jirf/nIaNUXY2 Pl0hVs4hRli1rE5hjbkk7y+OlBQF74v0sTA3Fk5TyTUh4cZxr+nBOXWPOzsMC4+oCgV4 9j0rbwuKpB3f1wYH6xr2TuQi0kv3eQ9yBbthYo0xXRHgSUTz4jJcSvlzB8pigcWwjk6F ijCQ== X-Gm-Message-State: AOAM532NdRcWRtB12swSvqjSL5EflK8RwI4SNR6QyvGjw2yqOTrVSDDr yPiQgYySAPwajkf7/g6gUwrqnpBwCz0= X-Google-Smtp-Source: ABdhPJxmSueD7dE1AFxj5iYLAvLcQN97h/SPt0DsX+5YNwwOF787VxwDZMx17eM8fV8Dsq/D5ZqdhQ== X-Received: by 2002:a05:600c:3c86:b0:392:990b:ae29 with SMTP id bg6-20020a05600c3c8600b00392990bae29mr3138586wmb.105.1650454272787; Wed, 20 Apr 2022 04:31:12 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id v11-20020adfa1cb000000b0020ab21e1e61sm830137wrv.51.2022.04.20.04.31.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Apr 2022 04:31:11 -0700 (PDT) Message-ID: <7c319441-067e-6f5c-cf80-84d696c9236e@palves.net> Date: Wed, 20 Apr 2022 12:31:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Content-Language: en-US From: Pedro Alves To: Christina Schimpe , gdb-patches@sourceware.org, Andrew Burgess References: <20220329131158.3970228-1-christina.schimpe@intel.com> <20220329131158.3970228-2-christina.schimpe@intel.com> <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net> In-Reply-To: <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 11:31:16 -0000 On 2022-04-18 20:01, Pedro Alves wrote: > > (gdb) show remote X-packet > Support for the 'p' packet on newly created remote targets is "disabled". > > and of course: > > (gdb) set remote X-packet disabled > "on", "off" or "auto" expected. > > > Also, BTW, err, why do we talk about the 'p' packet if the command is about > the X packet? That's busted. Seems like a preexisting issue in current master. I bisected this, and found out it was a regression introduced by this commit: 8579fd136a614985bd27f20539c7bb7c5a51287d is the first bad commit commit 8579fd136a614985bd27f20539c7bb7c5a51287d Author: Andrew Burgess Date: Mon Nov 8 14:58:46 2021 +0000 gdb/gdbsupport: make xstrprintf and xstrvprintf return a unique_ptr The motivation is to reduce the number of places where unmanaged pointers are returned from allocation type routines. All of the callers are updated. There should be no user visible changes after this commit. This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there.