From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0DE2C3858431 for ; Fri, 5 Apr 2024 12:21:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DE2C3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DE2C3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319707; cv=none; b=Y1uYLycc7jCKDagzVJ3tO8u6oD3HM/YYW9nTGw7bJhgHoLMLnqjUUwwOe9MRAn1dT1icxnE9IBsIayPiTCnqAvUfrl8s232yKfXMdoLQex9k7lDDqKYxFaT2FLSa8igkTIj8PEKZqtOiqOBmEC1UxlpI+SGV8GWBB7EApk9layM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712319707; c=relaxed/simple; bh=q5Ypfshjtbukzyo5yaGWYRKGeSzFDxoYGlooACKlAH4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=s5soeL8lukW1DTntos9jCPbwamP7Yorqqw5n+5Jb/tXJ0niTisNYl7s3UmLEjhOCPnBtOVszjJH1bkEb+1Sp1cQj3qCdAFqd+ZH/qyg76m+6i2957Eccia1MoUb6/bSjI0wM+tUPnH+poBOi42eGPCPn+uRRimiyhJ9Tnhv7eoQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712319700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=bTa01hdBeRgFK/hojnfPsASP5BQDx0SqvpP2/VXNDMD8V2zEBxSztsU2A60dCTnuYnVtv4 5VJZGiIwnxcmr4HJ0KSX6aqATHAWn64SFbHK/DK6Tj7pCjCbOOzkxoV7eHOEJhVUR/6446 BEhKaoj4ftzJ64r6Yz/8LG1t4xN8sDs= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-0G1Eiz03PpuYicMGWnV1Ew-1; Fri, 05 Apr 2024 08:21:39 -0400 X-MC-Unique: 0G1Eiz03PpuYicMGWnV1Ew-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-56bf76d4282so2148696a12.1 for ; Fri, 05 Apr 2024 05:21:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712319697; x=1712924497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ieCR6thRVKIZ43wfP1To80qff2k7bgX6sIs4sKEEMMw=; b=ry8K3KyEtiroWujGeEy2KOMDSr6YXzCLOLTqamvoIl05J37GmgjEf3MgQxaDY6YC9H rDhCBqsNbrbBa4n2SQP++Xtl2/I3D8S271RjjwuR2x48dTbOlMQL3fhpKAFClBuFCQbg SSkUP5lG4tSesVSJk5Cxr5pTrExrqIBolAajuJgOGL9WYBVl7qsm9DkACXN46diMgk7F yhs8am2VXFZB1A5r9Qj7UuMv301yZUV7JZdBdYJxPfNZCDGOq62T++4RgMCM+xTLIylp A4c2CwPt0GOARlPXaFaCqTZaNOzVFEtSMWiNGs8X+NjfgpVE0wZN5Vc1qq0VgIMfHd1y 544Q== X-Gm-Message-State: AOJu0Yxd9WvNsxXudMzIgel4co+3JJgVKIUhUtwti5JoBOYVHLQ1ggbG DpK2jMibgPqgSzEX0Bo0TdJiYgHLvszrVXWQ8AaVSQCY1wToIviEd6nmxYYXFObiBBPFBJ5ooa0 cr6VChts/OB00mx63ug6xV/03wfpOeoc2I3WffEOn91Ifb+AO2Cgze8xWxAdOHaSJ5lOVLOuwHl LLbzGfFdimpz616zHkjBzFerZ2afvY0yPJID8RQsWfulE= X-Received: by 2002:a50:f68b:0:b0:56d:f29d:c80d with SMTP id d11-20020a50f68b000000b0056df29dc80dmr1309357edn.5.1712319697083; Fri, 05 Apr 2024 05:21:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFggWW2ArZ9qr+Gj7WerSkzQqGTPJSkBZtLsAeAQEcYncHOZhquN8nBjzHz7r5yBGrDxo4ohw== X-Received: by 2002:a50:f68b:0:b0:56d:f29d:c80d with SMTP id d11-20020a50f68b000000b0056df29dc80dmr1309331edn.5.1712319696536; Fri, 05 Apr 2024 05:21:36 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id f15-20020a056402150f00b0056e2f1d9152sm662580edw.93.2024.04.05.05.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 05:21:36 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 3/4] gdb/Makefile: add some missing config.status dependencies Date: Fri, 5 Apr 2024 13:21:27 +0100 Message-Id: <7c64e75ac82b176db8bd4572ace865076851c36e.1712319537.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed that for the build targets jit-reader.h, gcore, gdb-gdb.py, and gdb-gdb.gdb the rules all use the config.status script, but don't have a dependency on the config.status target. This means we might fail to regenerate these targets in a case where config.status, or one of its dependencies changes. Two other targets that use config.status do correctly have a dependency on config.status. Fixed in this commit by adding the missing dependencies. There should be no changes in _what_ is generated after this commit. --- gdb/Makefile.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 9340becbdc9..c1b3144b175 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2313,16 +2313,16 @@ Makefile: Makefile.in config.status run: Makefile ./gdb$(EXEEXT) --data-directory=`pwd`/data-directory $(GDBFLAGS) -jit-reader.h: $(srcdir)/jit-reader.in +jit-reader.h: $(srcdir)/jit-reader.in config.status $(SHELL) config.status $@ -gcore: $(srcdir)/gcore.in +gcore: $(srcdir)/gcore.in config.status $(SHELL) config.status $@ -gdb-gdb.py: $(srcdir)/gdb-gdb.py.in +gdb-gdb.py: $(srcdir)/gdb-gdb.py.in config.status $(SHELL) config.status $@ -gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in +gdb-gdb.gdb: $(srcdir)/gdb-gdb.gdb.in config.status $(SHELL) config.status $@ config.h: stamp-h ; @true -- 2.25.4