From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 43D243858C66 for ; Mon, 6 Mar 2023 15:45:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D243858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 784F52235F; Mon, 6 Mar 2023 15:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678117545; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vRhL+hawBRf5eoRsKcUj0hHVNkBTpo4ACMTkbDaPx+E=; b=OJZ9mrXpjJTseMHXtMz8C9PF2eQ00+vHgOSYQ1GWxu/pGfuSw8+ab+G8Feaiohx/OWVg/P 6WvAHICKq0GBINeg2JIorSxebAh1qftE+PvG1UfeNGQfPL1VwsMCsH+QLrR2BBFbd7N+Hs rLWQ3ZU+I9Z+SG14mdKL7Yeu4Eo3BU4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678117545; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vRhL+hawBRf5eoRsKcUj0hHVNkBTpo4ACMTkbDaPx+E=; b=EsNNYB7Ijv72Qw0Rf8cIKY6iAO7lmfzokW4ws0naxlIybemDitFx0gwq4xGZTFnrvMusav q7pvA5RuHNes4+Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60E6A13513; Mon, 6 Mar 2023 15:45:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JR5VFqkKBmRqNgAAMHmgww (envelope-from ); Mon, 06 Mar 2023 15:45:45 +0000 Message-ID: <7c8370b8-f550-d61a-73dd-772e744425d0@suse.de> Date: Mon, 6 Mar 2023 16:45:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 4/4] [gdb/testsuite] Move gdb.base/gdb-caching-proc.exp to gdb.testsuite To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230304093549.8689-1-tdevries@suse.de> <20230304093549.8689-4-tdevries@suse.de> <87h6uy6in0.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87h6uy6in0.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/23 15:48, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> Test-case gdb.base/gdb-caching-proc.exp doesn't really test gdb, but it tests > Tom> the gdb_caching_procs in the testsuite, so it belongs in gdb.testsuite rather > Tom> than gdb.base. > > Tom> Move test-case gdb.base/gdb-caching-proc.exp to gdb.testsuite, renaming it to > Tom> gdb.testsuite/gdb-caching-proc-consistency.exp to not clash with > Tom> recently added gdb.testsuite/gdb-caching-proc.exp. > > Tom> Tested on x86_64-linux. > > I agree, seems fine, though I don't understand why it wasn't just > created there? The test-case gdb.base/gdb-caching-proc.exp was by added by this commit: ... commit 64d27cfc97f5b865019f0b7293ff2b9565db427c Author: Tom de Vries Date: Sat Dec 1 08:56:56 2018 +0100 ... The dir gdb.testsuite was added by this commit: ... commit 213fd9faf563ce5726ce66c8104cbaba44ba9c09 Author: Pedro Alves Date: Thu Jul 4 16:45:23 2019 +0100 ... In other words, the test-case wasn't created in gdb.testsuite because it predates gdb.testsuite. Thanks for the reviews, I'll commit shortly. Thanks, - Tom > Reviewed-By: Tom Tromey > > Tom