From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2054.outbound.protection.outlook.com [40.107.105.54]) by sourceware.org (Postfix) with ESMTPS id 72C0C3858D37 for ; Mon, 3 Apr 2023 09:13:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72C0C3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdYQCLBaid2f4KrZio2lRwSgQHmuKkpl+1G4WlBNUCk=; b=whTHt0jux4b4G58qpXkC/8z9SeQeLLVZYA+SO5ZeBf9OBS/w85JuJW4vMdWW06s/OwjDKd8jNF/B2nPdLCgDsCm7Ae3e4J5nXu8vaAwLkpJzgrdwMb8i/It8N7y7vakRZf5izeIoWzJMd9L4DSTtbg3guW7NR6ed2oW68MDFe8U= Received: from DU2PR04CA0234.eurprd04.prod.outlook.com (2603:10a6:10:2b1::29) by PAWPR08MB9686.eurprd08.prod.outlook.com (2603:10a6:102:2e2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.26; Mon, 3 Apr 2023 09:12:57 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::53) by DU2PR04CA0234.outlook.office365.com (2603:10a6:10:2b1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.43 via Frontend Transport; Mon, 3 Apr 2023 09:12:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.16 via Frontend Transport; Mon, 3 Apr 2023 09:12:57 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Mon, 03 Apr 2023 09:12:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b208ea172b1bab3a X-CR-MTA-TID: 64aa7808 Received: from 073b02998262.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 947CFB66-4B16-408B-87AE-846794133E00.1; Mon, 03 Apr 2023 09:12:50 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 073b02998262.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 03 Apr 2023 09:12:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OC7V4OLnDtinaaTmUVoYhwUHtiTlUAStI0OpTRfL7ge2W37SR3wlYa2o2PZ4WkS4YcO9kINK5qhFLHUxfBbWXSUZJNFHgjRCNzum8tp/+ENE4aH0OJh18L87if00qVj9mqluKb1XIy7JxdJAkwns0j8197hH4brJadiLRS6Jmg2RDPBHlzadoagqulAoUvcWKtHdQr0UpZ/jGgrQ4liWVov14mFPooTYNUJSTBAIb9alOl+Z9bK37rmZ83GKhLyIMUnRErxrGkLZPdhbCJPZeREHFiOz4D7S2Oqr5dBNL3RRGJ5aGQxkvUSPuf6m5t+crCXzY0iXscYzPQm5MHa7rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XdYQCLBaid2f4KrZio2lRwSgQHmuKkpl+1G4WlBNUCk=; b=m4+trWALOPImmxK3/8vQfsOUWYkx8yMPN63Kv1rM3Ol3OCImdad67AfTmEUZlrL2SqahLJfoiV/1cvU7BtGrGmOmdOvFD51kx3DqndIBQPMzUMxj7FjlyEPozUFSuSyHlsMCDXK7GC4g7JF3dcWnXfXNdxo1mOEfgiVjeK4j/f3/ysElorOMd35Q0KaljFIZlp7suDBxQi0p1ssucr2V6WWeF6SOrnM1SM7Q544mTgr9xwRURXQpV+tgS6qxSXchAmHoB0gxFviYnYj54Zavx7p3Fl8+BGvBfOKiNRyuo+P3bGKKa1NaydW3lLnaP2wzJY7SVDW5OZAgPvBJHeuHEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdYQCLBaid2f4KrZio2lRwSgQHmuKkpl+1G4WlBNUCk=; b=whTHt0jux4b4G58qpXkC/8z9SeQeLLVZYA+SO5ZeBf9OBS/w85JuJW4vMdWW06s/OwjDKd8jNF/B2nPdLCgDsCm7Ae3e4J5nXu8vaAwLkpJzgrdwMb8i/It8N7y7vakRZf5izeIoWzJMd9L4DSTtbg3guW7NR6ed2oW68MDFe8U= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB7792.eurprd08.prod.outlook.com (2603:10a6:20b:52c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 09:12:48 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7386:6dd6:e6ba:dd94]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7386:6dd6:e6ba:dd94%4]) with mapi id 15.20.6254.029; Mon, 3 Apr 2023 09:12:48 +0000 Message-ID: <7cf30e84-038b-e08b-a236-0a42c00397bd@arm.com> Date: Mon, 3 Apr 2023 10:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] [aarch64] tpidr2: Fix erroneous detection logic for TPIDR2 To: gdb-patches@sourceware.org References: <20230314142244.210512-1-luis.machado@arm.com> Content-Language: en-US From: Luis Machado In-Reply-To: <20230314142244.210512-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0439.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB7792:EE_|DBAEUR03FT010:EE_|PAWPR08MB9686:EE_ X-MS-Office365-Filtering-Correlation-Id: 17da1fbe-e0dd-4e5f-40db-08db34239dcb x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Q24TBKhBTgc/132bRiDfuuXhefWLFVWcaEkkRUPUGx99ZQ4LBqshzd7gb1BNyf5LIti/9GSUPK6RGwnW+SeJb4wT/V5g/U88QQknuroTExt0Cb6BDj0VLK4aarq1RAZPQ53hhoUxh89SPaNYBCjrcIb32bRoBwLAU/S3W4cLI2YxMbB48nWHLq/XuvmufZNQNkbF2zdQBP3kRYkWKGcnaF0QptipVI9JaAHQXpykdfBGqIOX6WNgrDILEgEa2apaOudGKpFGylLTA2vvw5vobTtKDXLCZC6pL9qm3qj1eg9zO/5Wy8Qr21DCHgCbzjwXrwgu6yOBspkLOGg0p5x8VP7Yh/HLI0ElvMBbHmbeQRxk2cGIsWFJuHuRRo3hsU2mx7XekQyfgt4O7YM/5V7byi3A6r95F/GF87HzsD85fpA6ZusuzMBt0jMO2pCernwEl94+OUHRESgDUgPD0r09Lvl6xXBN9z1/cY86OzTqZsSaeqIFSyNhmNCYQjYzxIJbf5T+rPq0Ghjynm6gU0zzWa69hW8ZGSb1QCUrG5Odw6CrhNmXcH4EzVmElIPRz7WOj2c8nFNG06TJr3ObJipP/fr0DI0leO4i9KFnqPoLVqfAJxzD2sKWnNZVPzsSmwjbT8u1464ncg5AMPmzid9HGA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(366004)(346002)(396003)(39860400002)(451199021)(83380400001)(8676002)(6916009)(66946007)(66556008)(86362001)(66476007)(2906002)(41300700001)(316002)(31696002)(31686004)(478600001)(36756003)(38100700002)(6486002)(8936002)(2616005)(5660300002)(53546011)(6512007)(186003)(26005)(6506007)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7792 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 42f7d35a-d2ae-474a-4f4d-08db34239795 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wEyqQ0nvEbXDOfLedW6xHGnvHdNvVb+F05MNeyn6JiYhtG3s9Ojcok29fUKymJyBHMtYfQjcWo0UhWMgK6O8aVwe4EN9W4+4rZ66etfi0FdueReo9YrJpMOvmXTL/BLUWMZcpnvPZBfcyrJgYAHzHQH8166R1MYxcOimjQNNXz+NRSKQvyF8fAAAmy4Ji9OAvMcsLfoPbeYU9pruBWAGIjOZpc5vm2PbOYqn5dVL+++JASVY/ZyhShuod+Lqe9euLDnrHp9cKVG6t2a6Ed+K4wEopfQiGnDSM6D+l4BesUiUP69HGtMQoSDJWfmhc2JSja5rDUFlF9PDWp9sHBsXoxjTKiJTLwbx/jijUTQbj1KkUrSMemYyLqujTaIhQP0F8nEkfSu/0x9DW3F+4I7htOoCpCJS/wz6GB7WO9W5CNPIthQ2lgYn+J5aezJ5A6cqnBIDOgqTNR/QbuOew91BKwqmQgXmH9tXAHag4x0wh+Q7jQkcchFP9ct+kNEHy2gqk3Ep83zg+/8NTxL980FPbiGQc4tzhEBdoYIrkmfRwrGP24TYGsVtt00fRqggckd8CYHIHUyIJY0vZf25jpA7/UHM0NFr89u8J4u+A5Q79Ga2zcC5HI40MrViFnjBbYl33UaW25lsDA9/psTbdphUFF1I4WFKUzXFEWeXoe+cg4IuJ/xFhg9ocoBrPUbluVV9N034z4COMVtyCRSFJ0EnyV6m7HkfYs9M1BEkysBGvtI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199021)(46966006)(36840700001)(40470700004)(86362001)(31696002)(82310400005)(36756003)(40480700001)(36860700001)(478600001)(41300700001)(82740400003)(8936002)(81166007)(356005)(70586007)(8676002)(6916009)(70206006)(186003)(6486002)(47076005)(2616005)(83380400001)(336012)(316002)(31686004)(53546011)(6506007)(6512007)(26005)(40460700003)(5660300002)(44832011)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 09:12:57.8900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17da1fbe-e0dd-4e5f-40db-08db34239dcb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9686 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/23 14:22, Luis Machado via Gdb-patches wrote: > The detection logic for TPIDR2 was implemented incorrectly. Originally > the detection was supposed to be through a ptrace error code, but in reality, > for backwards compatibility, the detection should be based on the size of > the returned iovec. > > For instance, if a target supports both TPIDR and TPIDR2, ptrace will return a > iovec size of 16. If a target only supports TPIDR and not TPIDR2, it will > return a iovec size of 8, even if we asked for 16 bytes. > > This patch fixes this issue in code that is shared between gdb and gdbserver, > therefore both gdb and gdbserver are fixed. > > Tested on AArch64/Linux Ubuntu 20.04. > --- > gdb/nat/aarch64-linux.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gdb/nat/aarch64-linux.c b/gdb/nat/aarch64-linux.c > index 6c8a78f1729..a84faf1cfbf 100644 > --- a/gdb/nat/aarch64-linux.c > +++ b/gdb/nat/aarch64-linux.c > @@ -261,13 +261,13 @@ aarch64_tls_register_count (int tid) > iovec.iov_base = tls_regs; > iovec.iov_len = sizeof (tls_regs); > > - /* Attempt to read both TPIDR and TPIDR2. If the request fails, it means > - the Linux Kernel does not support TPIDR2. > - > - Otherwise the Linux Kernel supports both TPIDR and TPIDR2. */ > + /* Attempt to read both TPIDR and TPIDR2. If ptrace returns less data than > + we are expecting, that means it doesn't support all the registers. From > + the iovec length, figure out how many TPIDR registers the target actually > + supports. */ > if (ptrace (PTRACE_GETREGSET, tid, NT_ARM_TLS, &iovec) != 0) > - return 1; > + return 0; > > - /* TPIDR2 is available as well. */ > - return 2; > + /* Calculate how many TPIDR registers we have. */ > + return iovec.iov_len / sizeof (uint64_t); > } Pushed now as d747348d02f12121a2e897f7789ff27ffbd2f23d.