From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7B4CC3858D1E for ; Mon, 24 Apr 2023 15:45:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B4CC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682351145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fvLi8o727nOeeZhwRBWLm4w8SkfWzd2xra+oUFA8lec=; b=R1cV5z4W0XcRZvyb1oAj3WZtqXGD6lWy4YUf1eOckKOPg6ShP2srxcmizX8feVQSuNcdE2 myc/Mkv7cKbQdBhpsA84xKYLbh5cZ/WQ+GPpCgTW40h+e+e+kNjVtUFGtfihm7mazFNaN2 2WdCM84377ziIRCuo2767ujyWK8GpQg= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-CDqmhBo_M9-Z-flXzdvMDQ-1; Mon, 24 Apr 2023 11:45:36 -0400 X-MC-Unique: CDqmhBo_M9-Z-flXzdvMDQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-74aa39dac03so291688185a.3 for ; Mon, 24 Apr 2023 08:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682351135; x=1684943135; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvLi8o727nOeeZhwRBWLm4w8SkfWzd2xra+oUFA8lec=; b=iiv53+viXMXFY/Zc+Nw87HWz/cS9DjP5jmjfe3eKcyPFNCvnf7OpCRI+/xPDjw9AjU H8NZUgDPwQsrLZQDtYOuGsyU17zcEJ+0wIGS537pzQPbFnP9n/G65b8H/OOwkLcV/y6F ZJ+g+/2GHrCkWJzc3LDvmL1BdmVx0Bo03D8dJZ3l3tXbtlc5IQoU7DAYIgifVWkmOyfy /EI4KZI74RCBimWjlE37YhvwCbFvJCTHcHEaSJfpYSfGVQgnnYm0MwpPnyW3zEXpgOcO qrmaFkUqBZWXvHnp9kas5yjDIhKtZLR1bJTkYUMWcSTejnP+Gm7iTcqsZpg9jiaFSE72 iiNw== X-Gm-Message-State: AAQBX9eAKPSnR+xZe/ThnnsJfBm+7qQILBKuNz7vz6vO8uLyXHr40SK1 deJr3MU1KW4Wtkp9qkffkqx4sU8vUBTUKwPKTjdkyT2r0dg+k35T5rLS0bz3jY09AJiekDJ0gLC f0kXEZg+eBUVkXP8Bc7dWx+K19cZSoQ== X-Received: by 2002:ad4:5b8f:0:b0:5ea:2575:dccb with SMTP id 15-20020ad45b8f000000b005ea2575dccbmr22752547qvp.46.1682351135292; Mon, 24 Apr 2023 08:45:35 -0700 (PDT) X-Google-Smtp-Source: AKy350YT3uKEpFbZOWb1iSFsQd9UcdoFzpNhLLTWhkrEFb7s6YlEgX8NF4+VUYiUAVJdFGibJvVOOw== X-Received: by 2002:ad4:5b8f:0:b0:5ea:2575:dccb with SMTP id 15-20020ad45b8f000000b005ea2575dccbmr22752522qvp.46.1682351135044; Mon, 24 Apr 2023 08:45:35 -0700 (PDT) Received: from [192.168.0.45] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id e23-20020a0caa57000000b005e3bda8a5e0sm3413516qvb.6.2023.04.24.08.45.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 08:45:34 -0700 (PDT) Message-ID: <7d2bc0ed-791a-4fc7-b4a8-4902ea2a278b@redhat.com> Date: Mon, 24 Apr 2023 17:45:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Remove parameter from select_source_symtab To: Tom Tromey , gdb-patches@sourceware.org References: <20230417212417.486279-1-tom@tromey.com> From: Bruno Larsen In-Reply-To: <20230417212417.486279-1-tom@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/04/2023 23:24, Tom Tromey wrote: > I noticed that select_source_symtab is only ever called with nullptr > as an argument, so this patch removes the parameter and associated > logic. > --- Hi Tom, Looks alright to me! Reviewed-By: Bruno Larsen -- Cheers, Bruno