From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 995E53858D39 for ; Wed, 4 Jan 2023 16:24:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 995E53858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 304GMul1026411 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 Jan 2023 11:23:01 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 304GMul1026411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1672849381; bh=r3mwZ1pUxM9mbKyHa5x+lY3NsEf+94g1zm7QsrKBgPo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Otp+M2mJx5L7X2hBvjB9/B/e4gn2CNxqdWLBGv0uL617cPbSMEReWKp8HW1ONMVA2 m5gOYpfmN6aeHexpDaM4ubsD1+4mITRoNZiS5PdTMUrnIBEo3JzF19sf1t8R4I8ak9 iuI6qvTDRJmBHlLfvg4sf9+y/ta5W6+JjYGnCXWU= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 31D5C1E110; Wed, 4 Jan 2023 11:22:56 -0500 (EST) Message-ID: <7d38d82e-1beb-c3dc-441a-b4e455351020@polymtl.ca> Date: Wed, 4 Jan 2023 11:22:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint Content-Language: en-US To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <20230104091559.rqo2774ba566j5sg@ubuntu.lan> <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> From: Simon Marchi In-Reply-To: <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 4 Jan 2023 16:22:56 +0000 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/4/23 11:18, Lancelot SIX wrote: >> Oh, right, I missed that. I folded the test name in the >> gdb_test_multiple call (removed the test_name var) and used >> $gdb_test_name in the fail call. I updated the patch locally. Should I >> add your Reviewed-By after those changes? >> >> Simon >> > > Yes, with those change, feel free to add > > Reviewed-By: Lancelot Six > > Best, > Lancelot. Thanks, pushed! Simon