From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] sim: Make WITH_{TRACE,PROFILE}-based macros bool
Date: Thu, 6 Oct 2022 14:33:44 +0900 [thread overview]
Message-ID: <7d4dff89-0026-35c3-996d-d7e9e934a3f8@irq.a4lg.com> (raw)
In-Reply-To: <87k05efqjy.fsf@redhat.com>
On 2022/10/05 20:38, Andrew Burgess wrote:
> Tsukasa OI <research_trasio@irq.a4lg.com> writes:
>
>> Clang generates a warning if an ambiguous expression (possibly a bitwise
>> operation (& or |) but a logical operator (&& or ||) is used) is detected.
>> Because of the default configuration ("-Werror"), it causes a build failure.
>>
>> This is caused by predicate macros that use (base_variable & flag).
>> Clang considers them as regular integer values (not boolean) and
>> generates that warning.
>>
>> This commit makes Clang to think those predicate macros to be boolean.
>>
>> sim/ChangeLog:
>>
>> * common/sim-profile.h (WITH_PROFILE_INSN_P, WITH_PROFILE_MEMORY_P,
>> WITH_PROFILE_MODEL_P, WITH_PROFILE_SCACHE_P, WITH_PROFILE_PC_P,
>> WITH_PROFILE_CORE_P): Make predicate macros boolean.
>> * common/sim-trace.h (WITH_TRACE_P, WITH_TRACE_ANY_P): Likewise.
>> ---
>> sim/common/sim-profile.h | 12 ++++++------
>> sim/common/sim-trace.h | 4 ++--
>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/sim/common/sim-profile.h b/sim/common/sim-profile.h
>> index 61d5039e10d..acf0f7d74e2 100644
>> --- a/sim/common/sim-profile.h
>> +++ b/sim/common/sim-profile.h
>> @@ -87,12 +87,12 @@ SIM_RC sim_profile_set_option (SIM_DESC sd_, const char *name_, int idx_,
>> #define PROFILE_core (1 << PROFILE_CORE_IDX)
>>
>> /* Preprocessor macros to simplify tests of WITH_PROFILE. */
>> -#define WITH_PROFILE_INSN_P (WITH_PROFILE & PROFILE_insn)
>> -#define WITH_PROFILE_MEMORY_P (WITH_PROFILE & PROFILE_memory)
>> -#define WITH_PROFILE_MODEL_P (WITH_PROFILE & PROFILE_model)
>> -#define WITH_PROFILE_SCACHE_P (WITH_PROFILE & PROFILE_scache)
>> -#define WITH_PROFILE_PC_P (WITH_PROFILE & PROFILE_pc)
>> -#define WITH_PROFILE_CORE_P (WITH_PROFILE & PROFILE_core)
>> +#define WITH_PROFILE_INSN_P (!!(WITH_PROFILE & PROFILE_insn))
>> +#define WITH_PROFILE_MEMORY_P (!!(WITH_PROFILE & PROFILE_memory))
>> +#define WITH_PROFILE_MODEL_P (!!(WITH_PROFILE & PROFILE_model))
>> +#define WITH_PROFILE_SCACHE_P (!!(WITH_PROFILE & PROFILE_scache))
>> +#define WITH_PROFILE_PC_P (!!(WITH_PROFILE & PROFILE_pc))
>> +#define WITH_PROFILE_CORE_P (!!(WITH_PROFILE & PROFILE_core))
>
> Rather than using this '!!' trick, which I'm really not a fan of, could
> we just do:
>
> #define WITH_PROFILE_CORE_P ((WITH_PROFILE & PROFILE_core) != 0)
>
> I feel this is an accurate representation of the question we're actually
> asking.
>
> Thanks,
> Andrew
That will work. That's my habit from old time. I'll fix that and
resubmit the patchset.
Thanks,
Tsukasa
>
>
>>
>> /* If MAX_TARGET_MODES isn't defined, we can't do memory profiling.
>> ??? It is intended that this is a temporary occurrence. Normally
>> diff --git a/sim/common/sim-trace.h b/sim/common/sim-trace.h
>> index d08810d9fcc..bc3e690a4cc 100644
>> --- a/sim/common/sim-trace.h
>> +++ b/sim/common/sim-trace.h
>> @@ -125,10 +125,10 @@ enum {
>> #define TRACE_debug (1 << TRACE_DEBUG_IDX)
>>
>> /* Return non-zero if tracing of idx is enabled (compiled in). */
>> -#define WITH_TRACE_P(idx) (WITH_TRACE & (1 << idx))
>> +#define WITH_TRACE_P(idx) (!!(WITH_TRACE & (1 << idx)))
>>
>> /* Preprocessor macros to simplify tests of WITH_TRACE. */
>> -#define WITH_TRACE_ANY_P (WITH_TRACE)
>> +#define WITH_TRACE_ANY_P (!!(WITH_TRACE))
>> #define WITH_TRACE_INSN_P WITH_TRACE_P (TRACE_INSN_IDX)
>> #define WITH_TRACE_DISASM_P WITH_TRACE_P (TRACE_DISASM_IDX)
>> #define WITH_TRACE_DECODE_P WITH_TRACE_P (TRACE_DECODE_IDX)
>> --
>> 2.34.1
>
next prev parent reply other threads:[~2022-10-06 5:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 12:57 [PATCH 0/4] sim/common: Suppress warnings if built with Clang Tsukasa OI
2022-09-13 12:57 ` [PATCH 1/4] sim: Add ATTRIBUTE_PRINTF Tsukasa OI
2022-09-13 12:57 ` [PATCH 2/4] sim: Remove self-assignments Tsukasa OI
2022-09-13 12:57 ` [PATCH 3/4] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-10-05 11:38 ` Andrew Burgess
2022-10-06 5:33 ` Tsukasa OI [this message]
2022-09-13 12:57 ` [PATCH 4/4] sim: Suppress non-literal printf warning Tsukasa OI
2022-10-05 11:45 ` Andrew Burgess
2022-10-06 5:39 ` Tsukasa OI
2022-10-23 12:22 ` Mike Frysinger
2022-10-24 10:50 ` Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 0/5] sim: Suppress warnings if built with Clang Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 1/5] sim: Remove self-assignments Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 3/5] sim: Suppress non-literal printf warning Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 4/5] sim: Check known getopt definition existence Tsukasa OI
2022-09-25 8:42 ` [PATCH v2 5/5] sim: Initialize pbb_br_* by default Tsukasa OI
2022-10-06 6:43 ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Tsukasa OI
2022-10-06 6:43 ` [PATCH v3 1/5] sim: Remove self-assignments Tsukasa OI
2022-10-11 14:21 ` Andrew Burgess
2022-10-11 14:29 ` Tsukasa OI
2022-10-06 6:43 ` [PATCH v3 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-10-06 6:43 ` [PATCH v3 3/5] sim: Suppress non-literal printf warning Tsukasa OI
2022-10-11 14:22 ` Andrew Burgess
2022-10-06 6:43 ` [PATCH v3 4/5] sim: Check known getopt definition existence Tsukasa OI
2022-10-12 16:28 ` Tom de Vries
2022-10-12 17:03 ` Tsukasa OI
2022-10-12 17:08 ` Tom de Vries
2022-10-12 17:20 ` Tom de Vries
2022-10-13 9:50 ` Tsukasa OI
2022-10-23 12:16 ` Mike Frysinger
2022-10-27 2:02 ` Tsukasa OI
2023-01-03 3:12 ` Mike Frysinger
2023-01-03 8:47 ` Tsukasa OI
2022-10-06 6:43 ` [PATCH v3 5/5] sim: Initialize pbb_br_* by default Tsukasa OI
2022-10-11 14:20 ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Andrew Burgess
2022-10-11 16:40 ` Tom de Vries
2022-10-11 18:02 ` Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d4dff89-0026-35c3-996d-d7e9e934a3f8@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).