From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id F16CF3858D1E for ; Wed, 2 Aug 2023 21:21:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F16CF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30B9A2189B; Wed, 2 Aug 2023 21:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691011295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KVTfXNflFq2ByH1dKNnBvqR2n2q4WJNs26jOB4lwfvU=; b=o9B0NnvUpL5hyuo/pfVAdTfR5a9C+o4bAhl59k+hz6YcV3bmwGTOoz9RWS6BYkfxcfaPyg KZwsIm8Xj4V0hB7pn5oF2VwiQ7p+0DzX/NRoxvJ2JRS616FfXTcArDmF5WA0V2NdLrUO9g gvQj0CWJe1In5bpXOzev3VBOnfOL1UI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691011295; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KVTfXNflFq2ByH1dKNnBvqR2n2q4WJNs26jOB4lwfvU=; b=Wo/eW9AhTBP6tk8SY9KDqk0SXTXDCKzgv5Qocgb+UHyaimk7lA9NKAI48QtyCjWXx2lkgg OOJwt+/Fg7DidRDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1EF9713909; Wed, 2 Aug 2023 21:21:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VI9gBt/IymQOSAAAMHmgww (envelope-from ); Wed, 02 Aug 2023 21:21:35 +0000 Message-ID: <7d705bdb-5984-b951-1ef4-bd06f8aae407@suse.de> Date: Wed, 2 Aug 2023 23:21:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb] Initialize main_thread_id earlier Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230728105945.13909-1-tdevries@suse.de> <20230728105945.13909-2-tdevries@suse.de> <877cqki3m0.fsf@tromey.com> <874jlhfkoi.fsf@tromey.com> <8b34476a-aad0-589c-aa28-4465e5133acb@suse.de> <874jlhcgr7.fsf@tromey.com> From: Tom de Vries In-Reply-To: <874jlhcgr7.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/2/23 22:48, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > >>> If we think it's safe enough to initialize it on first use, just >>> moving >>> the definition into is_main_thread is enough to avoid this problem. >>> > > Tom> Done. > > This wasn't really what I meant but it's not important. > Thanks for the review. Sorry for misunderstanding this, if you'd like me to follow up in any way, let me know. Committed. Thanks, - Tom > Approved-By: Tom Tromey > > Tom