From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 2C2EB383E81D for ; Mon, 1 Feb 2021 11:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C2EB383E81D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x334.google.com with SMTP id 190so12376728wmz.0 for ; Mon, 01 Feb 2021 03:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tUDbDHSSJ536jMpYiE0WOCLISn3EDRo/V/w34eBZYPY=; b=Cha1t2f5JnUgm7duMC7qLZCMfI9NI47KvwhQPu9GMOOY66OxzGqiK8Qd96BYqslDI2 IDAOhAEH9/dmNbpjFw6d4SghZzITu7425sUVUkixwNU6U/hyaocc6CwEQ6lM7L2QHJIN 5fnEB+u7ZxYQXkJDrQi8fkdqLHnCyuxP608Ihre2IJsSh45C0XqabuAnBSU06dmDKfDr dGiLt+lOZ2qgH3g9fwnwpr7erX8bJgInCHTMJZ8AeM47Aaa2PMXC1QjXy1jD4lhhomGU Y9Ghuy+4XQzaHjpmHsRPVxDUg+rVlAC3hXI+Fs6xmFJCAuhYQNCcjAHmCnDYHMwrgSxt AGAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tUDbDHSSJ536jMpYiE0WOCLISn3EDRo/V/w34eBZYPY=; b=XceBWRyWZdyQGUUmlkQo5oI3OQ3TK4hRi8Ovwrb18+vZvlxjSocZD10xEUlE/W9jSG qHSYt7BnDKxlNzuWNcV5CallT09xcWXltB1jBvgReilrziQhmbsU1/TMqw01qjFA5ZP5 7GM+b8PZtYnVET+FrWU1k0/JhoyeUUGC9E/PJFkmXTz7AdVm1Q0XVwHm3C/JSp6WygQB RXXTNFL8LspudZz9jJPQVCFsRms0f6L6Bor6LOhXNpxsruADH9L4eonbvMtaSdYPYZ8T cKzwUaP6VrM13mpzCGSohw4cH/HWPJx5LWFmEwBgkC35UTELuZlown1o7fqsl/XJhtsw 2SVg== X-Gm-Message-State: AOAM531u7Q7tMrZutgv3Sss1A2PG2ORgZ0QgkTuuJ0m1sSvghzui1PRL MmZkkNjvwZwVwxt7G3dykfKXG7ecGRBINg== X-Google-Smtp-Source: ABdhPJwbGpIWAa5oJaIUK1Ui4f4gfJwWIQp6Qtl/WaBZkyoE/GZt3FMUB4e0eTrD3dOVYPTDwsuIzg== X-Received: by 2002:a1c:ab57:: with SMTP id u84mr15204639wme.115.1612179862112; Mon, 01 Feb 2021 03:44:22 -0800 (PST) Received: from localhost (host86-191-239-31.range86-191.btcentralplus.com. [86.191.239.31]) by smtp.gmail.com with ESMTPSA id i8sm28060811wry.90.2021.02.01.03.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 03:44:21 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 02/11] sim/rx: fix an issue where we try to modify a const string Date: Mon, 1 Feb 2021 11:44:05 +0000 Message-Id: <7d7067b97f1181f6554473fadb2a039f9986f60a.1612179773.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2021 11:44:25 -0000 While experimenting with switching on warnings for the rx simulator I discovered this bug. In sim_do_command we get passed a 'const char *' argument. We create a copy of this string to work with locally, but then while processing this we accidentally switch back to reference the original string. sim/rx/ChangeLog: * gdb-if.c (sim_do_command): Work with a copy of the command. --- sim/rx/ChangeLog | 4 ++++ sim/rx/gdb-if.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sim/rx/gdb-if.c b/sim/rx/gdb-if.c index 6f8bfbd1c50..55eb13d12ef 100644 --- a/sim/rx/gdb-if.c +++ b/sim/rx/gdb-if.c @@ -804,13 +804,13 @@ sim_do_command (SIM_DESC sd, const char *cmd) p++; /* Find the extent of the command word. */ - for (p = cmd; *p; p++) + for (; *p != '\0'; p++) if (isspace (*p)) break; /* Null-terminate the command word, and record the start of any further arguments. */ - if (*p) + if (*p != '\0') { *p = '\0'; args = p + 1; -- 2.25.4