From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4073D384F6FB for ; Mon, 21 Nov 2022 20:02:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4073D384F6FB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ALK2AgH013553 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Nov 2022 15:02:14 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ALK2AgH013553 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1669060935; bh=pr2i5TJUEo2/XRCrAr6+b/VdzUPC5F57l6fkynMjngA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GM0uP5oIHE3BxMDZg4FhqkrB6TVNorroOHr485dNZ2RRpKtPJkB34hifvJ0vSu9sW MtmuroA2/A+mSQa3xiESqLqFDJsYf85nW8ZHbZFwekb2yZcLKipOB31gHmIgbDresE 6Jsa9Retu+KFx4JVh50P1cEUw+mb+XJpOk+eL0G4= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C1E4C1E0D3; Mon, 21 Nov 2022 15:02:08 -0500 (EST) Message-ID: <7dc71740-a5ca-0c47-134f-a02d58026ce4@polymtl.ca> Date: Mon, 21 Nov 2022 15:02:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] gdb: add "set debug solib" and use it Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20221121193636.1479004-1-simon.marchi@polymtl.ca> <83zgck13q4.fsf@gnu.org> From: Simon Marchi In-Reply-To: <83zgck13q4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 Nov 2022 20:02:10 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/22 14:56, Eli Zaretskii wrote: >> Cc: Simon Marchi >> Date: Mon, 21 Nov 2022 14:36:36 -0500 >> From: Simon Marchi via Gdb-patches >> >> From: Simon Marchi >> >> I'd like to add some debug output to solib-svr4. Add a "set debug >> solib" knob, which can then be used in all solib-* files. Then, add >> the debug output I needed, related to the svr4 shared library event >> breakpoint probes. > > Not sure I understand: we already have "set debug aix-solib" and "set debug > solib-frv". So this is going to be "set debug svr4-solib"? Or do you mean > to make a single "set debug solib" command for all platforms? The new command was intended to be used by all solib implementations, but I missed the existing commands you pointed out. I think it would be fine to have a single knob for all solib implementations. In general, only one solib implementation will be used at any given time. If you agree, I would remove the two existing commands in favor of the new "set debug solib", and then add my solib-svr4 changes. > > Thanks. > >> gdb/NEWS | 4 ++++ >> gdb/doc/gdb.texinfo | 6 ++++++ >> gdb/solib-svr4.c | 23 ++++++++++++++++++++++- >> gdb/solib.c | 8 ++------ >> gdb/solib.h | 12 ++++++++++++ >> 5 files changed, 46 insertions(+), 7 deletions(-) > > The documentation parts are okay, but the text sounds as if this command is > available on all platforms. That is the intention. Simon