From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 598363858D35 for ; Wed, 15 Feb 2023 16:42:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 598363858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.111] (modemcable162.249-56-74.mc.videotron.ca [74.56.249.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E926C1E110; Wed, 15 Feb 2023 11:42:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676479336; bh=LKhi7s0e2QyNYsUSY/1Tqdy+Q/5IcTNEqGDTEbMsGY8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OqewKAZalbWhsdHvHmmtTcU1X+Ep/25CyS2aGonUPtcDvdJq1n2jP2sNy1CQsyNP3 wAn5BH/K1MbLmPurvG8h6GVuxzVVYJW1SiBxvWUNq7gsTIJXzKq0WsIfIZ8mzuHika p5AQK4oq3eNaJ2wacID6wZdZLxYpWwX8Doz0BVpY= Message-ID: <7ddb6fa6-17ad-285d-3b0d-945c503cb999@simark.ca> Date: Wed, 15 Feb 2023 11:42:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] gdb: fix dealloc function not being called for frame 0 Content-Language: fr To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org References: <20230209195037.100368-1-simon.marchi@efficios.com> <30ee85a3-d6aa-c69e-2fe6-3c6d53a11a90@simark.ca> <8b8d6d16-ed28-bebb-9136-85fc81968fa5@suse.de> From: Simon Marchi In-Reply-To: <8b8d6d16-ed28-bebb-9136-85fc81968fa5@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi Simon, > > I've: > - applied the initial patch > - verified that it fixes the gdb.btrace/record_goto.exp test-case > - verified that it breaks the gdb.server/server-kill.exp test-case > - applied your proposed change (attached in patch form for clarity) > - verified that it fixes the gdb.server/server-kill.exp test-case > - verified that it still fixes the gdb.btrace/record_goto.exp test-case > - done a complete build and test run, no issues found (in other words, > I'm back to just one FAIL, in gdb.server/monitor-exit-quit.exp, > PR29833) Thanks for testing. Should I add just your Tested-By, or did you review more in-depth? Simon