Re: [PATCH] Fix calling debuginfo-less functions in Ada

[Keith Seitz <keiths@redhat.com>]

On 4/17/23 06:41, Tom Tromey via Gdb-patches wrote:
> A co-worker at AdaCore noticed that calling a function without
> debuginfo yields:
> 
> (gdb) print plus_one(23)
> 'pck.plus_one' has unknown return type; cast the call to its declared return type
> 
> However, this also happens if you follow the directions and add the
> cast.
> 
> This patch fixes the problem and adds a regression test.

I'm no Ada expert (or even novice!), but I do have one tiny question/comment.

> diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp
> index 4395f31ad94..211aa77e366 100644
> --- a/gdb/testsuite/lib/ada.exp
> +++ b/gdb/testsuite/lib/ada.exp
> @@ -66,7 +66,9 @@ proc gdb_compile_ada_1 {source dest type options} {
>       # and it avoids using a stray objfile file from a long-past
>       # run, for instance.
>       append options " ada"
> -    append options " additional_flags=-f"
> +    if {[lsearch -exact $options no-force] == -1} {
> +	append options " additional_flags=-f"
> +    }
>       append options " additional_flags=-I$srcdir"
>   
>       set result [target_compile_ada_from_dir \

This "no-force" option is new -- should it be mentioned somewhere?

I'm just thinking that if I end up hacking on this sometime, it
would save me some grief to see any/all Ada-specific options listed
or explained somewhere. [I guess this is really the first one, though.]

Otherwise, I see no issues with your patch.

Keith