From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id BBC0C383FB84 for ; Mon, 20 Feb 2023 10:27:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BBC0C383FB84 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0F9D1FFC1; Mon, 20 Feb 2023 10:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676888828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+EHEgWcYlXxvdmBPp4lmJP+iI+X1NfSdb9Uk0G9ecQ=; b=DRMpJ5e8x3kaEb77A8B5e1LmlfdPV5zzpzQYLVF7bMmfQVfQVRg+kx/kr2BY9s7J8b6E3Q bMvuHGUgj7NVkjFVk0T3VHKq81p2xWrrf4H6G5zWqAyCac27XQAuYs73i93fgRHQMJPa/n 5zIXDvlddfmR8y9rESsUMiApjiBxT0o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676888828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F+EHEgWcYlXxvdmBPp4lmJP+iI+X1NfSdb9Uk0G9ecQ=; b=nZhMWtA38JF+X3Wciaeti+HORLTJJiOhTpgDHzHZ/DSvpU1igWgDtI8O9B5BoFeOsndfOm TC3z8k9ak3Ybi7Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD7EC139DB; Mon, 20 Feb 2023 10:27:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 19noNPxK82MOJgAAMHmgww (envelope-from ); Mon, 20 Feb 2023 10:27:08 +0000 Message-ID: <7defd3d5-2a47-85e7-c511-95e834ecb5b1@suse.de> Date: Mon, 20 Feb 2023 11:27:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/5] [gdb/symtab] Factor out compunit_epilogue_unwind_valid Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230213142309.24366-1-tdevries@suse.de> <20230213142309.24366-2-tdevries@suse.de> <87a61gtf4r.fsf@tromey.com> <9aac3a4f-de36-6dec-d4ea-c4b7c84ac75c@suse.de> From: Tom de Vries In-Reply-To: <9aac3a4f-de36-6dec-d4ea-c4b7c84ac75c@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/14/23 23:36, Tom de Vries via Gdb-patches wrote: > On 2/14/23 16:56, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries via Gdb-patches >>>>>>> writes: >> >> Tom> Factor out compunit_epilogue_unwind_valid from both >> Tom> amd64_stack_frame_destroyed_p and i386_stack_frame_destroyed_p. >> NFC. >> >> What does NFC means? >> > > No Functional Changes. > > I guess I picked this up when working on clang/llvm. > > Mentioned here: https://llvm.org/docs/Lexicon.html#n . > And grepping through the commit log, I see I used it before. Anyway, replaced by "No functional changes". >> Tom> Also add a comment in the new function about the assumption that >> in absence of >> Tom> producer information, epilogue unwind info is invalid. >> >> Thanks. >> Approved-By: Tom Tromey >> Thanks, I've added the tag to this commit and will commit the series after retesting. Thanks, - Tom