From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <research_trasio@irq.a4lg.com>
Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154])
	by sourceware.org (Postfix) with ESMTPS id 5BC5F38582A8
	for <gdb-patches@sourceware.org>; Mon, 24 Oct 2022 06:31:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BC5F38582A8
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 8575C300089;
	Mon, 24 Oct 2022 06:31:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com;
	s=2017s01; t=1666593066;
	bh=1e1Zs3tSWB/u/cJb32/K6O0h+ZAOWFJFN9ViXi+Rpbc=;
	h=Message-ID:Date:Mime-Version:Subject:To:References:From:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=kgF85Y4ZLyXntEyTCsr/AOLMalmVY7jMj8FZ8rQbkExZwFleazWX32Peg8WQq7vPW
	 XePxk5Y1arjQoP19cIDLb8X+UpgSTAdEkWmfBHlwqm5qJp41Ey48050htmP+4Xmgaa
	 0xpmA+qJkzQvPdiz21+1rG9ftiY+X4w5Cr5r6Iyo=
Message-ID: <7e383f23-1568-2129-d717-2b7fc45f860b@irq.a4lg.com>
Date: Mon, 24 Oct 2022 15:31:03 +0900
Mime-Version: 1.0
Subject: Re: [RESEND PATCH 0/1] sim/testsuite: Trim extra path from arch
To: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
References: <28df7073ec5a8f601ba47c9d2f7d4a7a0ce08753.1657795051.git.research_trasio@irq.a4lg.com>
 <cover.1661565178.git.research_trasio@irq.a4lg.com> <Y1WTDDkd6ToKlyXT@vapier>
Content-Language: en-US
From: Tsukasa OI <research_trasio@irq.a4lg.com>
In-Reply-To: <Y1WTDDkd6ToKlyXT@vapier>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2022/10/24 4:16, Mike Frysinger wrote:
> On 27 Aug 2022 01:53, Tsukasa OI wrote:
>> The patch is a RESEND of
>> <https://sourceware.org/pipermail/binutils/2022-July/121814.html>
>> but to the right mailing list and completely new cover letter.
> 
> please clean up the patch and send it out standalone -- no need for a cover
> letter, and the relevant details should all be in the patch itself.

Sorry, I should have at least enhanced the commit message (I would have
attached a separate cover letter for information not relevant to the
change itself).

> 
>> 1.  Configure Binutils with aarch64-unknown-elf and build it
>>     /src/binutils/configure \
>>         --target=aarch64-unknown-elf \
>>         --prefix=/opt/cross/aarch64-unknown-elf \
>>         --enable-multilib
>>     && make
>> 2.  Run `make check-sim' and confirmed that the simulator tests "pass"
>> 3.  Intentionally try to fail the test by modifying
>>     `sim/testsuite/aarch64/pass.s'
>>     (replace the last line from "pass" to "fail")
>> 4.  Run `make check-sim' and "confirmed" that the simulator tests "pass"
> 
> since i don't have the same paths as you, i didn't run the same configure.
> but using --target=aarch64-elf and running `make check-sim` with -j1 vs -j4
> doesn't show any behavior difference.  all the tests are found & run.  if i
> add an error to one of the tests like you did, it fails in both modes.
> 
> $ runtest --version
> DejaGnu version 1.6.3
> Expect version  5.45.4
> Tcl version     8.6
> 
>> However, this block doesn't work because the `arch' variable returned by
>> the `sim_arch' function is "./aarch64".  That is supposed to be "aarch64".
> 
> i don't mind fixing sim_arch, but this really should be fixed too.  we
> shouldn't be in a situation where "./aarch64" is present as an input.
> 
> seems easy enough to do so i pushed a patch for it.
> -mike

That worked perfectly!

I'll withdraw this patchset and close the bug report.

Thanks,
Tsukasa