From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130777 invoked by alias); 20 Feb 2017 20:37:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130761 invoked by uid 89); 20 Feb 2017 20:37:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:770, H*i:sk:aa362d1, H*f:sk:aa362d1 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Feb 2017 20:37:27 +0000 Received: by simark.ca (Postfix, from userid 33) id B4F621E18F; Mon, 20 Feb 2017 15:37:24 -0500 (EST) To: Luis Machado Subject: Re: [PATCH] Introduce and use disassembly_flags X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Feb 2017 20:37:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: References: <20170211031207.4682-1-simon.marchi@polymtl.ca> <5030fe47c2855e56139d7629d2e6e370@polymtl.ca> Message-ID: <7e414de440d77d9a11aac61eabcb9481@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00557.txt.bz2 On 2017-02-20 15:22, Luis Machado wrote: > On 02/18/2017 01:23 PM, Simon Marchi wrote: >> On 2017-02-13 15:02, Luis Machado wrote: >>> Also, should we consider converting DISASSEMBLY_SOURCE_DEPRECATED or >>> should we let it go? It was introduced in 2015. >> >> What do you mean by "converting"? > > Since it is deprecated, do we need to convert/carry it over to the > enum definitions? If not, it could be dropped. > > I haven't looked much into this, so i'm not sure if we're still > considering it acceptable to use this deprecated flag. This flag corresponds to the /m modifier of the disas command, which itself has been deprecated in 7.11. As long as we don't remove the modifier, we can't remove the flag. Simon